summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Dombrowski <stefan@uni-bonn.de>2011-05-01 13:03:49 +0200
committerStefan Dombrowski <stefan@uni-bonn.de>2011-05-01 13:03:49 +0200
commite3a74efb4fd09e5a65cba3adee5551027c8d6676 (patch)
treedafe6724615e37b73d3e1f8f4d5f4a0405c15057
parentab95093c44bdde1d1aeccf20c46ecb87a7d244a9 (diff)
downloadmana-client-e3a74efb4fd09e5a65cba3adee5551027c8d6676.tar.gz
mana-client-e3a74efb4fd09e5a65cba3adee5551027c8d6676.tar.bz2
mana-client-e3a74efb4fd09e5a65cba3adee5551027c8d6676.tar.xz
mana-client-e3a74efb4fd09e5a65cba3adee5551027c8d6676.zip
Fixing checking of being positions send by the server
Reviewed-by: thorbjorn
-rw-r--r--src/map.cpp2
-rw-r--r--src/net/manaserv/beinghandler.cpp12
2 files changed, 7 insertions, 7 deletions
diff --git a/src/map.cpp b/src/map.cpp
index f1d27e4f..8b1d7b26 100644
--- a/src/map.cpp
+++ b/src/map.cpp
@@ -620,7 +620,7 @@ bool Map::contains(int x, int y) const
bool Map::containsPixel(int x, int y) const
{
- return contains(x ? x / mTileWidth : 0, y ? y / mTileHeight : 0);
+ return contains(x / mTileWidth, y / mTileHeight);
}
MetaTile *Map::getMetaTile(int x, int y) const
diff --git a/src/net/manaserv/beinghandler.cpp b/src/net/manaserv/beinghandler.cpp
index ac4a2404..cff0ff71 100644
--- a/src/net/manaserv/beinghandler.cpp
+++ b/src/net/manaserv/beinghandler.cpp
@@ -129,11 +129,11 @@ void BeingHandler::handleBeingEnterMessage(Net::MessageIn &msg)
BeingDirection direction = (BeingDirection)msg.readInt8();
Being *being;
- if(!Game::instance()->getCurrentMap()->containsPixel(px ,py))
+ if (!Game::instance()->getCurrentMap()->containsPixel(px, py))
{
- logger->log("Warning: Received GPMSG_BEING_ENTER for being id "
- "%i with position outside the map boundaries "
- "(x = %i, y = %i)", id, px, py);
+ logger->log("Warning: Received GPMSG_BEING_ENTER for being id %i "
+ "with position outside the map boundaries "
+ "(x = %i, y = %i)", id, px, py);
return;
}
@@ -242,7 +242,7 @@ void BeingHandler::handleBeingsMoveMessage(Net::MessageIn &msg)
logger->log("Warning: Received GPMSG_BEINGS_MOVE for being id "
"%i with position outside the map boundaries "
"(x = %i, y = %i)", id, sx, sy);
- return;
+ continue;
}
Vector serverPos(sx, sy);
@@ -258,7 +258,7 @@ void BeingHandler::handleBeingsMoveMessage(Net::MessageIn &msg)
logger->log("Warning: Received GPMSG_BEINGS_MOVE for being id "
"%i with destination outside the map boundaries "
"(x = %i, y = %i)", id, dx, dy);
- return;
+ continue;
}
being->setDestination(dx, dy);