summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThorbjørn Lindeijer <thorbjorn@lindeijer.nl>2012-02-24 21:16:12 +0100
committerThorbjørn Lindeijer <thorbjorn@lindeijer.nl>2012-03-24 22:28:23 +0100
commita5690fa2a4cce2698225f1f558183f6fe306d860 (patch)
tree822d4e237412afd38008de04d9be11fd0718f101
parent054246ebffcdd20da72a8e464b40eaf64d484743 (diff)
downloadmana-client-a5690fa2a4cce2698225f1f558183f6fe306d860.tar.gz
mana-client-a5690fa2a4cce2698225f1f558183f6fe306d860.tar.bz2
mana-client-a5690fa2a4cce2698225f1f558183f6fe306d860.tar.xz
mana-client-a5690fa2a4cce2698225f1f558183f6fe306d860.zip
Introduced compile-time option to disable use of C++0x
This is in order to still support older compilers, in particular GCC 4.2.1, so that Mana may be compiled for Maemo 5. Reviewed-by: Yohann Ferreira
-rw-r--r--CMakeLists.txt1
-rw-r--r--src/CMakeLists.txt6
-rw-r--r--src/cpp0x_compat/cstdint7
-rw-r--r--src/gui/serverdialog.cpp4
-rw-r--r--src/gui/serverdialog.h2
-rw-r--r--src/utils/mutex.h5
6 files changed, 21 insertions, 4 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3710a027..2e06d02d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -31,6 +31,7 @@ FIND_PACKAGE(Gettext)
OPTION(WITH_OPENGL "Enable OpenGL support" ON)
OPTION(ENABLE_NLS "Enable building of tranlations" ON)
OPTION(ENABLE_MANASERV "Enable Manaserv support" OFF)
+OPTION(ENABLE_CPP0X "Enable use of C++0x features" ON)
IF (WIN32)
SET(PKG_DATADIR ".")
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 977524e9..e0a42478 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -34,7 +34,11 @@ ENDIF()
SET(FLAGS "-DPACKAGE_VERSION=\\\"${VERSION}\\\"")
SET(FLAGS "${FLAGS} -DPKG_DATADIR=\\\"${PKG_DATADIR}/\\\"")
SET(FLAGS "${FLAGS} -DLOCALEDIR=\\\"${LOCALEDIR}/\\\"")
-SET(FLAGS "${FLAGS} -std=c++0x")
+IF (ENABLE_CPP0X)
+ SET(FLAGS "${FLAGS} -std=c++0x -DENABLE_CPP0X=1")
+ELSE()
+ INCLUDE_DIRECTORIES("cpp0x_compat")
+ENDIF()
IF (ENABLE_NLS)
SET(FLAGS "${FLAGS} -DENABLE_NLS=1")
diff --git a/src/cpp0x_compat/cstdint b/src/cpp0x_compat/cstdint
new file mode 100644
index 00000000..d8d71d9d
--- /dev/null
+++ b/src/cpp0x_compat/cstdint
@@ -0,0 +1,7 @@
+/*
+ * Compatibility header used when the compiler doesn't support C++0x.
+ *
+ * It doesn't seem necessary for it to contain anything, at least GCC 4.2.1
+ * compiles Mana fine so it apparently understands types like uint16_t by
+ * default.
+ */
diff --git a/src/gui/serverdialog.cpp b/src/gui/serverdialog.cpp
index f9fcb597..49de7f38 100644
--- a/src/gui/serverdialog.cpp
+++ b/src/gui/serverdialog.cpp
@@ -90,13 +90,13 @@ ServersListModel::ServersListModel(ServerInfos *servers, ServerDialog *parent):
int ServersListModel::getNumberOfElements()
{
- MutexLocker lock = mParent->lock();
+ MutexLocker lock(mParent->getMutex());
return mServers->size();
}
std::string ServersListModel::getElementAt(int elementIndex)
{
- MutexLocker lock = mParent->lock();
+ MutexLocker lock(mParent->getMutex());
const ServerInfo &server = mServers->at(elementIndex);
std::string myServer;
myServer += server.hostname;
diff --git a/src/gui/serverdialog.h b/src/gui/serverdialog.h
index eedf5134..cf9e62e7 100644
--- a/src/gui/serverdialog.h
+++ b/src/gui/serverdialog.h
@@ -113,7 +113,7 @@ class ServerDialog : public Window,
protected:
friend class ServersListModel;
- MutexLocker lock() { return MutexLocker(&mMutex); }
+ Mutex *getMutex() { return &mMutex; }
friend class CustomServerDialog;
/**
diff --git a/src/utils/mutex.h b/src/utils/mutex.h
index 26ad754e..f7f26233 100644
--- a/src/utils/mutex.h
+++ b/src/utils/mutex.h
@@ -53,7 +53,9 @@ class MutexLocker
{
public:
MutexLocker(Mutex *mutex);
+#ifdef ENABLE_CPP0X
MutexLocker(MutexLocker&&);
+#endif
~MutexLocker();
private:
@@ -93,11 +95,14 @@ inline MutexLocker::MutexLocker(Mutex *mutex):
mMutex->lock();
}
+#ifdef ENABLE_CPP0X
inline MutexLocker::MutexLocker(MutexLocker&& rhs):
mMutex(rhs.mMutex)
{
rhs.mMutex = NULL;
}
+#endif
+
inline MutexLocker::~MutexLocker()
{
if (mMutex)