diff options
| author | Bjørn Lindeijer <bjorn@lindeijer.nl> | 2009-01-10 00:57:09 +0100 |
|---|---|---|
| committer | Ira Rice <irarice@gmail.com> | 2009-01-09 21:30:20 -0700 |
| commit | bbc0fb7292460c7d383d16c25aa21bc68c06c27c (patch) | |
| tree | 16454509f4078b42100b47de9bd86b2b9adc92fb | |
| parent | 6c806db4367e161d915196cd4638a44a941fca20 (diff) | |
| download | mana-client-bbc0fb7292460c7d383d16c25aa21bc68c06c27c.tar.gz mana-client-bbc0fb7292460c7d383d16c25aa21bc68c06c27c.tar.bz2 mana-client-bbc0fb7292460c7d383d16c25aa21bc68c06c27c.tar.xz mana-client-bbc0fb7292460c7d383d16c25aa21bc68c06c27c.zip | |
Merged comment by silene from mainline
We should probably look into fixing the thing he's talking about.
| -rw-r--r-- | src/gui/browserbox.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/gui/browserbox.cpp b/src/gui/browserbox.cpp index 8b222810..8be32ebb 100644 --- a/src/gui/browserbox.cpp +++ b/src/gui/browserbox.cpp @@ -352,6 +352,10 @@ BrowserBox::draw(gcn::Graphics *graphics) char const *hyphen = "~"; int hyphenWidth = font->getWidth(hyphen); + /* FIXME: This code layout makes it easy to crash remote + clients by talking garbage. Forged long utf-8 characters + will cause either a buffer underflow in substr or an + infinite loop in the main loop. */ do { if (!forced) |