diff options
| author | Freeyorp <TheFreeYorp@NOSPAM.G.m.a.i.l.replace> | 2013-05-27 21:44:15 +1200 |
|---|---|---|
| committer | Freeyorp <TheFreeYorp@NOSPAM.G.m.a.i.l.replace> | 2013-05-27 21:44:15 +1200 |
| commit | 276ac8a19d1ddcdcbf1d43515e9af770984e9d81 (patch) | |
| tree | 7298d306c369c45f2f188017173d28fba9280d06 | |
| parent | 9e39e89f8196da4a42ea21131b5c11fcce71166e (diff) | |
| download | manavis-276ac8a19d1ddcdcbf1d43515e9af770984e9d81.tar.gz manavis-276ac8a19d1ddcdcbf1d43515e9af770984e9d81.tar.bz2 manavis-276ac8a19d1ddcdcbf1d43515e9af770984e9d81.tar.xz manavis-276ac8a19d1ddcdcbf1d43515e9af770984e9d81.zip | |
Pass brushG to redrawBrush
d3.select(this) is wasteful and not always reliable
| -rw-r--r-- | public/js/util/trellis-chart.js | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/public/js/util/trellis-chart.js b/public/js/util/trellis-chart.js index 1d24248..97dcc98 100644 --- a/public/js/util/trellis-chart.js +++ b/public/js/util/trellis-chart.js @@ -261,7 +261,7 @@ function trellisChart(anchor, monoGroups) { .on("brush", function () { var extent = extendBrush(d, brushG); - redrawBrush(d, i); + redrawBrush(d, i, brushG); if (brushIsEmpty(extent, d.brush)) { dc.events.trigger(function () { @@ -287,13 +287,12 @@ function trellisChart(anchor, monoGroups) { } } - function redrawBrush(d, i) { + function redrawBrush(d, i, brushG) { if (d.filter() && d.brush().empty()) d.brush.extent(d.filter()); - var gBrush = d3.select(this).select("g.brush"); - gBrush.call(d.brush.x(_scale)); - gBrush.selectAll("rect").attr("height", chartLen); + brushG.call(d.brush.x(_scale)); + brushG.selectAll("rect").attr("height", chartLen); // TODO: fade the deselected area } |