summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2013-11-26Fixed Bug 7855shennetsind1-2/+2
Follow up 61841e7861f63d98ecb417e2bf17135970b79c5a http://hercules.ws/board/tracker/issue-7855-error-compiling-vb-2013/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-25calc_return_damage cleanup & fixesshennetsind2-90/+92
Fixed skill_id not being passed and thus causing some conditions to never be met, dropped some other conditions that would never be met and thus were just wasting space. Moved clif damage outside so that its only used once and with the overall damage instead of several times aggregating the combined delay. Special Thanks to Haruna. Signed-off-by: shennetsind <ind@henn.et>
2013-11-25Fixed getareachar_skillunit v4 and minor cleanupshennetsind4-114/+108
Special thanks to Rytech for pointing it out, updated to match latest data (Thanks to Yommy) and some minor cleanup Signed-off-by: shennetsind <ind@henn.et>
2013-11-25Fixed Bug 7827shennetsind1-1/+13
Fixed reflect shield not respecting maps reduction flags. Data tested and confirmed on official server, special Thanks to Yommy and Haruna. http://hercules.ws/board/tracker/issue-7827-reflect-shield-woe-reductions-autoguard/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-25Fixed Bug 7838shennetsind1-1/+1
Was pointing to the wrong message id, special thanks to sevenzz23 http://hercules.ws/board/tracker/issue-7838-wrong-message/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-25Fixed Bug 7764shennetsind1-0/+1
Server now (virtually) enforces character to be facing north upon teleporting, fixes issues such as when you're facing left, teleports, uses high jump, and still goes left even though client makes it look like you're facing north. Special Thanks to kyeme. http://hercules.ws/board/tracker/issue-7764-warp-facing/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-25Fixed Bug 7833shennetsind1-0/+1
instance custom map names no longer linger in the index after the instance is destroyed http://hercules.ws/board/tracker/issue-7833-instancing-issues/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-25Fixed txt_time (used by @time)shennetsind1-11/+10
number of screwed up scenarios e.g. when day, hour and second are 0 but minute is not. Signed-off-by: shennetsind <ind@henn.et>
2013-11-25Fixed Bug 7849shennetsind1-35/+14
@time crash depending on night/day timer settings, also dropped 2 unsupported scenarios (been there for ages) http://hercules.ws/board/tracker/issue-7849-map-crash/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-25Fixed equip_level_max handling in the sql db convertershennetsind2-3/+15
The field is now NULL when the value is not provided, instead of MAX_LEVEL. Special Thanks to Mvmbles for bringing the issue to our attention. Signed-off-by: shennetsind <ind@henn.et>
2013-11-22Minor HPMi Sub Modificationsshennetsind5-16/+44
- HPMi->addCommand is now addAtcommand, dropped usage of ACMD_A() - HPMi->addScript is now addScriptCommand, dropped usage of BUILDIN_A() - HPMi->addCPCommand is now addCPCommand, dropped necessity of CPCMD_A() - HPMi->addPacket is now addPacket, 5th param (HPMi->pid) is now automatically filled by the macro, therefore param count drops to 4 (packetID,packetLength,packetFunction,packetIncomingPoint). There is no longer necessity to check for the availability of the commands, the macros will do it on their own and drop a warning about it upon failure. These changes won't affect pre-compiled plugins. Signed-off-by: shennetsind <ind@henn.et>
2013-11-21Fixed a somehow-cygwin-only warning 'array subscript is above array bounds'shennetsind1-1/+1
Signed-off-by: shennetsind <ind@henn.et>
2013-11-20Dropped some unused aliases in atcommand usage messages.shennetsind1-4/+4
Those were prone to be confusing with the recent implementation of charban/charunban, special thanks to uzieal for bringing it up. Signed-off-by: shennetsind <ind@henn.et>
2013-11-20Added support for 'make plugin.pluginname' to compile only 'pluginname'Haru7-123/+153
- Various Makefile optimizations Signed-off-by: Haru <haru@dotalux.com>
2013-11-19Fixed Bug 7840shennetsind1-1/+1
Special Thanks to kyeme for all the debug information and help! http://hercules.ws/board/tracker/issue-7840-char-server-crash/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-19Merge branch 'master' of https://github.com/HerculesWS/Herculesshennetsind59-800/+1035
2013-11-19Fixed Bug 7799 - SC_MOONSTAR neverendingshennetsind1-2/+10
Follows up 665f1306a130d4b8c359972bf4e58ef9d3bd9cd8 http://hercules.ws/board/tracker/issue-7799-sc-moonstar/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-19Fixed wrong parentheses in a condition in status_calc_regen_rateHaru1-27/+20
- eAthena:15257 - Teh wrong parentheses cause the condition to be always false, which in turn causes SP regen to continue while under SC_EXTREMITYFIST/SC_EXPLOSIONSPIRITS statuses. Signed-off-by: Haru <haru@dotalux.com>
2013-11-19Added support for Max EquipLv in Pre-RenewalHaru1-7/+1
- Follow-up to ed72a947a6c97804c1eef5b80bfa49d99f7d7586 - Max EquipLv is now observed, rather than ignored, in pre-renewal mode. Signed-off-by: Haru <haru@dotalux.com>
2013-11-19Replaced hardcoded Item IDs with constantsHaru6-217/+448
- This makes it harder to get the item IDs wrong in the code. - Fixes item 'Slot_Coupon' being incorrectly considered a Spell Book due to an oversight (wrong item nameid) when the check was introduced. Signed-off-by: Haru <haru@dotalux.com>
2013-11-19Sanitized and improved several macros through the codeHaru54-508/+495
- Sanitized all potentially unsafe macros (related eA:15259) - Improved some function-like macros to evaluate their argument only once and keep it in a temporary variable. This improves performance in the damage calculation related code. Signed-off-by: Haru <haru@dotalux.com>
2013-11-18Merge pull request #224 from datmumbles/size_changesshennetsind8-46/+46
Corrected size-related constant names (closes #222).
2013-11-19HPM Hooks UpdateHercules.ws3-0/+30
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2013-11-18Merge branch 'master' of https://github.com/HerculesWS/Herculesshennetsind3-13/+13
2013-11-18Fixed Bug 7819 - Renewal Elemental Damageshennetsind1-5/+1
Special Thanks to Michieru for gathering official server data and testing. http://hercules.ws/board/tracker/issue-7819-element-tables/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-18Fixed the erroneously redirected GM Full Strip Packetshennetsind3-1/+19
Implemented in 2009-10-27, the packet was being redirected to a account name req packet, while it was a entirely different feature. this fixes the (GM-Suit) 'right click' option 'remove all equipment'. Special Thanks to Yommy. Signed-off-by: shennetsind <ind@henn.et>
2013-11-19HPM Hooks UpdateHercules.ws3-13/+13
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2013-11-18Follow up aee2f6317e1c927847993801b5973d7e2e27a418shennetsind2-10/+20
Fixed glitch that'd occur in clients with login screen where even after logging out the client would still remember previously sent banned timestamps, keeping the char banned until client was reopened. Also dropped a error message map server would show up when banning offline characters. Special Thanks to Mvmbles for pointing it out, Haruna for testing and helping fix it. Signed-off-by: shennetsind <ind@henn.et>
2013-11-18Modified charban char server responding actionshennetsind2-11/+11
so that the char id is used instead of account id, thus not disconnecting the account id from map server unless the char id being banned is online, special thanks to haruna. Signed-off-by: shennetsind <ind@henn.et>
2013-11-18Fixed itemdb elvmax issue caused by inheritshennetsind1-1/+1
Special Thanks to Yommy, Haruna. Signed-off-by: shennetsind <ind@henn.et>
2013-11-18Corrected size-related constant names and cleaned up comments (closes #222).Mumbles8-46/+46
2013-11-18Follow-up to 1f5161a2bd3c7934373146d8cac3c131536758baHaru1-1/+7
- Added explicit column names in the item_db query, to ensure it will throw a SQL error in case some are missing, rahter than silently failing and returning incorrect data. - Added sql upgrade file to add the bindonequip column to the item_db2 table for those who have it. - As with all the item_db2 upgrade scripts, you need at least MySQL 5.0 in order to run it. If your version is not compatible, or if the script fails for any reason, manual upgrade instructions are provided within the script. - Special thanks to Mumbles. Signed-off-by: Haru <haru@dotalux.com>
2013-11-18HPM Hooks UpdateHercules.ws3-30/+30
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2013-11-18Follow-up to d9a89c56ea63e369999ca13f1584eef9e511490fHaru1-3/+3
- Updated db2sql plugin to reflect the latest changes. - Fixes bugreport:7835, special thanks to ossi0110 http://hercules.ws/board/tracker/issue-7835-db2sql-plugin-error/ Signed-off-by: Haru <haru@dotalux.com>
2013-11-18Fixed an issue with item_db2 entries that specify Inherit, and no ScriptHaru2-55/+102
- Added missing source documentation for the itemdb overhaul related functions. - Slighty refactored the readdb sql function. - Special thanks to sevenzz23 for reporting the crash issue (topic:3029) http://hercules.ws/board/topic/3029-ritem-data-structure-overhaul-error-msg/ and to Ind for testing. Signed-off-by: Haru <haru@dotalux.com>
2013-11-17Merge branch 'master' of https://github.com/HerculesWS/Herculesshennetsind3-10/+114
2013-11-17Fixed Bug 7832shennetsind1-0/+3
http://hercules.ws/board/tracker/issue-7832-compile-issue/ Signed-off-by: shennetsind <ind@henn.et>
2013-11-17Added emblem blank pixels checkHaru3-10/+114
- Made possible thanks to (and using base code by) Ai4rei - eAthena r15263 and add-on patch http://hercules.ws/board/topic/2974-add-on-patch-for-ea-r15263-commit/ - Modified to allow checking for a percentage of transparent pixels rather than full image transparency. - Tweaked to accept some other bmp formats that are currently allowed by the client. - The performance hit from enabling this check is negligible (benchmarks show that scanning an emblem requires about half the time required to decompress it after it's received), but it does exist, as noted in the configuration file. - Special thanks to Ind. Signed-off-by: Haru <haru@dotalux.com>
2013-11-16Renewal elemental attr fixshennetsind2-2/+7
I'm committing on malufett's behalf. Signed-off-by: shennetsind <ind@henn.et>
2013-11-16Merge branch 'master' of https://github.com/HerculesWS/Herculesshennetsind4-3/+95
2013-11-16Introducing Character Ban Support.shennetsind10-77/+232
@charban/@charunban, can temporarily block any accounts as opposed to the usual account-wide block. Special Thanks to Haruna, Yommy! Signed-off-by: shennetsind <ind@henn.et>
2013-11-16Fixed a mapserver crash when using SQL item DB and an item's script is NULLHaru1-3/+3
- Special thanks to Mumbles. Signed-off-by: Haru <haru@dotalux.com>
2013-11-16Minor char server char list fixesshennetsind1-9/+5
the array was being erroneously modified in old client packets. Signed-off-by: shennetsind <ind@henn.et>
2013-11-16Fixed atcommand alias bug on selected commandsshennetsind1-23/+23
Modified the issues in question to check against the source command name, ensuring that the conditions work even when an alias is used. Also replaced sensitive conditions with insensitive ones, Special Thanks to Haruna. Signed-off-by: shennetsind <ind@henn.et>
2013-11-16Updated char server's response to offline map servershennetsind1-4/+16
Previously attempting to log in while map server was unavailable or not yet ready would close the client, now the char select window shows up and attempting to select a character while the map server is unavailable will display a pop up "the map is not available", client will remain in char select window and won't close anymore. Special Thanks to Haruna. Signed-off-by: shennetsind <ind@henn.et>
2013-11-16Fixed char server's maintenance modeshennetsind3-21/+52
Enabling the maintenance mode will now restrict login based on group id (previously maintenance mode was merely cosmetic and would allow all accounts to access). Renamed char-server.conf setting char_maintenance to char_server_type, added char_maintenance_min_group_id to be used in conjunction with char_server_type:1 Signed-off-by: shennetsind <ind@henn.et>
2013-11-16HPM Hooks UpdateHercules.ws3-0/+92
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2013-11-15Official expiration timer supportshennetsind4-6/+85
As brought up in http://hercules.ws/board/topic/2225-paid-server/ Special Thanks to Haruna for all the help! Thanks to Beret, Ai4rei for information Signed-off-by: shennetsind <ind@henn.et>
2013-11-15HPM Hooks UpdateHercules.ws3-0/+30
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2013-11-15Official Item BindOnEquip Supportshennetsind7-9/+41
Implements the 'BindOnEquip' item db field which determines whether the piece of equipment should bind to the character upon being equipped. When a character tries to equip such a item for the first time a dialog shows up asking the character to confirm whether to equip the item or not, and notifying the character that by equipping the item it will become bound to the character, and therefore unable to be used by another character. Special Thanks to Beret for all the information, Haruna for testing. Signed-off-by: shennetsind <ind@henn.et>