| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
- improved @makehomun -1 so that if the homun data hasnt been loaded it is requested.
- instances of private types (party/guild/char) no longer create channels, however global types still does (IOT_NONE).
- Fixed an issue with party/guild instance data not being freed when either is destroyed (Special Thanks to Yommy).
Signed-off-by: shennetsind <ind@henn.et>
|
|
pc_checkitem is now triggered by @reloaditemdb to ensure modified conditions are respected, also a performance boost that causes the itemlist/cartlist/storagelist/gstoragelist lookups to only be triggered on demand instead of on every teleport.
Closes #219
Fixed ancient monster ai bug that caused mobs to consider themselves elegible targets, which would waste status_check_skilluse and battle_check_target calls.
Signed-off-by: shennetsind <ind@henn.et>
|
|
adjustment.
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
|
|
- The .favorite field of newly added inventory items wasn't correctly
initialized to zero, potentially causing data loss (fixes
bugreport:7854, thanks to Vincent, GrumpyPanda).
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Modified reflect code so that each reflection source can judge whether to apply or not, necessary for mechanics such as item-bonus reflect triggers even on autoguard while reflect shield does not.
Re-added that "reflect shield" overhead display which I mistakenly removed in fdb6de1aa34086fd4d22ae127437727f556cea3c. Added code to refrain damage numbers from overlapping in the client, which would render them illegible.
Special Thanks to kyeme, Yommy.
http://hercules.ws/board/tracker/issue-7792-safety-wall-reflect-bug-body-relocation-error/
Signed-off-by: shennetsind <ind@henn.et>
|
|
- [ This commit is part of a larger script engine related update ]
- Adjacent string literals are now automatically concatenated into one
string upon parsing.
- Adjacent string literals are string literals (i.e. "such as this",
with only whitespace (including line breaks and/or comments) between
them. For example, the lines:
mes "this will be concatenated " /* skipping this
comment */ " into one string"; // at parse time
will produce an output of "this will be concatenated into one string".
- The feature brings parity with other languages (i.e. C), and makes it
easier to split long strings in multiple lines, without having to
resort to a, slower, run-time string concatenation operator ('+')
- Special thanks to Trojal for the idea.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- [ This commit is part of a larger script engine related update ]
- Operator precedence rules now closely follow those of languages such
as C and derivates/related (C++, Java, PHP, etc.)
- Please note that if you had custom scripts with non parenthesized
expressions containing bitwise |, &, ^ operators, they may behave
incorrectly now (or perhaps they were already behaving incorrectly,
since the previous behavior was undocumented).
- Added an up to date operator precedence/associativity table in the
script documentation.
- Added an operator/keyword self-test script in the npc/custom folder,
in case if may be of some use for future regression-testing.
|
|
- [ This commit is part of a larger script engine related update ]
- Suffix ++ and -- operators now behave like in other languages
(updating the variable *after* its value is returned.)
- Prefix ++ and -- operators are added for parity with other
scripting/programming languages. They update the variable they're
applied to *before* returning its value.
- Please note that the implementation of the prefix form of those
operators (like it happens in most languages) is more efficient than
the suffix form. '++.@i' is (slightly) faster than '.@i++', or at
least not slower.
- Fixed some outdated script debug functions.
- Follow-up to c18f438.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- [ This commit is part of a larger script engine related update ]
- Since: c18f438
Signed-off-by: Haru <haru@dotalux.com>
|
|
Official item drop announce support, currently hardcoded list -- we'll be following up shortly with a decent way of storing it.
Special Thanks to Yommy, Beret, kyeme.
http://hercules.ws/board/tracker/issue-7858-monster-rare-drop-announcement/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
Thanks to kyeme for bringing it to our attention.
Signed-off-by: shennetsind <ind@henn.et>
|
|
warping (e.g. @recall) of autotrade characters no longer leaves them in memory limbo, the trigger that'd be expected from the client is now called for autotrade units so that they complete the warp procedure in full, vendings are loaded properly as well.
http://hercules.ws/board/tracker/issue-7495-autotrade/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Updated damage reflection logic to reflect the official (but weird to say the least) logic, whereas ATK_BLOCK can trigger reflection (e.g. inside safety wall) instead of only ATK_DEF (atk_def = attack connected, yup misleading name).
Special Thanks to Yommy, kyeme, Haruna.
http://hercules.ws/board/tracker/issue-7792-safety-wall-reflect-bug-body-relocation-error/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Modified @itembound so that it provides feedback in case of bind conditions that fail to meet. pc_additem messages will remain so that any other area that might create a invalid bind item will still be cancelled and provide feedback.
Special Thanks to kyeme.
http://hercules.ws/board/tracker/issue-7805-itembound-console-error-when-no-partyguild/
Signed-off-by: shennetsind <ind@henn.et>
|
|
magic reflect now nullifies any knockback.
Special Thanks to Yommy.
http://hercules.ws/board/tracker/issue-7859-magic-reflect-knock-back/
Signed-off-by: shennetsind <ind@henn.et>
|
|
monster's healing now refreshes their hp bar accordingly.
Special Thanks to Beret.
http://hercules.ws/board/tracker/issue-7794-healing-in-monsters/
Signed-off-by: shennetsind <ind@henn.et>
|
|
@useskill adjusted to update invincibility state.
http://hercules.ws/board/tracker/issue-7700-using-useskill-command/
Signed-off-by: shennetsind <ind@henn.et>
|
|
mon_trans_disable_in_gvg: yes no longer displays the error message repeatedly to no purpose.
Special Thanks to kyeme
http://hercules.ws/board/tracker/issue-7838-wrong-message/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Follow up 61841e7861f63d98ecb417e2bf17135970b79c5a
http://hercules.ws/board/tracker/issue-7855-error-compiling-vb-2013/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Fixed skill_id not being passed and thus causing some conditions to never be met, dropped some other conditions that would never be met and thus were just wasting space. Moved clif damage outside so that its only used once and with the overall damage instead of several times aggregating the combined delay.
Special Thanks to Haruna.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Special thanks to Rytech for pointing it out, updated to match latest data (Thanks to Yommy) and some minor cleanup
Signed-off-by: shennetsind <ind@henn.et>
|
|
Fixed reflect shield not respecting maps reduction flags.
Data tested and confirmed on official server, special Thanks to Yommy and Haruna.
http://hercules.ws/board/tracker/issue-7827-reflect-shield-woe-reductions-autoguard/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Was pointing to the wrong message id, special thanks to sevenzz23
http://hercules.ws/board/tracker/issue-7838-wrong-message/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Server now (virtually) enforces character to be facing north upon teleporting, fixes issues such as when you're facing left, teleports, uses high jump, and still goes left even though client makes it look like you're facing north.
Special Thanks to kyeme.
http://hercules.ws/board/tracker/issue-7764-warp-facing/
Signed-off-by: shennetsind <ind@henn.et>
|
|
number of screwed up scenarios e.g. when day, hour and second are 0 but minute is not.
Signed-off-by: shennetsind <ind@henn.et>
|
|
@time crash depending on night/day timer settings, also dropped 2 unsupported scenarios (been there for ages)
http://hercules.ws/board/tracker/issue-7849-map-crash/
Signed-off-by: shennetsind <ind@henn.et>
|
|
- HPMi->addCommand is now addAtcommand, dropped usage of ACMD_A()
- HPMi->addScript is now addScriptCommand, dropped usage of BUILDIN_A()
- HPMi->addCPCommand is now addCPCommand, dropped necessity of CPCMD_A()
- HPMi->addPacket is now addPacket, 5th param (HPMi->pid) is now automatically filled by the macro, therefore param count drops to 4 (packetID,packetLength,packetFunction,packetIncomingPoint).
There is no longer necessity to check for the availability of the commands, the macros will do it on their own and drop a warning about it upon failure.
These changes won't affect pre-compiled plugins.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Signed-off-by: shennetsind <ind@henn.et>
|
|
Those were prone to be confusing with the recent implementation of charban/charunban, special thanks to uzieal for bringing it up.
Signed-off-by: shennetsind <ind@henn.et>
|
|
- Various Makefile optimizations
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Follows up 665f1306a130d4b8c359972bf4e58ef9d3bd9cd8
http://hercules.ws/board/tracker/issue-7799-sc-moonstar/
Signed-off-by: shennetsind <ind@henn.et>
|
|
- eAthena:15257
- Teh wrong parentheses cause the condition to be always false, which in
turn causes SP regen to continue while under
SC_EXTREMITYFIST/SC_EXPLOSIONSPIRITS statuses.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Follow-up to ed72a947a6c97804c1eef5b80bfa49d99f7d7586
- Max EquipLv is now observed, rather than ignored, in pre-renewal mode.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- This makes it harder to get the item IDs wrong in the code.
- Fixes item 'Slot_Coupon' being incorrectly considered a Spell Book due
to an oversight (wrong item nameid) when the check was introduced.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Sanitized all potentially unsafe macros (related eA:15259)
- Improved some function-like macros to evaluate their argument only
once and keep it in a temporary variable. This improves performance
in the damage calculation related code.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Corrected size-related constant names (closes #222).
|
|
Special Thanks to Michieru for gathering official server data and testing.
http://hercules.ws/board/tracker/issue-7819-element-tables/
Signed-off-by: shennetsind <ind@henn.et>
|
|
Implemented in 2009-10-27, the packet was being redirected to a account name req packet, while it was a entirely different feature. this fixes the (GM-Suit) 'right click' option 'remove all equipment'.
Special Thanks to Yommy.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Fixed glitch that'd occur in clients with login screen where even after logging out the client would still remember previously sent banned timestamps, keeping the char banned until client was reopened.
Also dropped a error message map server would show up when banning offline characters.
Special Thanks to Mvmbles for pointing it out, Haruna for testing and helping fix it.
Signed-off-by: shennetsind <ind@henn.et>
|
|
so that the char id is used instead of account id, thus not disconnecting the account id from map server unless the char id being banned is online, special thanks to haruna.
Signed-off-by: shennetsind <ind@henn.et>
|
|
Special Thanks to Yommy, Haruna.
Signed-off-by: shennetsind <ind@henn.et>
|
|
|
|
- Added explicit column names in the item_db query, to ensure it will
throw a SQL error in case some are missing, rahter than silently
failing and returning incorrect data.
- Added sql upgrade file to add the bindonequip column to the item_db2
table for those who have it.
- As with all the item_db2 upgrade scripts, you need at least MySQL 5.0
in order to run it. If your version is not compatible, or if the
script fails for any reason, manual upgrade instructions are provided
within the script.
- Special thanks to Mumbles.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Added missing source documentation for the itemdb overhaul related
functions.
- Slighty refactored the readdb sql function.
- Special thanks to sevenzz23 for reporting the crash issue (topic:3029)
http://hercules.ws/board/topic/3029-ritem-data-structure-overhaul-error-msg/
and to Ind for testing.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Made possible thanks to (and using base code by) Ai4rei - eAthena
r15263 and add-on patch
http://hercules.ws/board/topic/2974-add-on-patch-for-ea-r15263-commit/
- Modified to allow checking for a percentage of transparent pixels
rather than full image transparency.
- Tweaked to accept some other bmp formats that are currently allowed
by the client.
- The performance hit from enabling this check is negligible (benchmarks
show that scanning an emblem requires about half the time required to
decompress it after it's received), but it does exist, as noted in the
configuration file.
- Special thanks to Ind.
Signed-off-by: Haru <haru@dotalux.com>
|
|
I'm committing on malufett's behalf.
Signed-off-by: shennetsind <ind@henn.et>
|
