Age | Commit message (Collapse) | Author | Files | Lines |
|
This commit ensures that `sd->status.class` and related variables only
contain Job Classes (i.e. the client-compatible values, where High
Novice 4001) and are never checked against the bitmask-based MapID
values.
As a rule of thumb, from now on, when a variable is named `class`, it
is intended to contain a Job Class ID and not a MapID. The type of such
variable shall be a signed `int16` or `int`.
To ensure that related third party code is also verified when this
commit is merged, the variable `struct mmo_charstatus::class_ (i.e.
`sd->status.class_`) is renamed to `class`.
Some issues in related lines are also fixed, including:
- A wrong check in the char server would prevent the correct detection
of babies in code related to the family exp sharing.
- Baby Arch Bishops would not be affected by Eucharistica.
- A wrong check would cause the `questinfo()` script command not to
display its information for most classes (except 1-1 classes).
- Map IDs and Job Classes were mixed up in `itemdb_jobid2mapid()` and
`itemdb_jobmask2mapid()` for 1-1 classes (causing currently no harm,
since they just happen to coincide).
- The Baby Sura class would not cause parties to be marked as
containing a monk type character (for SLS Team Up purposes).
- Baby Geneticists would bypass the cart check when trying to equip
ammunitions.
- Baby Mechanics would bypass the Mado Gear check when trying to equip
ammunitions.
- Transcendent Shadow Chasers would lose the Stalkers' ability to clone
transcendent skills.
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
b0006317e5cc4a48cd5b8a501b94813cd3b93670
- Their original value was `17` (0x11), which is equivalent to
`SCFLAG_NOAVOID|SCFLAG_NOICON`, rather than `SCFLAG_ALL` (0x1f)
Signed-off-by: Haru <haru@dotalux.com>
|
|
Implemented SC_CATNIPPOWDER:
Increases WAtk%, MAtk% and Reduces Movement Speed.
Increases Natural Hp/Sp Recovery
|
|
Increases BaseAtk and MAtk by 10%
|
|
|
|
Cannot be reset by dispell.
Cannot be healed by item/NPC once in BITESCAR.
Heal Skill would end the BiteScar Effect.
|
|
Lasts for (30+30*SkillLv) Seconds.
Consumes 1 Shrimp.
Increases ATK and MATK by 10% for limited time.
|
|
Protects the target for 30 seconds.
Tuna's Defense Power: (10+(20*(SkillLv-1)))% of Caster's MaxHP
|
|
Atk +(200+100*SkillLv)%.
When 1 Carrot is consumed, Add's a chance to stun enemy.
Lv1-2: 3x3 AoE
Lv3-4: 5x5 AoE
Lv5: 7x7 AoE
Added Item Constants in itemdb.h
|
|
For (50+10*SkillLv) Seconds, Atk +(15+5*SkillLv). Increases Movement
Speed.
If Target is Doram Race, Increases Range Physical attack by 10%.
|
|
Heal,Cure,Clearance cancels the effect.
Atk + 100*SkillLv%.
Reduces Fixed Amount of MaxHP for 9 seconds.
For Every 30 Base Levels, Adds an Additional chance that skill will be
activated again.
|
|
Duration: (5+(2*SkillLv)) seconds.
Cannot be used on Boss Monsters. Effect is cancelled when Heaven's Drive
or Trample is used.
Enemies trapped on roots receive poison property damage.
|
|
Increases Flee, Hit and CRI by 20.
If >= 20 Skill points invested in animal-based skills, Ranged Physical
Attack + 20%.
|
|
Catnip Meteor:
Increases Matk by 200+100*SkillLevel%.
When 1 Catnip is consumed, Adds a Chance to curse target[Not Implemented].
|
|
Consumes 1 Catnip Fruit.
Lv 1-2: 3x3 AoE
Lv 3-4: 5x5 AoE
Lv 5: 7x7 AoE
Lasts for (2+SkillLevel) Seconds
Increases Natural Recovery of HP/SP.
Reduces Atk and MAtk by 50%
Reduces Movement Speed.
|
|
Silvervine Steam Spear:
10% Bleeding Chance, 700% Matk at all levels.
Lv 1: Earth Magic
Lv 2: Fire Magic
Lv 3: Water Magic
Lv 4: Wind Magic
Lv 5: Ghost Magic
Base Level 30: Chance to activate skill again.
Every 30 Base Level: Increases the chance to activate skill.
|
|
Increases INT by 20,
If More than 20 skill points invested in plant based Skills, MATK+20%.
|
|
Consumes Fresh Shrimp to recover HP for 2 Minutes.
Max Level 5:
Recovers Every (11-SkillLevel) Seconds.
|
|
MaxHP + 1000, MaxSP + 100.
Show's Spirit of Sea, Land and Life around the sprite when skill is
learned.
|
|
Reduces Incoming Damange by 90% for 6 seconds.
When Knock Back, the effect disappears.
|
|
Max Level: 3
Attack Increases by 50+(50+Level)%
Base Level >= 30: Activates a Chance to cast skill again.
Every 30 Base Level: Increases the chance to cast skill again.
|
|
Transforms into Bush.
|
|
Fixes #1442
|
|
Some possible buffer overflows.
Add attribute for mark fallthrough cases.
Skipped libconfig warnings.
|
|
|
|
Fixes #571
|
|
New SkillInfo attributes:
FreeCastReduced - allow move while casting with slowdown
FreeCastNormal - allow move while casting with normal speed
|
|
Fixes several -Wsign-compare issues
Signed-off-by: Haru <haru@dotalux.com>
|
|
Also improve a bit cast end functions call.
|
|
Extend with new flag sc_config.txt
|
|
They should cancel each other, not prevent the usage (like Kyrie and
Assumptio)
Closes #1222 as merged
Signed-off-by: Haru <haru@dotalux.com>
|
|
Remove hardcoded visible effects from status.c and add visible flag into sc_config.txt
|
|
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Fixes #1014 - Corrects the Behavior of Tension Relax
|
|
use clif_get_bl_name
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
in pull request #1189
Changed other instances of MAX_WEAPON_TYPE to MAX_SINGLE_WEAPON_TYPE.
|
|
|
|
Also fix some array sizes.
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
INFINITE_DURATION, INVALID_TIMER, SC_NONE, INDEX_NOT_FOUND, depending on context.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The variable should be signed, since it uses the value -1 to indicate
infinite duration (and it's stored as signed in the database).
- Added #define for the special value -1 (INFINITE_DURATION).
- This fixes an issue causing status changes to fail being saved to
database (thanks to Michi for reporting it).
- Related to commit 8dc75721.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Add all missing -Wformat flags into configure.
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The return value is now consistent with the libconfig standard
(CONFIG_TRUE/CONFIG_FALSE).
- Removed some redundant error messages.
Signed-off-by: Haru <haru@dotalux.com>
|
|
PR_MAGNIFICAT Skill Fix.
|