summaryrefslogtreecommitdiff
path: root/src/map/skill.h
AgeCommit message (Collapse)AuthorFilesLines
2020-05-04Refactor the Bard/Dancer Soul Link temporary skill granting codeHaru1-0/+1
The code no longer relies on invalid assumptions about the mapping between skill IDs and indices Fixes #2670 Signed-off-by: Haru <haru@dotalux.com>
2020-03-14Remove skill_is_item_skill() function and use ↵Kenpachi Developer1-1/+0
map_session_data->autocast.type instead
2020-03-14Add skill_validate_autocast_data() functionKenpachi Developer1-0/+1
2020-03-11Add enumeration for auto-cast typesKenpachi Developer1-0/+9
2020-03-08Undo removal of attack->dir_unknownLeo Pflug1-0/+1
2020-03-08Refactor code using directions to use enum unit_dirskyleo1-5/+5
This removes a lot of duplicated code, especially related to people not using the arrays dirx and diry. Assertions for whenever these arrays are used have been added as well, to ensure valid index range. Some trailing white space has been removed as well.
2020-02-09Added skill_is_item_skill() function.Kenpachi Developer1-0/+1
2020-02-09Merge pull request #2596 from dastgirp/skill_idx_refactorHaru1-0/+6
Changed logic of skill_get_index
2020-02-02Changed logic of skill_get_indexDastgir1-0/+6
skill_get_index can be edited easily to add custom skills
2020-01-13Update copyright headers for year 2020Haru1-2/+2
Signed-off-by: Haru <haru@dotalux.com>
2019-10-29Dehardcode combo skills checkAsheraf1-0/+1
2019-05-06Merge pull request #2232 from guilherme-gm/201810-trap-visibilityHaru1-0/+2
Added option to make hunter traps invisible
2018-10-20Added option to make hunter traps invisibleGuilherme G. Menaldo1-0/+2
2018-08-30Fixed Blastime and Claymore Trap damage that wasn't being split by the ↵Guilherme G. Menaldo1-0/+1
number of enemies
2018-07-24Added missing parameter to init_unit_layout_unknownDastgir1-1/+1
2018-07-19Replace item id shorts to int in map server.Andrei Karas1-1/+1
2018-06-12Changed returntype of skill_check_condition_castend_unknown.Dastgir1-1/+1
skill_check_condition_castend is terminated if returntype is true
2018-05-312012-2018 !Maytichai Saowa1-1/+1
2018-04-08Allow guild skills cooldown to continue when logged outGuilherme G. Menaldo1-3/+1
2018-02-10Clean up trailing whitespace and non-indent tabsHaru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2018-01-25Implementation of Official Clan SystemMurilo Pereti Tavares1-0/+1
All official features work including the autokick for inactive members And the system is completely customizable.
2017-12-23Replace the use of skill_reproduce_db with AllowReproduce flagAsheraf1-2/+1
2017-11-24Allow using the skill DB accessors on non-skill attacks (skill_id = 0)Haru1-1/+5
This suppresses an assertion in the skill DB accessors when called with `skill_id = 0` (such as during normal attacks). In such case, they'll now return an appropriate zero value, as it happened before 2b4bfa5d0. Fixes #1909 Signed-off-by: Haru <haru@dotalux.com>
2017-11-18Merge pull request #1903 from Asheraf/skill_scaleHaru1-0/+1
Implement skill scale packet for client versions >= 20151223.
2017-11-16Implement skill scale packet for client versions >= 20151223.Asheraf1-0/+1
2017-11-05Reduce confusion between skill IDs and skill DB indexes (part 2)Haru1-2/+1
Remove MAX_SKILL in favor of MAX_SKILL_DB, when referring to the maximum skill DB index. This is opposed to MAX_SKILL_ID, the maximum skill ID. Signed-off-by: Haru <haru@dotalux.com>
2017-11-05Reduce confusion between skill IDs and skill DB indexes (part 1)Haru1-48/+50
Rewrite skill DB accessors to clarify the difference between IDs and indexes, and to report a backtrace to the console when an invalid ID is passed. The type of the skill_id and skill_lv arguments has been changed to int. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Clarify some Job Class vs MapID confusion (1/2)Haru1-1/+1
This commit ensures that `sd->status.class` and related variables only contain Job Classes (i.e. the client-compatible values, where High Novice 4001) and are never checked against the bitmask-based MapID values. As a rule of thumb, from now on, when a variable is named `class`, it is intended to contain a Job Class ID and not a MapID. The type of such variable shall be a signed `int16` or `int`. To ensure that related third party code is also verified when this commit is merged, the variable `struct mmo_charstatus::class_ (i.e. `sd->status.class_`) is renamed to `class`. Some issues in related lines are also fixed, including: - A wrong check in the char server would prevent the correct detection of babies in code related to the family exp sharing. - Baby Arch Bishops would not be affected by Eucharistica. - A wrong check would cause the `questinfo()` script command not to display its information for most classes (except 1-1 classes). - Map IDs and Job Classes were mixed up in `itemdb_jobid2mapid()` and `itemdb_jobmask2mapid()` for 1-1 classes (causing currently no harm, since they just happen to coincide). - The Baby Sura class would not cause parties to be marked as containing a monk type character (for SLS Team Up purposes). - Baby Geneticists would bypass the cart check when trying to equip ammunitions. - Baby Mechanics would bypass the Mado Gear check when trying to equip ammunitions. - Transcendent Shadow Chasers would lose the Stalkers' ability to clone transcendent skills. Signed-off-by: Haru <haru@dotalux.com>
2016-10-28Fixed copyright year for 2016Lemongrass31101-1/+1
2016-10-22Implemented SU_SV_ROOTTWIST Skill.Dastgir Pojee1-0/+3
Duration: (5+(2*SkillLv)) seconds. Cannot be used on Boss Monsters. Effect is cancelled when Heaven's Drive or Trample is used. Enemies trapped on roots receive poison property damage.
2016-10-22Added Summoner Skills(in DB)Dastgir Pojee1-0/+45
Added Summoner SC ID's in status.h
2016-09-03Add some missing functions in skill.c into interface.Andrei Karas1-0/+3
2016-07-19Add skill atributes for allow moving while casting skill.Andrei Karas1-15/+17
New SkillInfo attributes: FreeCastReduced - allow move while casting with slowdown FreeCastNormal - allow move while casting with normal speed
2016-07-12Add into skill.c some handling for unknown skills/skill units.Andrei Karas1-0/+5
Also improve a bit cast end functions call.
2016-07-12Fix reading skill_db.confAndrei Karas1-0/+1
2016-07-09Fixed some warnings while compiling HPMHookingHaru1-14/+14
Signed-off-by: Haru <haru@dotalux.com>
2016-07-09Merge pull request #1333 from Smokexyz/SkillDBLibHaru1-6/+19
Skill DB TXT files to LibConfig + converter
2016-07-09SkillDB TXT to Libconfig + converterSmokexyz1-6/+19
The conversion of 5 skill database files - skill_require_db.txt skill_unit_db.txt skill_cast_db.txt skill_castnodex_db.txt and skill_db.txt to Libconfig file skill_db.conf a PHP CLI converter is included to read from the above mentioned files and create a skill_db.conf in the same directory.
2016-07-05Move static methods into interface in skill.cAndrei Karas1-0/+3
2016-03-20Dropped typedef from DBMapHaru1-6/+6
Signed-off-by: Haru <haru@dotalux.com>
2016-03-20Dropped typedefs from union DBKey and struct DBDataHaru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2016-02-24Edited skill->changematerial() and skill->elementalanalysis() to use the new ↵Haru1-2/+3
struct itemlist - The skill-side code no longer depends on the client packet data layout. - Some data validation has been added. Signed-off-by: Haru <haru@dotalux.com>
2015-12-15Added GPL-compliant header to all sources and build scriptsHaru1-4/+20
Signed-off-by: Haru <haru@dotalux.com>
2015-08-26Fixed a faulty usage of sg->unit in land skill codeHaru1-2/+5
- Changed sg->unit and sg->unit_count into an explicit vector struct, to enforce the correct access. - Related: rathena/rathena#583 Signed-off-by: Haru <haru@dotalux.com>
2015-08-15HPM compatibility improvementsHaru1-5/+3
Improved compatibility, portability and standards conformance. - Since it is not possible to portably and reliably re-use the core's symbols in plugins, symbols are no longer exported unless explicitly required, in the UNIX builds. This mimics the Windows behavior and adds HPM compatibility to OSes such as FreeBSD. Credits to Andrei Karas for making this possible. - For convenience, it is no longer necessary to call GET_SYMBOL, since the plugin will automatically import all the available symbols when it's loaded, depending on the included headers. - Plugins are now supposed to include the "common/hercules.h" header before including anything else. Incluing common/HPMi.h, common/cbasetypes.h or conf/core.h is no longer necessary, as those are guaranteed to be automatically included by hercules.h. - HPM API version bumped to 1.1. Signed-off-by: Haru <haru@dotalux.com>
2015-07-25Reduce memory usage in HPM in skill.cAndrei Karas1-12/+16
2015-06-19Removed ".." from include directivesHaru1-6/+6
- Include directives are now directory-independent. - This will allow building plugins from other directories in future. Signed-off-by: Haru <haru@dotalux.com>
2015-05-31Follow up@027f124cbb96bb99d00bc31ad51345024edadf66malufett1-0/+1
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-05-19Fixed some issues reported by coverity scan [3/3]Haru1-0/+2
- Automatically zeroed variables are now zeroed in the correct size, regardless of padding. - Special thanks to Ind. Signed-off-by: Haru <haru@dotalux.com>
2015-02-13Fixed Bug#8529malufett1-1/+1
-http://hercules.ws/board/tracker/issue-8529-npc-earthquake-damage-calculation-bugged-and-possibly-wrong/?gopid=24559#entry24559 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>