summaryrefslogtreecommitdiff
path: root/src/map/battle.c
AgeCommit message (Collapse)AuthorFilesLines
2015-05-17Fixed some issues detected by coverity scanHaru1-4/+5
Signed-off-by: Haru <haru@dotalux.com>
2015-05-12Follow-up to fff2194Haru1-10/+11
Related: http://hercules.ws/board/tracker/issue-8672-map-server-error/ Signed-off-by: Haru <haru@dotalux.com>
2015-05-03Fixed Bug#8650malufett1-1/+3
-http://hercules.ws/board/tracker/issue-8650-minstrel-poem-of-netherworld-or-despair-song-skillleffect/?gopid=25083#entry25083 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-04-23Fixed Bug#8474malufett1-5/+12
-http://hercules.ws/board/tracker/issue-8474-elemental-damage-amplifier-doesnt-apply-to-cart-cannon/ Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-04-01Fixed Bug#8601malufett1-3/+3
-http://hercules.ws/board/tracker/issue-8601-chemical-protection/?gopid=24866#entry24866 Fixed proper skill fail message when bullet runs out.. Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-03-19Follow up 145a4fe644c4fe856ba6f83086e8ee5075caad99shennetsind1-0/+2
Thanks to Mordekaiser for pointing this scenario to us. Signed-off-by: shennetsind <ind@henn.et>
2015-03-19Follow up@210c963d2851eb880ba3560998ee984d942cde19malufett1-1/+3
-Thanks to michi and chatchanunn Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-03-19Fixed Bug 8582shennetsind1-2/+0
Solves an issue where an skill unit left-area event would not triggered due to duels. Special Thanks to Haruna, kyeme. http://hercules.ws/board/tracker/issue-8582-infinite-songs/ Signed-off-by: shennetsind <ind@henn.et>
2015-03-17Follow up@c2286f82e0843eedc5db04ca26ffd16fae9d6955malufett1-8/+2
-remove unnecessary modification(issue:469). Thanks to Dastgir and Michi Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-03-16RENEWAL Updates:malufett1-37/+103
-AM_DEMONSTRATION and AM_ACIDTERROR is now using RE formula. -Fixed damage modifiers of some skills. Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-03-15Fixed Bug#8569malufett1-0/+4
-http://hercules.ws/board/tracker/issue-8569-asura-strike/?gopid=24715#entry24715 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-03-11RENEWAL Updates:malufett1-61/+145
-Fixed card bonuses related to to ATK.(Added 'bRaceTolerance'). Thanks Michi for the support. -Fixed Renewal EDP. Special thanks to Awesome Yommy <3 -Enabled 'display_skill_fail' since '/skillfail' is already available in the client Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-02-23Add battle config option check_occupied_cells.Andrei Karas1-0/+1
If set check_occupied_cells to 0 it will allow walk to occupied cells And it heavy reduce CPU usage on walking.
2015-02-23Extend official_cell_stack_limit option.Andrei Karas1-1/+1
Now if this option is zero server will not count objects before comparing with official_cell_stack_limit. If set official_cell_stack_limit to zero it will heavy reduce CPU usage.
2015-02-13Merge branch 'master' of github.com:HerculesWS/Herculesshennetsind1-12/+19
2015-02-13Fixed alchemist marine sphere causing double deletion on renewalshennetsind1-3/+3
Special Thanks to Haruna, Michieru.
2015-02-13Fixed Bug#8529malufett1-12/+19
-http://hercules.ws/board/tracker/issue-8529-npc-earthquake-damage-calculation-bugged-and-possibly-wrong/?gopid=24559#entry24559 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-02-13Fixed Bug#8531malufett1-1/+13
-http://hercules.ws/board/tracker/issue-8531-skill-rapid-smiting-bug/?gopid=24563#entry24563 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-02-13Fixed Bug#8519malufett1-3/+5
-http://hercules.ws/board/tracker/issue-8519-ranger-skill-fear-breeze-completely-disables-crit/?gopid=24522 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-02-02Follow-up to 486ec86Haru1-1/+0
Removed unnecessary 'fall through' comment. Signed-off-by: Haru <haru@dotalux.com>
2015-01-30Missing breakNihadm891-0/+1
Lightning Spear of Ice
2015-01-30Fixed Bug#8416malufett1-1/+1
-http://hercules.ws/board/tracker/issue-8416-geneticcart-tornado/?gopid=23982#entry23982 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-01-23Cleaned up spirit charms implementation (optimized memory and CPU usage)Haru1-37/+30
Signed-off-by: Haru <haru@dotalux.com>
2015-01-20Minor fixes and tweaks suggested by cppcheckHaru1-21/+23
- Variable scopes reduced - Parenthesized ambiguous expressions - Removed or added NULL checks where (un)necessary - Corrected format strings - Fixed typos potentially leading to bugs Signed-off-by: Haru <haru@dotalux.com>
2015-01-18For bugreport 8397 (incomplete solution)shennetsind1-1/+12
Certain skills bypass invincibility http://hercules.ws/board/tracker/issue-8397-5-secs-invulnerability-on-positivesupportive-aoe-buff/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Replacing rand leftovers with the mt19937arshennetsind1-5/+5
Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Fixing 38 issuesshennetsind1-1/+7
Addressing out of bounds read/write, pointless null checks on already deferenced variables, dead code. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-1727 Fixesshennetsind1-1/+2
Addressing out of bounds read/write, pointless null checks on already deferenced variables. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-17Another ~10 Fixesshennetsind1-1/+1
Addressing out of bounds read/write. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-1710 Distinct fixesshennetsind1-1/+1
Addressing out of bounds read-write. Special Thanks to 4144, Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-10Extend battle.c for using custom skills from plugins.Andrei Karas1-0/+30
2015-01-06Fixed LK_SPIRALPIERCE & NJ_TATAMIGAESHI change in damage output. Thanks to Michimalufett1-11/+12
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-31Remove useless checks.Andrei Karas1-1/+1
2014-12-31Add some missing null pointer checks after automatic checks.Andrei Karas1-0/+2
2014-12-28Follow up@990c25267aeefe4d792bf941a366a6603afcb42bmalufett1-1/+3
-sorry PRE-RE users I always forget about you..:D Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-28Merge pull request #427 from csnv/skillsworkHaruna1-5/+3
PR_KYRIE Visual fix, EDP corrections. Preliminary fix Maya Purple Hack update position.
2014-12-28Fixed offensive skill formulas of KG/OB to official.malufett1-22/+20
Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-27Fixes EDP for Grimtooth and Venom Knife. Bug report 6259: ↵csnv1-5/+3
http://hercules.ws/board/tracker/issue-6259-edp-on-grimtooth-not-working-properly-pre-re/
2014-12-26Updated KG/OB Spirit Charms to official behaviormalufett1-35/+40
-http://hercules.ws/board/tracker/issue-8170-oborokagerou-charm/ -http://hercules.ws/board/tracker/issue-8274-ninja-charms-not-giving-proper-bonuses/ Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-10RENEWAL Updates:malufett1-35/+48
-Homunculus Official Statuses -Updated RE @mobinfo to show proper status data.(Follow up 28a8b0f7b06a6af86aff6ececf7d9541d457e297) -Some official behaviors. Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2014-12-02Follow-up to 26cdd53, 0623d4fHaru1-1/+1
Whitespace cleanup Signed-off-by: Haru <haru@dotalux.com>
2014-11-26Update Fire Expansion to official formula for all levelMichieru1-0/+7
Fix Full Throttle Order of Calculations For Stat Increase/Decrease By Status's Mega Thanks to Rytech
2014-11-24* 1st Transcendent Spirit, monster position lag fixesMichieru1-5/+4
- 1st Transcendent Spirit will now work as on official servers (#116) * The max total stat that is granted by the skill is now BaseLevel-10 with a maximum of 50 instead of always 50 * It will now work as Marionette Control and calculate the bonus at cast time rather than overwrite all existing bonuses * Agi Up and Blessing will now cancel the soul link - Fixed various problems that caused position lags on the client (#118) * Added a define ACTIVEPATHSEARCH in mob.c; if active (default and official), monsters will only grab targets if the walk path to the target is shorter or equal their search range; search range depends on whether the monster is moving or not (range2 for standing monsters and range3 for walking monsters); this requires a lot of CPU load, if it causes trouble, just comment the define for old behavior * Fixed a bug that made monsters display "irregular movement with position lag" continuously when a status change ended that changed their walk speed * OFFICIAL_WALKPATH now also applies to monsters * If the path search fails while a unit is already moving, we will now issue of fixpos packet so that the unit does not only stop moving on the server, but also on the client * Direction fixes - Updated the config setting attack_direction_change from 15 to 0 (official value); that means that a unit's direction will no longer change when it attacks; knock-back effects from e.g. Firewall will depend on the last direction the target walked into instead (bugreport:1322) - Ensured that the default direction of a monster is always "north", so that immobile monsters will now always be knocked back to the south by e.g. Firewall on default settings, unless a skill like e.g. Backstab changes their direction (bugreport:1322) - Fixed a bug that stopped characters server-sided and caused position lag when closing a skill menu * Magnum Break damage fixed - Targets two cells away will now only take 100%+10%*level damage (#108)
2014-11-17(Bugs 5237 and 7979)GrumpyLittlePanda1-0/+1
- Land Protector now behaves more like on official servers * Land Protector now protects from units being placed on it, no matter if they have splash range or not * Land Protector no longer protects from damage from units not outside Land Protector that splash inside * Meteor Storm no longer shows meteors falling if they would land on Land Protector * Pneuma can no longer be placed next to Land Protector * Safety wall no longer consumes gem if cast on LP. * Also cleaned up the code a bit, so the checks are done where they should be done - Ground skill splash ranges updated to their official values * Lord of Vermilion places units in a 11x11 area with 3x3 splash range each * Storm Gust places units in a 9x9 area with 3x3 splash range each * Heaven's Drive places units in a 5x5 area with no splash range * Venom Dust now has a splash range of 3x3 and is consequently larger than before - Storm Gust's knock-back behavior updated to official * Each of Storm Gust's units will knock back "Away from center" * As units in the south-west are processed first, the knock-back direction will usually be north-east * At the edges the knock-back direction will be "to the outside" * Land Protector and Ganbantein will influence the knock-back behavior strongly, e.g. if Storm Gust has a hole in the middle, it will have a "suck in" effect * Added a config option for those who want the old "random direction" behavior from eAthena
2014-11-16Whitespace cleanup (no code changes)Haru1-173/+174
This includes, and is not limited to: mixed or wrong indentation, excess whitespace (horizontal and vertical), misalignment, trailing spaces. Signed-off-by: Haru <haru@dotalux.com>
2014-11-03HPM Hooks UpdateHercules.ws1-5/+5
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2014-11-03* No cell stacking implemented (official version)Michieru1-4/+5
- Split config cell_stack_limit into custom_cell_stack_limit (previous feature) and official_cell_stack_limit (see below) - Expanded map_count_oncell by a flag parameter, currently only one flag is supported: only count standing units (needed for official cell stack feature) - Added a new function map_closest_freecell that will return the closest free cell using the same order that official servers use - Monsters will now actively search for a free cell when starting to walk randomly and when unlocking target - When any unit finishes walking (regularly) and is not on a free cell, it will now actively search for a free cell - Step actions will be delayed until a suitable cell was found, they will even be executed when the player walked slightly out of attack range - Monsters will now stop instantly if their target is completely non-existent * This is mainly for looters that had their loot taken * Hide and most other situations still use the configuration setting monster_chase_refresh Mega Thanks to Playtester
2014-11-03Re-issuing conflicted-out content on battle.c (see history/follow up)shennetsind1-0/+8
Signed-off-by: shennetsind <ind@henn.et>
2014-10-31- Monster chase range updates (bugreport:7637)Michieru1-1/+2
* Updated monster_chase_range in monster.conf from 1 to 3; I originally thought official value is 1, but doing some in-depth tests myself I realized it's 3 for the most important situations * When a monster cannot issue new "move" commands because it was affected by a status change, but is still moving due to knockback immunity, it will no longer unlock its target and stop * Fixed a bug that always caused the chase path monsters calculated to be 1 cell too short causing them to recalculate their path one cell before their goal every single time - Fixed the direction calculation once again and optimized it at the same time (bugreport:9373) * Now the calculated direction is 100% official, really truly, checked it myself with every single cell and various skills * Added a new function map_calc_dir_xy that allows to check for a direction between two cells without the need of a block_list * map_calc_dir will now just use map_calc_dir_xy to avoid duplicate code * Improved Icewall walk block implementation - Moved the configuration setting "icewall_walk_block" to monster.conf - Split the configuration into mob_icewall_walk_block and boss_icewall_walk_block so it can be configured for bosses separately - Expanded the configuration * If the value is set to 1, monsters on an ice wall cell will behave like trapped monsters, that means they won't be able to move at all, they will use idle skills and if they are attacked while nobody is in their attack range, they will use their rudeattacked skills; this is equal to official behavior of bosses * If the value is set to 2-255, it will behave as before but monsters in the AI loop now use both idle and chase skills, but will no longer use their rudeattacked skills even if attacked from range; this is equal to official behavior of normal monsters * Official values would be "220" for normal monsters (loop until Icewall expiration) and "1" for bosses (behave like trapped monster) on most official servers, but as some official servers have a less exploitable implementation (from looping AI only a limited amount of times up to outright blocking Icewall on all maps with bosses) - Cleaned up the rudeattacked code a little so it's easier to read - Fire Pillar is no longer a trap and can no longer be hit or knocked back in renewal Thanks to Playtester (rathena b43b855d2, 902c920b734cd)
2014-10-30Fixed Bug#7736malufett1-0/+1
-http://hercules.ws/board/tracker/issue-7736-fist-spell-w-double-attack-and-similar-effects/?gopid=20575#entry20575 Fixed RE ATK random variance. Thanks to Angelmelody. Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>