summaryrefslogtreecommitdiff
path: root/src/char
AgeCommit message (Collapse)AuthorFilesLines
2014-10-25Added some missing variable initializationsHaru4-3/+13
- The issue was caused by memcmp failing because of garbage in structs padding. - Fixes bugreport:8410, special thanks (and credits for the fix) to Garr http://hercules.ws/board/tracker/issue-8410-autotradeat-issue/ - Also reduced scope of some variables, where appropriate. - Thanks to Ind. Signed-off-by: Haru <haru@dotalux.com>
2014-10-23In configure add option --enable-staticAndrei Karas1-1/+1
This option enable static build for server binaries and map cache. For plugins this option enable static linking with gcc.
2014-10-23Added some validation checks in the geoip parse functionHaru1-9/+14
This fixes the warning on some compilers, about the fread return value being ignored. Signed-off-by: Haru <haru@dotalux.com>
2014-09-21Fixed Bug 8171shennetsind1-3/+3
Char server could crash if attempting to log-in a character while map server hasn't completed the char >- <- map handshake Special Thanks to memoryss http://hercules.ws/board/tracker/issue-8171-char-server-crash-oninterifinitoninterifinitonce/ Signed-off-by: shennetsind <ind@henn.et>
2014-09-20Merge pull request #332 from 4144/missing_rfifoskipshennetsind1-0/+1
Add missing RFIFOSKIP in packet 0x68 and 0x1fb. Fixes Bug 8317 http://hercules.ws/board/tracker/issue-8317-missing-rfifoskip-in-packet-0x68-and-0x1fb/
2014-09-16"Fixes char server crash when saving ##variables while login server is ↵Michieru1-5/+12
offline, thanks to Ancyker" Fix made by Ind :)
2014-09-05Improved some FIFOSD checks in char_parse.Andrei Karas1-11/+9
Signed-off-by: Haru <haru@dotalux.com>
2014-08-31Add missing RFIFOSKIP in packet 0x68 and 0x1fb.Andrei Karas1-0/+1
2014-08-07Fixed some MSVC incompatibilitiesHaru2-0/+2
- Resolves bugreport:8289 http://hercules.ws/board/tracker/issue-8289-compile-error-vs-2013/ - Disables some winsock-related deprecation warnings. Signed-off-by: Haru <haru@dotalux.com>
2014-08-07Corrected several format-string errors through the codeHaru6-37/+32
- Functions that expect a printf-style format string are now marked as such, so that gcc/clang will emit a warning warn you if you mismatch format string and arguments. Signed-off-by: Haru <haru@dotalux.com>
2014-07-11Fixed reserved __identifier violationsHaru13-39/+39
- Complies with CERT DCL37-C - Fixes issue #293 (special thanks to elfring) Signed-off-by: Haru <haru@dotalux.com>
2014-05-30Merge pull request #282 from MrKeiKun/fix_typoHaruna8-46/+46
Fixed some typo
2014-05-30Fixed typos inside src/Shido8-46/+46
2014-05-30Removed CMakeLists.txt (Thanks to Haruna)Shido1-62/+0
2014-05-25Improved CFLAGS/CPPFLAGS handlingHaru1-1/+3
- Language extensions, such as _GNU_SOURCE are now enabled through CPPFLAGS by the configure script, rather than within the source code. - Moved some configure-time CFLAGS to CPPFLAGS, where appropriate. - Fixes bugreport:8211, thanks to Neoth http://hercules.ws/board/tracker/issue-8211-compiling-warning-in-linux Signed-off-by: Haru <haru@dotalux.com>
2014-05-17Renamed incuvate of Pet System.Shido2-13/+13
2014-05-13Removed trailing whitespace (sources)Haru4-11/+11
Signed-off-by: Haru <haru@dotalux.com>
2014-05-10Re-commit of "Fixed order of includes in all source files"Haru21-150/+195
This reverts commit 94657284973f4037596bae468ebfbee5c217e02b.
2014-05-10Revert "Fixed order of includes in all source files"panikon21-195/+150
This reverts commit b6b3f58795288701d0e162d43fa6f0a47af913b3. Fixes issue 8184 http://hercules.ws/board/tracker/issue-8184-cart-related/
2014-05-09Removed extra'GeoIP disabled' message on charserver shutdownHaru1-9/+10
Signed-off-by: Haru <haru@dotalux.com>
2014-05-09Fixed order of includes in all source filesHaru21-150/+195
- Changed order according to the (upcoming) code style guidelines. - Fixes several issues caused by missing headers when their include order is changed or in plugins. Signed-off-by: Haru <haru@dotalux.com>
2014-05-09Added support to return a different exit status to the OS.Haru1-1/+2
- This can be easily used by plugins. - See an example at http://github.com/HerculesWS/StaffPlugins/Haru/script_mapquit Signed-off-by: Haru <haru@dotalux.com>
2014-05-08Fixed issue 8176panikon1-0/+1
http://hercules.ws/board/tracker/issue-8176-lastet-commit-cant-compile-successfully-on-linux/ Sorry for taking so long, it seems that even if errno.h is not included in MSVC errno is still available, but that doesn't happen in unix compilers.
2014-05-07Follow up to 9a425c1panikon2-6/+8
Special thanks to @MishimaHaruna
2014-05-06Bug fixes and other changespanikon2-25/+144
#Fixed issue where a corrupted map cache would lead to a crash *Moved Big-endian compatibility functions to common/utils.h #Fixed issue 8162 *http://hercules.ws/board/tracker/issue-8162-loadnpc-doesnt-trigger-oninit-of-duplicate-npcs/ *Added options to npc_parse_duplicate #Fixed issue 8169 *http://hercules.ws/board/tracker/issue-8169-script-command-guildskill-skill-idlevel-not-working-as-intended/ *Changed *guildskill behavior, now it behaves exactly as depicted in the documentation *Updated *guildskill documentation #Added missing GBI types to mapif_parse_GuildBasicInfoChange now it's possible to change guild exp, lv, skill point and skill information #GeoIP revamp *GeoIP module was partially rewritten *Added several data checks to prevent corruption and crashes *Updated GeoIP database *See https://github.com/maxmind/geoip-api-c/blob/master/libGeoIP/GeoIP.c for more information #Added packetver checks regarding NST_MARKET *Now *tradertype warns if user is trying to use this feature with older clients
2014-04-19Fixed issue: 8150panikon1-8/+8
* http://hercules.ws/board/tracker/issue-8150-cash-shop-updating-quantity-bug/ * Also fixed issue where when using ATitem to get more than one pet egg would result on getting only one egg * Changed packet 0x3880 structure now it also contains pet class and dropped flag from this packet, it was pointless
2014-04-19Merge pull request #272 from hemagx/masterHaruna5-50/+6
Rewritten NSI_UNIQUE_ID system
2014-04-18Rewritten NSI_UNIQUE_ID system to get rid of the cross-database interreg ↵Ibrahim Hossam5-50/+6
dependency - Removes the need for map-server to access the interreg table to store the last used ID. - Login, char and map databases can now be hosted separately. - Note: the unique_id structure has changed, and it now contains the generator character ID in its upper 32 bits. - Now NSI_UNIQUE_ID System is enabled always Special thanks to Haruna.
2014-04-17Added sysinfo (System Information) functionalitiesHaru1-1/+8
- More informative messages are displayed during startup, to make it easier to identify what system and environment Hercules is running. - Git/SVN revision detection is improved, separating the source version (cached at compile time) from the runtime version, in case the user updated their working copy without recompiling the server. Git version detection is also more reliable, in case a non-default branch is used. - The get_revision script command has been removed (as it was useless to begin with, after the switch to git). An alternative will be provided later, for feature-probing purposes. - The patch was tested under Linux (Gentoo / gcc 4.7 on i686 and x86_64, Debian 6 / gcc 4.4 on i686, Raspbian / gcc 4.6 on armv6l, CentOS 5 / gcc 4.1 on i686, CentOS 6 / gcc 4.4 on x86_64, Linux Mint 15 / gcc 4.7 on x86_64, OS X Mountain Lion / clang 5.0 and gcc 4.8 on x86_64, Cygwin-NT-5.1/gcc 4.8 on i686, FreeBSD 8 / gcc 4.2 on i386, FreeBSD 9 / gcc 4.2 on amd64, FreeBSD 10 / clang 3.3 on amd64, NetBSD 5 / gcc 4.1 on i386, NetBSD 6 / gcc 4.5 on amd64, OpenBSD 5 / gcc 4.2 on amd64, Solaris 11 / gcc 4.5 on i86pc, Windows 7 / Visual Studio 2012 on x86, Windows 8 / Visual Studio 2010 on WOW64, Windows 8.1 / Visual Studio 2013 on WOW64. Signed-off-by: Haru <haru@dotalux.com>
2014-04-12Added sanity checks in itemboundretrieve_subpanikon1-2/+11
2014-04-12Fixed some compiler/analyzer warnings.Haru1-9/+10
- Sanitized some macros (they weren't going to cause problems, but better being safe than sorry) - Parenthesized an incorrect expression in 6f6a6b3. - Inverted an if(foo); else bar; statement in 6f6a6b3 to get rid of the empty expression (for legibility). - Commented out some unnecessary lines as suggested by clang's static analyzer. Signed-off-by: Haru <haru@dotalux.com>
2014-04-10Fixed issue: 7939panikon1-53/+64
http://hercules.ws/board/tracker/issue-7939-change-sex/ Also cleaned a bit the change sex process
2014-04-10Fixed issue: 7936panikon2-8/+62
http://hercules.ws/board/tracker/issue-7936-guildparty-item-bounded/
2014-03-25Added new return values to make_new_char_sqlpanikon1-28/+47
Added char_id to charlog Corrected RE check in skill_magic_reflect (see commit c9310f3)
2014-03-22Fixed issue 7338 (added new char configuration char_aegis_delete)panikon1-15/+32
http://hercules.ws/board/tracker/issue-7338-deleting-character/ As @jaBote requested in 26f2ada, renamed "rathena-logs-database-upgrade" to "rAthena-logs-upgrade.sql" and updated 'last revision'. Added a 'FIXME' in db_obj_put
2014-03-16Added --load-plugin commandline argumentHaru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2014-03-14Fixed Bug 8078shennetsind1-2/+4
gms relogging while char server is on char_server_type will no longer get rejected. Special Thanks to Beret. http://hercules.ws/board/tracker/issue-8078-maintenance-mode-enabled/ Signed-off-by: shennetsind <ind@henn.et>
2014-03-06Minor whitespace fixHaru3-13/+10
(trying to trigger a HPM Hooks rebuild missing from my previous commit) Signed-off-by: Haru <haru@dotalux.com>
2014-02-27Cleaned up messages.confHaru1-130/+151
- Removed some unused messages. - Re-mapped some duplicate IDs - fixes bugreport:8057, thanks to AnnieRuru http://hercules.ws/board/tracker/issue-8057-jobname-with-invalid-id-return-tomb/ - Fixed some issues with the message range loaded by the char server. - Reworded some messages, fixed typos in others. Note for translation users: some messages have been remapped to new IDs. You'll need to remap them in your custom translations as well. The list of changes is as follows: - Removed messages (you can safely remove them from your translations): 15, 26-27, 35, 48-52, 57-58, 65-69, 82-83, 86-87, 91, 101, 140-142, 164, 189-194, 199-200, 202-203, 209-211, 215-218, 267-268, 275, 289-290, 380-385, 387-388, 401, 497, 499, 535-537, 922, 995, 1063, 1079, 1291-1294 - New messages (you need to add them to your translations): 15 - Moved messages (you need to change their IDs in your translations file): * [Unknown Job] 656 -> 620, * [Job names] 681~693 -> 656~668 * [Tombstone related] 656~661 -> 856~861 * [Etc messages] 662~680 -> 862~880 * [@version] 1436 -> 1294 * [Hercules Chat] 1475 -> 1436 Signed-off-by: Haru <haru@dotalux.com>
2014-02-19Follow up 9132878d911cfe720eaad94ad3d4a5dd11958f99shennetsind1-0/+4
Fixed issue (8023) with sc rows (only those of tick = -1, aka permanent scs) duplicating due to lack of primary index. Special Thanks to Flash, Haru. Note that the upgrade script will clear the permanent statuses from your sc_data table (e.g. lex aeterna, carts) to ensure no issues are left. Signed-off-by: shennetsind <ind@henn.et>
2014-02-13Fixed bug 7279panikon1-10/+35
http://hercules.ws/board/tracker/issue-7279-starting-items/
2014-02-11Fixed bug 7980panikon1-0/+1
2014-02-10Merge pull request #256 from hemagx/masterHaruna4-67/+81
Merged~ Thank you for your contribution to Hercules!
2014-02-02Fixed Bug 7962shennetsind1-0/+34
Fixed issue with "permanent" (durationless) status changes (such as carts) integrity caused on server shutdown. Special Thanks to Haru! http://hercules.ws/board/tracker/issue-7962-command-at/ Signed-off-by: shennetsind <ind@henn.et>
2014-02-02Introducing HPM Datacheckshennetsind13-39/+39
http://hercules.ws/board/topic/4283-introducing-hpm-datacheck/ Signed-off-by: shennetsind <ind@henn.et>
2014-02-02Update inter server so ask login server for account information Instead of ↵Ibrahim Hossam4-67/+81
do query to login table. Thanks to Haruna to clean it up.
2014-01-22Improved questlog handling to honor the value of MAX_QUEST_OBJECTIVESHaru1-15/+52
Signed-off-by: Haru <haru@dotalux.com>
2014-01-22Improvements to exp_guild.txt loadingHaru1-28/+22
- Modified exp_guild.txt processing to honor the value of MAX_GUILDLEVEL and correctly handle overflows. Signed-off-by: Haru <haru@dotalux.com>
2014-01-18Socket interfacedshennetsind1-12/+12
We designed this one with having as little changes required elsewhere in mind, thus the way most socket-related things are called has not changed. Plugins may now take a greater advantage of the socket features. Signed-off-by: shennetsind <ind@henn.et>
2014-01-12Changed some void* to the correct data types where applicableHaru1-1/+0
Signed-off-by: Haru <haru@dotalux.com>