summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-01-24Adjust 2@nyd areamobsRidley1-9/+9
fixes 1551 http://herc.ws/board/tracker/issue-8657-nydhoggs-nest/
2017-01-23Merge pull request #1555 from Asheraf/jupeRidley1-51/+59
Add quest log for Juperos Ruins History Quest
2017-01-23Merge pull request #1557 from Asheraf/mocRidley1-1/+1
Correct Para_Team_Mark_ effect.
2017-01-23Merge pull request #1493 from Emistry/script_eden_questRidley1-94/+64
Update Eden Quest script
2017-01-22Correct Para_Team_Mark_ effect.Asheraf1-1/+1
in kRO Para_Team_Mark_ warp the player to eden group.
2017-01-22Add quest log for Juperos Ruins History QuestAsheraf1-51/+59
* also change name of 2 variables to the official names - yuno_hist -> yuno_book - jupe_hist -> jupe_book partial merge of rathena/rathena@c488268d8c2fa74e1d16daf0c04a6bf2d36e2350
2017-01-22Fix CMDLINE_OPT_PARAM arguments in plugins failing to loadHaru1-0/+2
When the server is called with a plugin-defined argument expecting additional values, in the form '--foo bar', the parser is unable to skip the additional value until the plugin is fully loaded. The issue was caused by the first scans of the argument list to find CMDLINE_OPT_PREINIT or CMDLINE_OPT_SILENT arguments, which happen before plugins are loaded, and would cause the parser to choke on the additional values, interpreting them as separate arguments. This is related to PR #1552, where we attempted to use this option for the first time. Signed-off-by: Haru <haru@dotalux.com>
2017-01-15Merge pull request #1545 from HerculesWS/md5bufHaru6-38/+36
Update md5 calculation to be able to hash a binary buffer instead of …
2017-01-14HPM Hooks Updatehemagx4-20/+20
Signed-off-by: hemagx <ibrahem.h.basyone@gmail.com>
2017-01-10Update md5 calculation to be able to hash a binary buffer instead of only ↵hemagx2-18/+16
strings Signed-off-by: hemagx <ibrahem.h.basyone@gmail.com>
2017-01-05Fixed announces from Koschei the Immortal (Moscovia Quests) (#1542)landergate1-3/+3
2017-01-03Merge pull request #1491 from Smokexyz/patch-1Ibrahem Hossam4-1/+26
zenylog missing type 'K' for Bank Transactions
2017-01-03Merge pull request #1526 from fisune/masterIbrahem Hossam1-4/+2
Fixing an small markdown mistake
2017-01-03Merge pull request #1486 from MuzTank/masterIbrahem Hossam1-0/+2
Fixed airships.txt
2017-01-02Merge pull request #1536 from Asheraf/ontouchDastgir7-34/+3
Fixed incorrect OnTouch label in Crow of Destiny Quest
2017-01-02Update *waitingroom script document (#1537)Emistry Haoyan1-1/+1
- when trigger event label, it run as *donpcevent() not *doevent(), no player are attached to the script when it's triggering the event.
2017-01-02MobDB SQL SyncHercules.ws3-3/+3
Signed-off-by: HerculesWSAPI <dev@herc.ws>
2017-01-02ItemDB SQL SyncHercules.ws3-3/+3
Signed-off-by: HerculesWSAPI <dev@herc.ws>
2017-01-02HPM Hooks UpdateHercules.ws15-15/+15
Signed-off-by: HerculesWSAPI <dev@herc.ws>
2017-01-02Double NPC Name in Royal Guard job change quest (#1538)Ridley1-1/+0
2016-12-30Fixed incorrect OnTouch label in Crow of Destiny QuestAsheraf7-34/+3
Credit: rathena/rathena@a9faab82cbcfbdb3009c5584032505e8617310bd
2016-12-13Merge pull request #1529 from Asheraf/quest13Ibrahem Hossam1-0/+5
Add a custom weight check in ring of the wise king quest
2016-12-12Add a custom weight check in ring of the wise king questAsheraf1-0/+5
2016-12-08Fixing an small markdown mistakeFisune1-4/+2
2016-12-07Re-add -fvisibility=hidden on FreeBSD (necessary for plugins)Haru1-1/+1
Related to 2ceb249879148be0fca7d81f31158eccf3142aa2, which removed the option since it didn't appear to be necessary on Linux or macOS. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Merge pull request #1522 from HerculesWS/jobclass-mapid-cleanupAndrei Karas39-812/+1110
Job Class vs Job MapID cleanup
2016-12-03HPM Hooks UpdateHaru5-124/+158
Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Remove the platform-dependent variables from struct status_dataHaru11-60/+61
`struct status_data::class_` was platform dependent since c30bb75ec50624429bff7b4106db4be0fda366d6 in order to silence some compile warnings (uint32 on 64 bit builds and uint16 on 32 bit builds). It's now been changed to the correct type, int32, on all platforms. Since the change has potential to silently break third party code, the variable was renamed to `class`. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Add function to retrieve the appropriate fame list type for a job mapidHaru5-31/+38
This commit adds the function `pc->famelist_type()` to retrieve the appropriate fame list for a given job (common operation). When the given job ID doesn't have an appropriate fame list, the newly introduced value RANKTYPE_UNKNOWN is returned. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Change the argument to pc->famerank() to a rank type (instead of job mapid)Haru4-22/+42
For consistency with `pc->addfame()`, the argument to pc->famerank() is now an enum fame_list_type. The function was renamed to `pc->fame_rank()` to avoid silently compiling old non-compliant code. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Ensure that pc->addfame() increments the correct fame pointsHaru5-38/+56
The function now takes the rank type as argument, rather than guessing it from the character's class. If the wrong fame point type for the current character is requested, the request is ignored. This fixes some (unofficial) edge cases where a Taekwon or an Alchemist refined a signed item, they could obtain rank points. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Clarify some Job Class vs MapID confusion (2/2)Haru11-215/+251
This commit ensures that `sd->job` and related variables only contain MapIDs (i.e. the serverside optimized values, where High Novice is MAPID_NOVICE | JOBL_UPPER) and are never checked against the client-based Job Class values. As a rule of thumb, from now on, when a variable is named `job` or `jobid`, it is intended to contain a MapID and not a Job Class ID. The type of such variable shall be an unsigned `uint16` or `uint32`. To ensure that related third party code is also verified when this commit is merged, the variable `struct map_session_data::class_ (i.e. `sd->class_`) is renamed to `job`. Some issues in related lines are also fixed, including: - The atcommand `@mount` would not check properly that the requesting character is a 2nd class Swordsman type. - `pc->addfame()` would silently accept invalid MapIDs, sending unknown values to the client (more on this in a subsequent commit). - `pc->famerank()` would not use the passed job as a bitmask, causing the caller to have to mask it beforehand (more on this in a subsequent commit). - The Soul Linker check in TK_JUMPKICK wasn't future-proof (no harm caused currently). - Gunslingers would be able to be targeted by Spiritual Bestowment (`MO_KITRANSLATION`) and Spiritual Sphere Absorption (`MO_ABSORBSPIRITS`) due to a faulty check introduced when the Rebellion class was implemented (causing unintended interaction with Coins). Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Clarify some Job Class vs MapID confusion (1/2)Haru25-273/+297
This commit ensures that `sd->status.class` and related variables only contain Job Classes (i.e. the client-compatible values, where High Novice 4001) and are never checked against the bitmask-based MapID values. As a rule of thumb, from now on, when a variable is named `class`, it is intended to contain a Job Class ID and not a MapID. The type of such variable shall be a signed `int16` or `int`. To ensure that related third party code is also verified when this commit is merged, the variable `struct mmo_charstatus::class_ (i.e. `sd->status.class_`) is renamed to `class`. Some issues in related lines are also fixed, including: - A wrong check in the char server would prevent the correct detection of babies in code related to the family exp sharing. - Baby Arch Bishops would not be affected by Eucharistica. - A wrong check would cause the `questinfo()` script command not to display its information for most classes (except 1-1 classes). - Map IDs and Job Classes were mixed up in `itemdb_jobid2mapid()` and `itemdb_jobmask2mapid()` for 1-1 classes (causing currently no harm, since they just happen to coincide). - The Baby Sura class would not cause parties to be marked as containing a monk type character (for SLS Team Up purposes). - Baby Geneticists would bypass the cart check when trying to equip ammunitions. - Baby Mechanics would bypass the Mado Gear check when trying to equip ammunitions. - Transcendent Shadow Chasers would lose the Stalkers' ability to clone transcendent skills. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Clarify the meaning of the MAPID_* constantsHaru2-103/+234
The enum values are now written in a more explicit way, showing how they're composed (upper mask + base job). A future-proof static assertion is added, to make sure the base jobs won't overlap the upper masks. Signed-off-by: Haru <haru@dotalux.com>
2016-12-03Add support for static assertions (on compilers that support them)Haru1-0/+27
This introduces the macro `STATIC_ASSERT(ex, msg)`, that works like its C11 counterpart `_Static_assert(ex, msg)`, on compilers that support it. Support is provided, depending on the compiler: - When in C11 mode, use the native `_Static_assert` - If the compiler advertises having the `c_static_assert` feature, use `_Static_assert` (according to the clang documentation). - If the compiler is GCC >= 4.7 (tested to be compatible), use `_Static_assert` (nonstandard extension, C11 feature available in C99). - If the compiler is MSVC (all the currently supported versions have been tested to be compatible), then use `static_assert` (nonstandard extension, C++ feature) - Otherwise, define it as a no-op macro. Signed-off-by: Haru <haru@dotalux.com>
2016-12-02Fixed a null-pointer dereference in BUILDIN(makeitem2)Haru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
2016-12-02Merge pull request #1405 from Emistry/scriptcommand_makeitem2Haru2-1/+111
Add *makeitem2 script command.
2016-12-02Merge pull request #1521 from Lemongrass3110/fix/areawarp_cellcheckIbrahem Hossam1-1/+4
Fixed areawarp cell check
2016-12-02Merge pull request #1494 from Emistry/party_check_stateIbrahem Hossam1-5/+9
Update party_check_state
2016-12-01Fixed areawarp cell checkLemongrass31101-1/+4
The script command areawarp has been checking the wrong target map for ages. It has been checking the mapindex rather than the mapid and therefore returned a wrong result. Original commit: rathena/rathena@ac2ba09
2016-11-22Merge pull request #1519 from Asheraf/thesignDastgir1-5/+5
Fix wrong command usage at the sign quest
2016-11-22Fix wrong command usage at sign questAsheraf1-5/+5
disabled npc's do not show the effects
2016-11-21Constants Documentation SyncHercules.ws1-1107/+1107
Signed-off-by: HerculesWSAPI <dev@herc.ws>
2016-11-21ItemDB SQL SyncHercules.ws2-1279/+1284
Signed-off-by: HerculesWSAPI <dev@herc.ws>
2016-11-21Merge pull request #1514 from HerculesWS/itemdb-fixesAndrei Karas92-2482/+2604
Itemdb AegisName fixes
2016-11-20Removed support for apostrophes in libconfig key namesHaru3-82/+90
The apostrophe (`'`) is no longer an allowed symbol in libconfig key names. It is no longer necessary since it is no longer allowed in constant names. Signed-off-by: Haru <haru@dotalux.com>
2016-11-20Removed support for apostrophes in constantsHaru1-1/+1
Supporting apostrophes (`'`) inside constants or variables is no longer necessary thanks to the more strict AegisName ruleset we're using now. Signed-off-by: Haru <haru@dotalux.com>
2016-11-20Added validation for the AegisName while parsing the item dbHaru2-2/+26
Signed-off-by: Haru <haru@dotalux.com>
2016-11-20Replaced some unsupported symbols in AegisNames (step 2)Haru78-1084/+1084
This removes the remaining unsupported symbols (despite they being official names) in AegisNames: The apostrophe (`'`) sign is suppressed. The full replacement rules (cumulative with the step 1 commit) are thus: - Any apostrophe is suppressed. - Any non-`[A-Za-z0-9_]` character is replaced with an underscore (`_`). - If the replaced symbol is at a word boundary (beginning or end of the string, or next to another underscore), it is suppressed instead. - If the replacement causes an AegisName conflict, underscores are appended appropriately. Signed-off-by: Haru <haru@dotalux.com>
2016-11-20Replaced some unsupported symbols in AegisNames (step 1)Haru5-21/+21
This removes some unsupported symbols (despite they being official names) in AegisNames. The replacement rules used are: - Any non-`[A-Za-z0-9_']` character is replaced with an underscore (`_`). - If the replaced symbol is at a word boundary (beginning or end of the string, or next to another underscore), it is suppressed instead. - If the replacement causes an AegisName conflict, underscores are appended appropriately. Signed-off-by: Haru <haru@dotalux.com>
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-12-25 18:09:10 +0000