summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2015-01-20Minor fixes and tweaks suggested by cppcheckHaru48-1383/+1328
- Variable scopes reduced - Parenthesized ambiguous expressions - Removed or added NULL checks where (un)necessary - Corrected format strings - Fixed typos potentially leading to bugs Signed-off-by: Haru <haru@dotalux.com>
2015-01-19Merge pull request #443 from 4144/pcextHaruna5-10/+50
Extract exp table validation into separate function.
2015-01-19Update HPM hooks.Andrei Karas3-0/+31
2015-01-19Extract exp table validation into separate function.Andrei Karas2-10/+19
2015-01-18Merge pull request #446 from csnv/quickfixshennetsind1-2/+2
Fixes direction in AOE skills
2015-01-18Fixes direction in AOE skillscsnv1-2/+2
2015-01-18To help pinpoint and manage the issue report in 8402shennetsind1-0/+45
@cddebug command; broken entries will be normalized immediately, to forcefully reset the cooldown write "reset" i.e. @cddebug reset, to use on others the usual #cddebug "target" http://hercules.ws/board/tracker/issue-8402-serious-problem-with-skill-that-cant-be-cast-or-used/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Merge branch 'master' of github.com:HerculesWS/Herculesshennetsind20-443/+741
2015-01-18For bug report 8367shennetsind1-4/+22
While unable to reproduce, I implemented a countermeasure to the issue in question (settick failing, which'd cause blockskill[] not to be filled). Hopefully someone who can reproduce is able to shed some light on the conditions required, allowing for a proper fix to be made. http://hercules.ws/board/tracker/issue-8367-timer-settick-issue/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18HPM Hooks UpdateHercules.ws3-100/+6
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2015-01-18Command line arguments handling overhaulHaru17-343/+735
- login_server, char_server, map_server as well as the tools (mapcache) now have a common command line arguments handling mechanism. - All of them now accept `--help` (`-h`), `--version` (`-v`) and `--load-plugin`. - login_server now accepts `--login-config` and `--lan-config` instead of relying on positional arguments to override those files. The old syntax will no longer work, please update your custom startup scripts. - char_server now accepts `--char-config`, `--inter-config`, `--lan-config` instead of relying on positional arguments. The old syntax will no longer work, please update your custom startup scripts. - mapcache now accepts `--grf-list`, `--map-list`, `--map-cache`, `--rebuild` in place of, respectively, `-grf`, `-list`, `-cache`, `-rebuild`. - A new macro `CMDLINEARG()` is provided, to help defining new command line argument handlers (i.e. in plugins). the `addArg()` call is still required, but its syntax has changed. The `help` argument is now of type `const char *` rather than a function pointer, and it is supposed to contain the message to show in the `--help` screen. Pass `NULL` if no help message is desired. Signed-off-by: Haru <haru@dotalux.com>
2015-01-18For bugreport 8397 (incomplete solution)shennetsind1-1/+12
Certain skills bypass invincibility http://hercules.ws/board/tracker/issue-8397-5-secs-invulnerability-on-positivesupportive-aoe-buff/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Fixed Bug 8441shennetsind1-1/+2
Magnifier item no longer consumes sp http://hercules.ws/board/tracker/issue-8441-item-magnifier-is-consuming-sp/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Follow-up to 83077740c7c996d198617d45a1916cd31ff38e9aHaru1-0/+3
Fixed compile error in instance.c Signed-off-by: Haru <haru@dotalux.com>
2015-01-18Fixed Bug Report 8438shennetsind2-1/+12
Addresses instances crashing when running with the CELL_NOSTACK define enabled. Caused by the define not being readily available to all areas that played with mapcell (now with it being included from map.h this no longer is the case) http://hercules.ws/board/tracker/issue-8438-cell-nostack-and-instances-crash/ Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Follow up 348044f12d5f683c8945e0eac642f2795050fb4eshennetsind1-1/+1
Thanks to Haruna Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Implementing nullpo interface for plugin useshennetsind4-3/+24
As proposed in pull request #361 Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Connection History Redesignshennetsind1-81/+56
Drops ~250kb in memory usage from each server, speeds up lookup/insertion and the cleanup timer will iterate thru the list rather than that ~65k array loop Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Replacing rand leftovers with the mt19937arshennetsind7-14/+14
Signed-off-by: shennetsind <ind@henn.et>
2015-01-18Merge branch 'master' of github.com:HerculesWS/Herculesshennetsind3-3/+4
2015-01-18Fixing 38 issuesshennetsind20-85/+111
Addressing out of bounds read/write, pointless null checks on already deferenced variables, dead code. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-17Merge pull request #444 from 4144/coverityshennetsind3-3/+4
some fixes for different issues
2015-01-18Fix out of bound issue in mapindex.c.Andrei Karas1-1/+1
Found by coverity scan.
2015-01-18Add some fixes to char server.Andrei Karas2-2/+3
Found by coverity scan.
2015-01-1727 Fixesshennetsind13-103/+108
Addressing out of bounds read/write, pointless null checks on already deferenced variables. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-17Another ~10 Fixesshennetsind9-10/+18
Addressing out of bounds read/write. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-17Another ~10 Fixesshennetsind7-33/+40
Addressing out of bounds read/write, resource leaks. Special Thanks to 4144 and Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-17Follow up 84b88781a0c39f7379ed85f74dc03c4e868a171fshennetsind1-0/+1
Thanks to Haruna Signed-off-by: shennetsind <ind@henn.et>
2015-01-1710 Distinct fixesshennetsind11-37/+39
Addressing out of bounds read-write. Special Thanks to 4144, Haruna! Signed-off-by: shennetsind <ind@henn.et>
2015-01-17Stat server submission logic updateshennetsind1-1/+12
to ensure report is submit in full. Signed-off-by: shennetsind <ind@henn.et>
2015-01-17Fixed Bug#8497malufett2-30/+49
-http://hercules.ws/board/tracker/issue-8497-all-mercenaries-miss-hit-for-0/?gopid=24434#entry24434 Signed-off-by: malufett <malufett.eat.my.binaries@gmail.com>
2015-01-15Merge branch 'master' of https://github.com/HerculesWS/HerculesDastgir98-286/+322
2015-01-15Changed Zeny Limit in Bank to 2,147,483,647Dastgir1-1/+1
2015-01-14Merge pull request #442 from emistry/masterDastgir1-1/+1
Fix Incorrect quest progress checking.
2015-01-14Incorrect quest progress checking.Emistry1-1/+1
I think the quest progress check is incorrect. should be these 4 quests I believe. ``` 7423,0,0,0,0,0,0,0,"A rumor about the King 1" 7424,0,0,0,0,0,0,0,"A rumor about the King 2" 7425,0,0,0,0,0,0,0,"A rumor about the King 3" 7426,0,0,0,0,0,0,0,"A rumor about the King 4" ```
2015-01-12Merge pull request #440 from 4144/uninitializedfixesHaruna7-189/+61
Different warnings fixes
2015-01-12Fix some compilation warnings with clang 3.6.Andrei Karas2-2/+2
2015-01-12Enable warning format-security.Andrei Karas2-89/+50
It was blocked in configure.
2015-01-12Update HPM hooks.Andrei Karas1-6/+6
2015-01-12Fix uninitialized warning in skill.c.Andrei Karas2-3/+3
2015-01-12Remove from configure warning block maybe-uninitialized.Andrei Karas2-90/+1
This flag hide some usefull warnings.
2015-01-12Fixed some -Wformat-security warningsHaru6-20/+16
Signed-off-by: Haru <haru@dotalux.com>
2015-01-12Silenced some -Wunused-value warnings in sigemptyset and sigaddset callsHaru1-7/+8
- Fixes warnings when gcc-4.9 is used, with headers (such as Apple's) that define those symbols as `#define sigemptyset(set) (*(set) = 0, 0)` - See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61081 Signed-off-by: Haru <haru@dotalux.com>
2015-01-12Removed unused (re)definition of NBBY from cbasetypes.hHaru1-6/+0
Signed-off-by: Haru <haru@dotalux.com>
2015-01-12HPM Hooks UpdateHercules.ws1-4/+4
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
2015-01-12Merge pull request #441 from 4144/skillfixHaruna2-3/+3
fix skills issue introduced in commit 5cdb3d12c4236e0c3a682e30fed96192d2...
2015-01-12fix skills issue introduced in commit 5cdb3d12c4236e0c3a682e30fed96192d2c58188.Andrei Karas2-3/+3
2015-01-12Blocked compilation of plugins that use unavailable functionsHaru82-53/+223
- Rather than failing at runtime, plugins that try to access non-interfaced, unavailable functions or variables, will now show an error at compile-time. Signed-off-by: Haru <haru@dotalux.com>
2015-01-12Added detailed error message when a plugin fails to loadHaru2-2/+5
- This helps figuring out why a plugin can't be loaded (especially on linux systems.) - Special thanks to Dastgir. Signed-off-by: Haru <haru@dotalux.com>
2015-01-12Fixed an uninitialized variable in skill.cHaru1-1/+1
Signed-off-by: Haru <haru@dotalux.com>
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-12-24 16:34:44 +0000