Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
https://github.com/HerculesWS/Hercules/commit/f95290cc2396d791ad3e9e9f5f73980887a5ef95.
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Fixed their Official names.
|
|
Fix buffer overflow in pet rename.
|
|
|
|
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Closes #1123 as merged
|
|
|
|
|
|
more meaningful variable names in battle_calc_damage()
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Closes #1093 as merged
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
- The functions were returning `(bool)-1` instead of `false` in case of
error, or `(bool)0` instead of `true` in case of success.
Signed-off-by: Haru <haru@dotalux.com>
|
|
INFINITE_DURATION, INVALID_TIMER, SC_NONE, INDEX_NOT_FOUND, depending on context.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The variable should be signed, since it uses the value -1 to indicate
infinite duration (and it's stored as signed in the database).
- Added #define for the special value -1 (INFINITE_DURATION).
- This fixes an issue causing status changes to fail being saved to
database (thanks to Michi for reporting it).
- Related to commit 8dc75721.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Update NPC ID's
|
|
|
|
Signed-off-by: HerculesWSAPI <Hercules@efficiently.awesome>
|
|
Const correctness (and typecast removal) for [RW]{FIFO,BUF}[PBWLQ] functions
|
|
- The npc-side code no longer depends on the client data layout.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The npc-side code no longer depends on the client data layout.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The npc-side code no longer depends on the client data layout.
Signed-off-by: Haru <haru@dotalux.com>
|
|
struct itemlist
- The skill-side code no longer depends on the client packet data layout.
- Some data validation has been added.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- The npc-side code no longer depends on the client packet data layout.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- To be used in various non-clif functions that right now take client
data buffers directly.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- WBUFP now returns a pointer to void, which automatically casts to any
non-const or const pointer.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
- Also increased robustness of the macro
Signed-off-by: Haru <haru@dotalux.com>
|
|
- This is necessary for compatibility with a const RP2PTR/RFIFO2PTR
Signed-off-by: Haru <haru@dotalux.com>
|
|
- While this is arguable, those explicit typecasts are potentially
dangerous/misleading (for example, a const specifier might get
accidentally dropped without even generating a compiler warning, or a
variable type might change during code changes, and any related
warning would get silenced by the explicit typecast).
- As a reminder Hercules is written in C, and not in C++ (and there's
no such thing as "compiling in C++ mode" - they're two different
languages.) As such, it is legal to let the compiler automatically
promote void* from/to any non-const pointer type, as well as const
void* from/to any const pointer type.
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Now it no longer needs to memcpy data to a temporary buffer.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- This is necessary for compatibility with a const RFIFOP.
Signed-off-by: Haru <haru@dotalux.com>
|
|
- aStrndup() behaves similarly to the POSIX function strdup(). It
allocates sufficient memory for a copy of the passed string, copies
it, and returns a pointer to the copy. A maximum number of characters
is copied (and a NUL terminator is always appended after the end).
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
Signed-off-by: Haru <haru@dotalux.com>
|
|
A read FIFO/buffer should be, well, read-only.
Signed-off-by: Haru <haru@dotalux.com>
|