summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-12-23* Fixed server processing the sell list (deleting items and giving zeny) for ↵ai4rei2-62/+107
script-controlled shops (OnSellItem), causing the controller script to fail (bugreport:4656, since r6557). - This also makes the server first check the sell list and only continue, if all items can be processed, thus no longer causing incomplete deals and the need for client disconnection in such case (since r6557). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14617 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-22* NPC shop buy list received from the client is now validated for scripted ↵ai4rei2-2/+9
shops (OnBuyItem), before the control is transfered to the script, as well (bugreport:3680, since r5841, related r8525). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14616 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-22* Resolved random compiler warnings.ai4rei8-14/+16
- Silenced pointer size mismatch gcc warning for variables passed to script_setarray_pc (bugreport:4661, since r14613). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14615 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-22* Fixed sql mapreg loading code specifying output buffer size for ↵ai4rei2-2/+4
SqlStmt_BindColumn without zero-terminator, leading to truncations of variable names and/or their values when using the maximum length (bugreport:1939, since r11245). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14614 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-21* Added script_setarray_pc for setting temporary character array variables ↵ai4rei4-9/+56
outside of script.c without requiring them to use script-interal code (add_str and reference_uid). - Applied script_setarray_pc to assignment of dynamic shop arrays (related r5841). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14613 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-21* Replaced in-place generation of uid of script array elements with ↵ai4rei2-21/+22
reference_uid macro (follow up to r10813). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14612 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-21* Fixed dynamic shop arrays @bought_nameid, @bought_quantity, @sold_nameid ↵ai4rei4-0/+47
and @sold_quantity not getting reset to zero before use, thus providing attached script with wrong/old data, if it did not clear them by itself in previous call (bugreport:1574, since r5841). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14611 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-21* Removed 'strsignal' forward-declaration from 'sig' plugin to prevent ↵ai4rei2-11/+5
random gcc distributions from failing to compile due to mismatched declaration already present in <string.h> (bugreport:4644, topic:262284, follow up to r14591). - Removed WIN32 conditions in non-WIN32 code in 'sig' plugin (follow up to r4380). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14610 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-19* Fixes to the dynamic shop sample script (first part of dynamic shop fixes).ai4rei2-4/+10
- Fixed wrong check in ::OnSellItem, causing not-enough-items condition not getting detected (since r11829). - Fixed an exploit in ::OnSellItem, causing Zeny to be given to the player, even if the items fail to delete (since r5842). - Fixed missing 'close' in ::OnSellItem (since r5842). - Replaced 'end' with 'close' in ::OnBuyItem (since r5842, followup to r11829). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14609 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-19* Replaced maximum script array size literals with a define (constant).ai4rei2-11/+17
- Fixed an off-by-one mistake in copyarray, allowing to copy 1 element more into the target array, than allowed (since r10813). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14608 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-18* Renamed item array in 'struct guild_storage' from 'storage_' to 'items' to ↵ai4rei5-38/+39
match 'struct storage_data' (related r12933). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14607 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-18* Bunch of intif_parse_LoadGuildStorage fixes.ai4rei2-4/+5
- Fixed guild storage not being sorted, when the storage had to be requested first (follow up to r14605). - Fixed missing check, whether or not the character has already an open storage (follow up to r4562). - Fixed missing GM trust check, whether or not the player is allowed to use guild storage (follow up to r3481). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14606 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-18* Fixed character storage no longer being sorted (bugreport:1982, since r12950).ai4rei5-11/+21
- Guild storage is now sorted before being displayed rather than after being saved... - Merged storage_gsortitem into storage_sortitem. - Added option 'client_sort_storage' to control storage sorting. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14605 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-18* Updates to handling of hair color/style and cloth color of characters.ai4rei6-23/+34
- Moved limit shortcut defines from mmo.h to battle.h, as they are only required in files, which include battle.h (since pre-svn 2004/10/15). - Moved hair style/color validation from char-server to map-server. This enables use of non-default limits as specified in battle config, rather than being restricted to hard-coded ones (bugreport:150). - Cleaned up related capping of values in pc_changelook (related r1708). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14604 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-18* Fixed usage of literals for map name length in character list packet ↵ai4rei3-2/+4
(since r14368). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14603 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-18* Made the 'player not attached' script error also report the function it ↵ai4rei2-0/+40
occured in, if available. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14602 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17* Fixed a crash, when script command 'doevent' is called without an attached ↵ai4rei2-1/+9
player (bugreport:3973). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14601 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17* Fixed label definitions silently overwriting built-in script functions ↵ai4rei2-2/+3
(bugreport:2806, follow up to r8027). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14600 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17* Added temporary check to skill_delunitgroup to prevent crashes when ↵ai4rei4-3/+18
'group' is NULL and added some debug messages to track down the source of the crash (bugreport:3504). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14599 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17* Spellchecked script_commands.txt.ai4rei2-174/+177
git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14598 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17* Random script engine clean-ups that have accumulated over time.ai4rei2-8/+30
- Resolved unnecessary script_getnum re-evaluation in a loop in script command 'npcshopdelitem' (since r7120). - Script commands 'menu', 'select' and 'prompt' now warn, when there are more menu options, than the client can handle correctly (TODO from r10316). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14597 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-17* Added missing pet db documentation for fields 'attack_rate', ↵ai4rei3-0/+12
'defence_attack_rate', 'change_target_rate', 'pet_script' and 'loyal_script' based on the one provided by frenzmu06 (bugreport:4636, follow up to r13752). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14596 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-16* Reverted r14525 (introduction of SV_READDB_MAX_FIELDS) because it causes ↵ai4rei2-10/+10
confusion to certain group of users and depends on MAX_LEVEL since r14526. - Made sv_readdb be able to process any amount of columns instead. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14595 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-16* Fixed a mistake in sv_split, causing CR being recognized as EOL character, ↵ai4rei2-1/+3
even when only LF was specified (since r12459). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14594 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-15* Corrected type of second argument of script command 'setbattleflag' from ↵ai4rei2-2/+3
string to number (bugreport:4640, topic:261833, since r5407, related r14577). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14593 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-15* Fixed missing check in cooking, causing cooking kit requirement could be ↵ai4rei2-0/+7
bypassed by sending 0x25b (CZ_REQ_MAKINGITEM) directly (bugreport:4642, since r13628). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14592 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-13* Fixed plugin 'sig' not being compilable on Mac OS X, due to different ↵ai4rei2-0/+6
return value type of 'strsignal' (bugreport:4637). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14591 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-13* Added pet_db2.txt to make it apparent, that pet db has support for customs ↵ai4rei3-2/+60
as well. - Fixed typo 'HungeyDelay' into 'HungryDelay' in pet database description (bugreport:4636, since r13752). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14590 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Fixed homunculus_autoloot not working with skill/item granted drops and ↵ai4rei2-5/+6
loot (bugreport:4452, since r12203). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14589 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Fixed killed monsters were assumed to be killed by homunculus only, if no ↵ai4rei2-5/+13
damage log entries were elligible for exp distribution, even when no homunculus took part in damage dealing (bugreport:4452, since r12203). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14588 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Added enumeration for monster damage log field 'flag'.ai4rei5-12/+22
* Corrected wording of the setting homunculus_autoloot (since r12203). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14587 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Removed disabled backup of script command 'isequipped' (since r1605).ai4rei2-62/+1
git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14586 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Made script engine's DEBUG_DISASM block use script_op2name, rather than ↵ai4rei2-37/+13
hardcoding operator names as per TODO from r13083 (related r9569, follow up to r10667). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14585 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Cleaned up MOTD reading (related r292 and r4552).ai4rei3-34/+76
- Added a warning for common client crash caused by the sequence ' :' in MOTD. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14584 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Fixed impossible condition in soundeffect script command (since ↵ai4rei2-4/+2
athena-dev-2.1.1-mod1046, related r5841). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14583 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Updates to the playBGM functionality (since r14335).ai4rei5-38/+45
- Removed impossible condition in playBGM script command (from soundeffect). - Removed unused code (retrieving of a bl) in playBGMall (from soundeffectall). - Made playBGMall default to 'entire server' when both map name and coordinates are omitted instead of printing an error. - Updated documentation for playBGM and playBGMall to match actual behavior. - Removed unused parameter 'bl' in clif_playBGM. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14582 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Fixed script command setd always assuming value parameter to be a string, ↵ai4rei2-5/+5
which causes hexadecimal and octal numbers not being handled properly (topic:261833, followup to r14577 and r14578). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14581 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Removed `motd` from `ragsrvinfo` table in main.sql, missed in previous ↵ai4rei1-2/+1
commit (follow up to r14579). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14580 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12* Updates to dynamic server information `ragsrvinfo` on SQL.ai4rei5-41/+18
- Fixed exp and drop rates (int) getting truncated (short) when sent to char-server. - Removed `motd` from `ragsrvinfo` as it is not dynamically changed by the server and as such can be read by 3rd party applications directly from conf/motd.txt if required. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14579 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12- Fixed argument declaration of 'setd' (topic:261833, related r14573).brianluau1-1/+1
git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14578 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11* Added support for checking argument data type of built-in script functions ↵ai4rei4-0/+105
(bugreport:1701, topic:261833, related r14573). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14577 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11* Fixed error message in intif_parse_mercenary_received printing wrong ↵ai4rei2-2/+4
struct size (bugreport:4633, since r13116). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14576 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11* Replaced buildin_getpartyname_sub, buildin_getguildname_sub and ↵ai4rei2-77/+57
buildin_getguildmaster_sub, which create only unnecessary overhead, with equivalent inlined code. - Fixed a memory leak in getguildmasterid, when the guild leader was not online (bugreport:2743). - Command getguildmasterid no longer requires the guild leader to be online. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14575 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11* Fixed bAutoSpellOnSkill bonuses not working independently of each other ↵ai4rei2-7/+2
(bugreport:4617, since r13596, related r14536). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14574 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-10* Revised argument declaration of all script commands according to the ↵ai4rei5-65/+70
actual functions' argument usage. - Fixed many script commands with fixed amount of optional parameters to no longer accept any amount of arguments (faulty declaration). - Corrected use of dummy parameter for guildopenstorage in scripts. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14573 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-10* Applied update to charhelp.txt provided by EvilPuncker to match current ↵ai4rei2-23/+25
charcommand behavior (bugreport:4632, follow up to r13403). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14572 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-09* Removed some of the duplicate, storage-related packet code.ai4rei5-136/+23
- Removed clif_guildstoragelist and adjusted clif_storagelist to be able to handle any kind of storage. - Removed clif_guildstorageitemadded in favor of clif_storageitemadded. - This also fixes clif_guildstorageitemadded sending old update packet for clients prior 20090603, although packet 0x1c4 (ZC_ADD_ITEM_TO_STORE2) was added before PACKETVER 5 (before 2003-11-03aSakexe, exact addition date unknown) (since r14286). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14571 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-08* Applied some script command documentation updates and fixes as already ↵ai4rei2-139/+134
done inside the wiki. - Updated description for 'next', 'return', 'attachrid', 'detachrid', 'itemskill', 'openstorage', 'skilleffect', 'donpcevent', 'day', 'night', 'atoi' and 'axtoi' to resolve inaccuracies, missing information or unverified behavior. - Clarified the purpose of the 'jump_zero' and 'getelementofarray' script commands. - Fixed 'changebase' stating, that it only works in item scripts (since r2402). - Fixed 'kickwaitingroomall' stating, that it is not properly linked into the script engine, thus not working (since r13732). - Updated the description for 'cutin' so that it does not give the impression, that the client is able to display multiple illustrations at once, and being less confusing about the maximum size of illustrations. git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14570 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-08* Fixed txt-converter-login was no longer compilable with supplied ↵ai4rei5-0/+21
project/make files, due to missing reference to function exists in utils.c (bugreport:4626, since r14528). git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14569 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07* Applied svn:eol-style to VS2010 project files (follow up to r14562).ai4rei12-1937/+1938
git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@14568 54d463be-8e91-2dee-dedb-b68131a5f0ec