diff options
author | gepard1984 <gepard1984@54d463be-8e91-2dee-dedb-b68131a5f0ec> | 2012-03-13 14:46:28 +0000 |
---|---|---|
committer | gepard1984 <gepard1984@54d463be-8e91-2dee-dedb-b68131a5f0ec> | 2012-03-13 14:46:28 +0000 |
commit | dc5babf8c3fb943a22c440f5afd6957b121926c5 (patch) | |
tree | fcf7000486b4172803ff2929c0b746013d0fb6a9 /src/map/chrif.c | |
parent | d0932858a07e7df3159003c0b920c50e2e6a1b76 (diff) | |
download | hercules-dc5babf8c3fb943a22c440f5afd6957b121926c5.tar.gz hercules-dc5babf8c3fb943a22c440f5afd6957b121926c5.tar.bz2 hercules-dc5babf8c3fb943a22c440f5afd6957b121926c5.tar.xz hercules-dc5babf8c3fb943a22c440f5afd6957b121926c5.zip |
Enhanced `DBMap` implementation to allow storing integer type data in addition to void pointers.
- Added enum for data: `int`, `unsigned int` and `void*`
- Replaced generic `void*` data with `DBData` struct to hold `int`, `unsigned int` or `void*` (member of `DBNode`)
- Added `db_i2data`, `db_ui2data` and `db_ptr2data` functions to cast from `int`/`uint`/`void*` to `DBData` (used in `DBMap::put()`)
- Added `db_data2i`, `db_data2ui` and `db_data2ptr` functions to get `int`/`uint`/`void*` from `DBData`
- Enabled statistics for new functions in `db_stats` struct
- `DBCreateData` functions (used in `DBMap::ensure()`) now return `DBData` instead of `void*`
- `DBApply` functions (used in `DBMap::foreach()` and `DBMap::destroy()`) now take `DBData*` as a parameter instead of `void*`
- `DBMatcher` functions (used in `DBMap::getall()`) now take `DBData` as a parameter instead of `void*`
- `DBReleaser` functions now take `DBData` as parameter instead of `void*`
- Default releasers release data if it is `void*` (`DB_DATA_PTR`) type
- `DBIterator` functions: `first()`, `last()`, `next()` and `prev()` now return `DBData*` instead of `void*`
- `DBIterator::remove()` now returns `int` (1 if node was found and removed, 0 otherwise) instead of `void*` and takes an extra `DBData*` parameter for the data of removed entry
- `DBMap::get()` and `DBMap::ensure()` now return `DBData*` instead of `void*`
- `DBMap::remove()` and `DBMap::put()` now return `int` (1 if node already existed, 0 otherwise) instead of `void*` and take an extra `DBData*` parameter for the data of removed entry
- `DBMap::put()` now takes `DBData` as parameter instead of `void*`
- `DBMap::getall()` now puts data into `DBData**` buffer instead of `void**` buffer
- Updated macros:
- (`i`/`ui`/`str`)`db_get` and (`i`/`ui`/`str`)`db_ensure` were wrapped with `db_data2ptr` to extract data from `DBData*` that is now returned by `DBMap::get()`
- added (`i`/`ui`/`str`)`db_iget` and (`i`/`ui`/`str`)`db_uiget` that get `DBData` from `DBMap` and extract `int`/`unsigned int` from it (with `db_data2i`/`db_data2ui`)
- `db_put`, `idb_put`, `uidb_put` and `strdb_put` data params were wrapped with `db_ptr2data` to match new signature of `DBMap::put()` (`DBData` instead of `void*`)
- added (`i`/`ui`/`str`)`db_iput` and (`i`/`ui`/`str`)`db_uiput` that put `int`/`unsigned int` into `DBMap` (first wrapping it with `DBData`)
- added `NULL` in place of extra parameter for removed data in `db_remove` macros
- `dbi_first`, `dbi_last`, `dbi_next` and `dbi_prev` were wrapped with `db_data2ptr` to extract data from `DBData*` that is now returned by these `DBIterator` functions
- Updated `DBMap` documentation, and fixed a dozen of typos in it.
- Updated rest of rA code to reflect `DBMap` changes (mostly required signature changes of `DBCreateData` and `DBApply` functions).
- Fixed a bug where `DBMap::put()` would return data of a deleted entry.
- Removed some unnecessary pointer casts.
- Increased `showmsg.c` static buffer size to fit entire DBMap stats report.
git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@15682 54d463be-8e91-2dee-dedb-b68131a5f0ec
Diffstat (limited to 'src/map/chrif.c')
-rw-r--r-- | src/map/chrif.c | 25 |
1 files changed, 17 insertions, 8 deletions
diff --git a/src/map/chrif.c b/src/map/chrif.c index 26c7b10cc..c4ff4b662 100644 --- a/src/map/chrif.c +++ b/src/map/chrif.c @@ -463,9 +463,13 @@ int chrif_connectack(int fd) return 0; } -static int chrif_reconnect(DBKey key,void *data,va_list ap) + +/** + * @see DBApply + */ +static int chrif_reconnect(DBKey key, DBData *data, va_list ap) { - struct auth_node *node=(struct auth_node*)data; + struct auth_node *node = db_data2ptr(data); switch (node->state) { case ST_LOGIN: if (node->sd && node->char_dat == NULL) @@ -669,10 +673,13 @@ void chrif_authfail(int fd) } -//This can still happen (client times out while waiting for char to confirm auth data) -int auth_db_cleanup_sub(DBKey key,void *data,va_list ap) +/** + * This can still happen (client times out while waiting for char to confirm auth data) + * @see DBApply + */ +int auth_db_cleanup_sub(DBKey key, DBData *data, va_list ap) { - struct auth_node *node=(struct auth_node*)data; + struct auth_node *node = db_data2ptr(data); const char* states[] = { "Login", "Logout", "Map change" }; if(DIFF_TICK(gettick(),node->node_created)>60000) { switch (node->state) @@ -1558,10 +1565,12 @@ int chrif_removefriend(int char_id, int friend_id) { return 0; } - -int auth_db_final(DBKey k,void *d,va_list ap) +/** + * @see DBApply + */ +int auth_db_final(DBKey key, DBData *data, va_list ap) { - struct auth_node *node=(struct auth_node*)d; + struct auth_node *node = db_data2ptr(data); if (node->char_dat) aFree(node->char_dat); if (node->sd) |