Pincode Update

 - Added blacklist feature
 - Added official message when successfully create a pincode / successfully change a pincode

1 files changed, 205 insertions, 36 deletions

diff --git a/src/char/pincode.c b/src/char/pincode.c
index bca1b4394..8f3df4584 100644
--- a/src/char/pincode.c
+++ b/src/char/pincode.c
@@ -26,6 +26,7 @@
 #include "common/cbasetypes.h"
 #include "common/conf.h"
 #include "common/db.h"
+#include "common/memmgr.h"
 #include "common/mmo.h"
 #include "common/nullpo.h"
 #include "common/random.h"
@@ -39,56 +40,95 @@
 struct pincode_interface pincode_s;
 struct pincode_interface *pincode;
 
-void pincode_handle (int fd, struct char_session_data* sd) {
+void pincode_handle (int fd, struct char_session_data* sd)
+{
 	struct online_char_data* character;
 
 	nullpo_retv(sd);
+
 	character = (struct online_char_data*)idb_get(chr->online_char_db, sd->account_id);
-	if( character && character->pincode_enable > pincode->charselect ){
+
+	if (character && character->pincode_enable > pincode->charselect) {
 		character->pincode_enable = pincode->charselect * 2;
-	}else{
-		pincode->sendstate( fd, sd, PINCODE_OK );
+	} else {
+		pincode->loginstate(fd, sd, PINCODE_LOGIN_OK);
 		return;
 	}
 
-	if( strlen(sd->pincode) == 4 ){
-		if( pincode->changetime && time(NULL) > (sd->pincode_change+pincode->changetime) ){ // User hasn't changed his PIN code for a long time
-			pincode->sendstate( fd, sd, PINCODE_EXPIRED );
+	if (strlen(sd->pincode) == 4) {
+		if (pincode->check_blacklist && pincode->isBlacklisted(sd->pincode)) {
+			// Ask player to change pincode to be able to connect
+			pincode->loginstate(fd, sd, PINCODE_LOGIN_EXPIRED);
+		} else if (pincode->changetime && time(NULL) > (sd->pincode_change + pincode->changetime)) {
+			// User hasn't changed his PIN code for a long time
+			pincode->loginstate(fd, sd, PINCODE_LOGIN_EXPIRED);
 		} else { // Ask user for his PIN code
-			pincode->sendstate( fd, sd, PINCODE_ASK );
+			pincode->loginstate(fd, sd, PINCODE_LOGIN_ASK);
 		}
 	} else // No PIN code has been set yet
-		pincode->sendstate( fd, sd, PINCODE_NOTSET );
+		pincode->loginstate(fd, sd, PINCODE_LOGIN_NOTSET);
 
-	if( character )
+	if (character)
 		character->pincode_enable = -1;
 }
 
-void pincode_check(int fd, struct char_session_data* sd) {
+void pincode_check(int fd, struct char_session_data* sd)
+{
 	char pin[5] = "\0\0\0\0";
 
 	nullpo_retv(sd);
+
 	if (strlen(sd->pincode) != 4)
 		return;
+
 	safestrncpy(pin, RFIFOP(fd, 6), sizeof(pin));
-	pincode->decrypt(sd->pincode_seed, pin);
-	if( pincode->compare( fd, sd, pin ) ){
+
+	if (pincode->check_blacklist && pincode->isBlacklisted(pin)) {
+		pincode->loginstate(fd, sd, PINCODE_LOGIN_RESTRICT_PW);
+		return;
+	}
+
+	if (pincode->compare(fd, sd, pin)) {
 		struct online_char_data* character;
-		if( (character = (struct online_char_data*)idb_get(chr->online_char_db, sd->account_id)) )
+		if ((character = (struct online_char_data*)idb_get(chr->online_char_db, sd->account_id)))
 			character->pincode_enable = pincode->charselect * 2;
-		pincode->sendstate( fd, sd, PINCODE_OK );
+		pincode->loginstate(fd, sd, PINCODE_LOGIN_OK);
+	} else {
+		pincode->loginstate(fd, sd, PINCODE_LOGIN_WRONG);
+	}
+}
+
+/**
+* Check if this pincode is blacklisted or not
+*
+* @param (const char *) pin The pin to be verified
+* @return bool
+*/
+bool pincode_isBlacklisted(const char *pin)
+{
+	int i;
+
+	nullpo_retr(false, pin);
+
+	ARR_FIND(0, VECTOR_LENGTH(pincode->blacklist), i, strcmp(VECTOR_INDEX(pincode->blacklist, i), pin) == 0);
+
+	if (i < VECTOR_LENGTH(pincode->blacklist)) {
+		return true;
 	}
+
+	return false;
 }
 
-int pincode_compare(int fd, struct char_session_data* sd, char* pin) {
+int pincode_compare(int fd, struct char_session_data* sd, char* pin)
+{
 	nullpo_ret(sd);
 	nullpo_ret(pin);
-	if( strcmp( sd->pincode, pin ) == 0 ){
+
+	if (strcmp(sd->pincode, pin) == 0) {
 		sd->pincode_try = 0;
 		return 1;
 	} else {
-		pincode->sendstate( fd, sd, PINCODE_WRONG );
-		if( pincode->maxtry && ++sd->pincode_try >= pincode->maxtry ){
+		if (pincode->maxtry && ++sd->pincode_try >= pincode->maxtry) {
 			pincode->error(sd->account_id);
 			chr->authfail_fd(fd, 0);
 			chr->disconnect_player(sd->account_id);
@@ -97,35 +137,94 @@ int pincode_compare(int fd, struct char_session_data* sd, char* pin) {
 	}
 }
 
-void pincode_change(int fd, struct char_session_data* sd) {
+void pincode_change(int fd, struct char_session_data* sd)
+{
 	char oldpin[5] = "\0\0\0\0", newpin[5] = "\0\0\0\0";
 
 	nullpo_retv(sd);
+
 	if (strlen(sd->pincode) != 4)
 		return;
+
 	safestrncpy(oldpin, RFIFOP(fd,6), sizeof(oldpin));
-	pincode->decrypt(sd->pincode_seed,oldpin);
-	if( !pincode->compare( fd, sd, oldpin ) )
+	pincode->decrypt(sd->pincode_seed, oldpin);
+
+	if (!pincode->compare(fd, sd, oldpin)) {
+		pincode->editstate(fd, sd, PINCODE_EDIT_FAILED);
+		pincode->loginstate(fd, sd, PINCODE_LOGIN_ASK);
 		return;
+	}
 
-	safestrncpy(newpin, RFIFOP(fd,10), sizeof(newpin));
-	pincode->decrypt(sd->pincode_seed,newpin);
-	pincode->update( sd->account_id, newpin );
-	safestrncpy(sd->pincode, newpin, sizeof(sd->pincode));
-	pincode->sendstate( fd, sd, PINCODE_ASK );
+	safestrncpy(newpin, RFIFOP(fd, 10), sizeof(newpin));
+	pincode->decrypt(sd->pincode_seed, newpin);
+
+	if (pincode->check_blacklist && pincode->isBlacklisted(newpin)) {
+		pincode->editstate(fd, sd, PINCODE_EDIT_RESTRICT_PW);
+	} else {
+		pincode->update(sd->account_id, newpin);
+		safestrncpy(sd->pincode, newpin, sizeof(sd->pincode));
+		pincode->editstate(fd, sd, PINCODE_EDIT_SUCCESS);
+	}
+
+	pincode->loginstate(fd, sd, PINCODE_LOGIN_ASK);
 }
 
-void pincode_setnew(int fd, struct char_session_data* sd) {
+void pincode_setnew(int fd, struct char_session_data* sd)
+{
 	char newpin[5] = "\0\0\0\0";
 
 	nullpo_retv(sd);
+
 	if (strlen(sd->pincode) == 4)
 		return;
+
 	safestrncpy(newpin, RFIFOP(fd,6), sizeof(newpin));
-	pincode->decrypt(sd->pincode_seed,newpin);
-	pincode->update( sd->account_id, newpin );
+	pincode->decrypt(sd->pincode_seed, newpin);
+
+	if (pincode->check_blacklist && pincode->isBlacklisted(newpin)) {
+		pincode->makestate(fd, sd, PINCODE_MAKE_RESTRICT_PW);
+		return;
+	}
+
+	pincode->update(sd->account_id, newpin);
 	safestrncpy(sd->pincode, newpin, sizeof(sd->pincode));
-	pincode->sendstate( fd, sd, PINCODE_ASK );
+	pincode->makestate(fd, sd, PINCODE_MAKE_SUCCESS);
+}
+
+/**
+* Send state of making new pincode
+*
+* @param[in] fd
+* @param[in, out] sd Session Data
+* @param[in] state Pincode Edit State
+*/
+void pincode_makestate(int fd, struct char_session_data *sd, enum pincode_make_response state)
+{
+	nullpo_retv(sd);
+
+	WFIFOHEAD(fd, 8);
+	WFIFOW(fd, 0) = 0x8bb;
+	WFIFOW(fd, 2) = state;
+	WFIFOW(fd, 4) = 0;
+	WFIFOSET(fd, 8);
+}
+
+/**
+* Send state of editing pincode
+*
+* @param[in] fd
+* @param[in, out] sd Session Data
+* @param[in] state Pincode Edit State
+*/
+void pincode_editstate(int fd, struct char_session_data *sd, enum pincode_edit_response state)
+{
+	nullpo_retv(sd);
+
+	WFIFOHEAD(fd, 8);
+	WFIFOW(fd, 0) = 0x8bf;
+	WFIFOW(fd, 2) = state;
+	WFIFOW(fd, 4) = sd->pincode_seed = rnd() % 0xFFFF;
+	WFIFOSET(fd, 8);
 }
 
 // 0 = pin is correct
@@ -137,7 +236,8 @@ void pincode_setnew(int fd, struct char_session_data* sd) {
 // 6 = client shows msgstr(1897) Unable to use your KSSN number
 // 7 = char select window shows a button - client sends 0x8c5
 // 8 = pincode was incorrect
-void pincode_sendstate(int fd, struct char_session_data* sd, uint16 state) {
+void pincode_loginstate(int fd, struct char_session_data* sd, enum pincode_login_response state)
+{
 	nullpo_retv(sd);
 	WFIFOHEAD(fd, 12);
 	WFIFOW(fd, 0) = 0x8b9;
@@ -180,7 +280,7 @@ void pincode_decrypt(unsigned int userSeed, char* pin) {
 		}
 	}
 
-	for (i = 0; i < 4; i++ ) {
+	for (i = 0; i < 4; i++) {
 		if (pin[i] < '0' || pin[i] > '9')
 			pin[i] = '0';
 		else
@@ -202,6 +302,8 @@ void pincode_decrypt(unsigned int userSeed, char* pin) {
 bool pincode_config_read(const char *filename, const struct config_t *config, bool imported)
 {
 	const struct config_setting_t *setting = NULL;
+	const struct config_setting_t *temp = NULL;
+
 	nullpo_retr(false, filename);
 	nullpo_retr(false, config);
 
@@ -238,26 +340,93 @@ bool pincode_config_read(const char *filename, const struct config_t *config, bo
 		}
 	}
 
+	if (libconfig->setting_lookup_bool_real(setting, "check_blacklisted", &pincode->check_blacklist) == CONFIG_FALSE) {
+		if (!imported) {
+			ShowWarning("pincode 'check_blaclisted' not found, defaulting to false...\n");
+			pincode->check_blacklist = false;
+		}
+	}
+
+	if (pincode->check_blacklist) {
+		if ((temp = libconfig->setting_get_member(setting, "blacklist")) != NULL) {
+			VECTOR_DECL(char *) duplicate;
+			int i, j, size = libconfig->setting_length(temp);
+			VECTOR_INIT(duplicate);
+			VECTOR_ENSURE(duplicate, size, 1);
+			for (i = 0; i < size; i++) {
+				const char *pin = libconfig->setting_get_string_elem(temp, i);
+
+				if (pin == NULL)
+					continue;
+
+				if (strlen(pin) != 4) {
+					ShowError("Wrong size on element %d of blacklist. Desired size = 4, received = %d\n", i, (int)strlen(pin));
+					continue;
+				}
+
+				ARR_FIND(0, VECTOR_LENGTH(duplicate), j, strcmp(VECTOR_INDEX(duplicate, j), pin) == 0);
+
+				if (j < VECTOR_LENGTH(duplicate)) {
+					ShowWarning("Duplicate pin on pincode blacklist. Item #%d\n", i);
+					continue;
+				}
+
+				VECTOR_ENSURE(pincode->blacklist, 1, 1);
+				VECTOR_PUSH(pincode->blacklist, aStrdup(pin));
+				VECTOR_PUSH(duplicate, aStrdup(pin));
+			}
+			while (VECTOR_LENGTH(duplicate) > 0) {
+				aFree(VECTOR_POP(duplicate));
+			}
+			VECTOR_CLEAR(duplicate);
+		}
+		else if (!imported) {
+			ShowError("Pincode Blacklist Check is enabled but there's no blacklist setting! Disabling check.\n");
+			pincode->check_blacklist = false;
+		}
+	}
+
 	return true;
 }
 
-void pincode_defaults(void) {
+void do_pincode_init(void)
+{
+	VECTOR_INIT(pincode->blacklist);
+}
+
+void do_pincode_final(void)
+{
+	while (VECTOR_LENGTH(pincode->blacklist) > 0) {
+		aFree(VECTOR_POP(pincode->blacklist));
+	}
+	VECTOR_CLEAR(pincode->blacklist);
+}
+
+void pincode_defaults(void)
+{
 	pincode = &pincode_s;
 
-	pincode->enabled = PINCODE_OK;
+	pincode->enabled = 0;
 	pincode->changetime = 0;
 	pincode->maxtry = 3;
 	pincode->charselect = 0;
+	pincode->check_blacklist = false;
 	pincode->multiplier = 0x3498;
 	pincode->baseSeed = 0x881234;
 
+	pincode->init = do_pincode_init;
+	pincode->final = do_pincode_final;
+
 	pincode->handle = pincode_handle;
 	pincode->decrypt = pincode_decrypt;
 	pincode->error = pincode_notifyLoginPinError;
 	pincode->update = pincode_notifyLoginPinUpdate;
-	pincode->sendstate = pincode_sendstate;
+	pincode->makestate = pincode_makestate;
+	pincode->editstate = pincode_editstate;
+	pincode->loginstate = pincode_loginstate;
 	pincode->setnew = pincode_setnew;
 	pincode->change = pincode_change;
+	pincode->isBlacklisted = pincode_isBlacklisted;
 	pincode->compare = pincode_compare;
 	pincode->check = pincode_check;
 	pincode->config_read = pincode_config_read;