diff options
| author | Haru <haru@dotalux.com> | 2016-01-07 16:47:24 +0100 |
|---|---|---|
| committer | Haru <haru@dotalux.com> | 2016-02-24 21:00:26 +0100 |
| commit | 3188738be5ee78651e31c1340fac7fed81bbefb5 (patch) | |
| tree | 97ea854a3c77884e817c02dc069b980ccc42ee74 /src/char/int_auction.c | |
| parent | a79ab6c3d11c7d6fcd1f04400f50b93f72e570e1 (diff) | |
| download | hercules-3188738be5ee78651e31c1340fac7fed81bbefb5.tar.gz hercules-3188738be5ee78651e31c1340fac7fed81bbefb5.tar.bz2 hercules-3188738be5ee78651e31c1340fac7fed81bbefb5.tar.xz hercules-3188738be5ee78651e31c1340fac7fed81bbefb5.zip | |
Removed several unnecessary RFIFOP typecasts
- While this is arguable, those explicit typecasts are potentially
dangerous/misleading (for example, a const specifier might get
accidentally dropped without even generating a compiler warning, or a
variable type might change during code changes, and any related
warning would get silenced by the explicit typecast).
- As a reminder Hercules is written in C, and not in C++ (and there's
no such thing as "compiling in C++ mode" - they're two different
languages.) As such, it is legal to let the compiler automatically
promote void* from/to any non-const pointer type, as well as const
void* from/to any const pointer type.
Signed-off-by: Haru <haru@dotalux.com>
Diffstat (limited to 'src/char/int_auction.c')
| -rw-r--r-- | src/char/int_auction.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/char/int_auction.c b/src/char/int_auction.c index 90dd75962..464a2092b 100644 --- a/src/char/int_auction.c +++ b/src/char/int_auction.c @@ -462,7 +462,7 @@ void mapif_parse_auction_bid(int fd) } auction->buyer_id = char_id; - safestrncpy(auction->buyer_name, (char*)RFIFOP(fd,16), NAME_LENGTH); + safestrncpy(auction->buyer_name, RFIFOP(fd,16), NAME_LENGTH); auction->price = bid; if( bid >= auction->buynow ) |