* Some serious code cleanups

- adjusted @reloadbattleconf to not depend on variable ordering
- changed all battle vars to 'int' (removes pointless duplicit coding)
- added min, max and default columns to battle config data structure
- added properly bounded values for these columns (or at least tried to)
- battle-conf loading will now complain if it finds unknown settings,
  and will reject values that are outside of the allowed range
- added CHATROOM_TITLE_SIZE and CHATROOM_PASS_SIZE 
- partially cleaned up chatroom manipulation code
* Fixed 'Job_Professer' typo in mage jobchange quest

git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@11017 54d463be-8e91-2dee-dedb-b68131a5f0ec

1 files changed, 16 insertions, 20 deletions

diff --git a/conf-tmpl/battle/skill.conf b/conf-tmpl/battle/skill.conf
index 3b4a58d2b..e6827b796 100644
--- a/conf-tmpl/battle/skill.conf
+++ b/conf-tmpl/battle/skill.conf
@@ -17,12 +17,8 @@
 //--------------------------------------------------------------
 // Note 1: Value is a config switch (on/off, yes/no or 1/0)
 // Note 2: Value is in percents (100 means 100%)
-// Note 3: Value is not limited to 60k (see below)
-// Note 4: Value is a bit field. If no description is given,
+// Note 3: Value is a bit field. If no description is given,
 //         assume unit types (1: Pc, 2: Mob, 4: Pet, 8: Homun)
-// Other Information:
-// All values are limited to a number between 0 and 60k
-// (60000, 600%, 60secs, ...), unless otherwise specified.
 //--------------------------------------------------------------
 
 // The rate of time it takes to cast a spell (Note 2, 0 = No casting time)
@@ -47,7 +43,7 @@ min_skill_delay_limit: 100
 // appear to "teleport" afterwards.
 default_skill_delay: 300
 
-//Completely disable skill delay of the following types (Note 4)
+//Completely disable skill delay of the following types (Note 3)
 //NOTE: By default mobs don't have the skill delay as specified in the skill
 //  database, but follow their own 'reuse' skill delay which is specified on
 //  the mob skill db. When set, the delay for all skills become
@@ -68,13 +64,13 @@ skill_add_range: 0
 // If the target moves out of range while casting, do we take the items and SP for the skill anyway? (Note 1)
 skill_out_range_consume: no
 
-// Does the distance between caster and target define if the skill is a ranged skill? (Note 4)
+// Does the distance between caster and target define if the skill is a ranged skill? (Note 3)
 // If set, when the distance between caster and target is greater than 3 the skill is considered long-range, otherwise it's a melee range.
 // If not set, then the range is determined by the skill's range (if it is above 5, the skill is ranged).
 // Default 14 (mobs + pets + homun)
 skillrange_by_distance: 14
 
-// Should the equipped weapon's range override the skill's range defined in the skill_db for most weapon-based skills? (Note 4)
+// Should the equipped weapon's range override the skill's range defined in the skill_db for most weapon-based skills? (Note 3)
 // NOTE: Skills affected by this option are those whose range in the skill_db are negative. Note that unless monster_ai&0x400 is
 // set, the range of all skills is 9 for monsters.
 skillrange_from_weapon: 14
@@ -84,10 +80,10 @@ skillrange_from_weapon: 14
 // no effect while the caster is unable to fight (eg: stunned).
 skill_caster_check: yes
 
-// Should ground placed skills be removed as soon as the caster dies? [Note 4]
+// Should ground placed skills be removed as soon as the caster dies? (Note 3)
 clear_skills_on_death: 0
 
-// Should ground placed skills be removed when the caster changes maps? [Note 4]
+// Should ground placed skills be removed when the caster changes maps? (Note 3)
 clear_skills_on_warp: 15
 
 //Setting this to YES will override the target mode of ground-based skills with the flag 0x01 to "No Enemies"
@@ -103,21 +99,21 @@ skill_min_damage: 6
 // The delay rate of monk's combo (Note 2)
 combo_delay_rate: 100
 
-// Use alternate auto Counter Attack Skill Type? (Note 4)
+// Use alternate auto Counter Attack Skill Type? (Note 3)
 // For those characters on which it is set, 100% Critical,
 // Otherwise it disregard DEF and HIT+20, CRI*2
 auto_counter_type: 15
 
-// Can ground skills be placed on top of each other? (Note 4)
+// Can ground skills be placed on top of each other? (Note 3)
 // By default, skills with UF_NOREITERATION set cannot be stacked on top of 
 // other skills, this setting will override that. (skill_unit_db)
 skill_reiteration: 0
 
-// Can ground skills NOT be placed underneath/near players/monsters? (Note 4)
+// Can ground skills NOT be placed underneath/near players/monsters? (Note 3)
 // If set, only skills with UF_NOFOOTSET set will be affected (skill_unit_db)
 skill_nofootset: 1
 
-// Should traps (hunter traps + quagmire) change their target to "all" inside gvg/pvp grounds? (Note 4)
+// Should traps (hunter traps + quagmire) change their target to "all" inside gvg/pvp grounds? (Note 3)
 // Default on official servers: yes for player-traps
 gvg_traps_target_all: 1
 
@@ -149,7 +145,7 @@ skill_wall_check: yes
 player_cloak_check_type: 1
 monster_cloak_check_type: 4
 
-// Can't place unlimited land skills at the same time (Note 4)
+// Can't place unlimited land skills at the same time (Note 3)
 land_skill_limit: 1
 
 //Determines which kind of skill-failed messages should be sent:
@@ -169,9 +165,9 @@ chat_warpportal: no
 // 3: Both (the addition of both) [default]
 sense_type: 3
 
-// Which finger offensive style can be used?
-// 0 = Aegis style
-// 1 = Athena style
+// Which finger offensive style will be used?
+// 0 = Aegis style (single multi-hit attack)
+// 1 = Athena style (multiple consecutive attacks)
 finger_offensive_type: 0
 
 // Number of hits at a time that undead/fire elemental enemies receive from firewall.
@@ -198,13 +194,13 @@ player_skill_partner_check: yes
 
 // Remove trap type
 // 0 = Aegis system : Returns 1 'Trap' item
-// 1 = Athena system : Allows the returned item and amount to be defined
+// 1 = Athena system : Returns all items used to deploy the trap
 skill_removetrap_type: 0
 
 // Does using bow to do a backstab give a 50% damage penalty? (Note 1)
 backstab_bow_penalty: yes
 
-// Use kRO new steal formula?
+// Use kRO new steal formula? (favors skillv more than dex difference) (Note 1)
 skill_steal_type: yes
 
 // How many times you could try to steal from a mob.