* Some serious code cleanups

- adjusted @reloadbattleconf to not depend on variable ordering
- changed all battle vars to 'int' (removes pointless duplicit coding)
- added min, max and default columns to battle config data structure
- added properly bounded values for these columns (or at least tried to)
- battle-conf loading will now complain if it finds unknown settings,
  and will reject values that are outside of the allowed range
- added CHATROOM_TITLE_SIZE and CHATROOM_PASS_SIZE 
- partially cleaned up chatroom manipulation code
* Fixed 'Job_Professer' typo in mage jobchange quest

git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@11017 54d463be-8e91-2dee-dedb-b68131a5f0ec

1 files changed, 8 insertions, 12 deletions

diff --git a/conf-tmpl/battle/battle.conf b/conf-tmpl/battle/battle.conf
index db04fdd0b..9c0f708fd 100644
--- a/conf-tmpl/battle/battle.conf
+++ b/conf-tmpl/battle/battle.conf
@@ -17,21 +17,17 @@
 //--------------------------------------------------------------
 // Note 1: Value is a config switch (on/off, yes/no or 1/0)
 // Note 2: Value is in percents (100 means 100%)
-// Note 3: Value is not limited to 60k (see below)
-// Note 4: Value is a bit field. If no description is given,
+// Note 3: Value is a bit field. If no description is given,
 //         assume unit types (1: Pc, 2: Mob, 4: Pet, 8: Homun)
-// Other Information:
-// All values are limited to a number between 0 and 60k
-// (60000, 600%, 60secs, ...), unless otherwise specified.
 //--------------------------------------------------------------
 
-// Who should have a baseatk value (makes str affect damage)? (Note 4)
+// Who should have a baseatk value (makes str affect damage)? (Note 3)
 enable_baseatk: 9
 
-// Who can have perfect flee? (Note 4)
+// Who can have perfect flee? (Note 3)
 enable_perfect_flee: 1
 
-// Who can have critical attacks? (Note 4)
+// Who can have critical attacks? (Note 3)
 // (Note that there are some skills that always do critical hit regardless of this)
 enable_critical: 1
 
@@ -83,7 +79,7 @@ max_hitrate: 100
 // 2 = agi_penalty_num is reduced from FLEE as an exact amount
 agi_penalty_type: 1
 
-// When agi penalty is enabled, to whom it should apply to? (Note 4)
+// When agi penalty is enabled, to whom it should apply to? (Note 3)
 // By default, only players get the penalty.
 agi_penalty_target: 1
 
@@ -99,7 +95,7 @@ agi_penalty_num: 10
 // 2 = vit_penalty_num is reduced from FLEE as an exact amount
 vit_penalty_type: 1
 
-// When vit penalty is enabled, to whom it should apply to? (Note 4)
+// When vit penalty is enabled, to whom it should apply to? (Note 3)
 // By default, only players get the penalty.
 vit_penalty_target: 1
 
@@ -132,11 +128,11 @@ agi_penalty_count_lv: 2
 // 4+: None of the above, count will always be 0
 vit_penalty_count_lv: 3
 
-// Change attacker's direction to face opponent on every attack? (Note 4)
+// Change attacker's direction to face opponent on every attack? (Note 3)
 attack_direction_change: 15
 
 // For those who is set, attacks of Neutral element will not get any elemental
-// adjustment (100% versus on all defense-elements) (Note 4)
+// adjustment (100% versus on all defense-elements) (Note 3)
 // NOTE: This is the setting that makes it so non-players can hit for full
 // damage against Ghost-type targets (eg: Ghostring wearing players).
 attack_attr_none: 14