Cleaned up the script engine's get_val() function

- changed the long if-spaghetti into a compact switch statement
- changed its behavior so that it exits if !sd and it requires one
- upon exiting, it will now ensure that meaningful values get returned (the old code would return random memory / crash)
- removed many !sd checks since they are done at the beginning now

git-svn-id: https://rathena.svn.sourceforge.net/svnroot/rathena/trunk@9812 54d463be-8e91-2dee-dedb-b68131a5f0ec

1 files changed, 7 insertions, 0 deletions

diff --git a/Changelog-Trunk.txt b/Changelog-Trunk.txt
index d882cd00f..fb30b9cb0 100644
--- a/Changelog-Trunk.txt
+++ b/Changelog-Trunk.txt
@@ -4,6 +4,13 @@ AS OF SVN REV. 5091, WE ARE NOW USING TRUNK.  ALL UNTESTED BUGFIXES/FEATURES GO
 IF YOU HAVE A WORKING AND TESTED BUGFIX PUT IT INTO STABLE AS WELL AS TRUNK.
 
 2007/02/06
+	* Cleaned up the script engine's get_val() function [ultramage]
+	- changed the long if-spaghetti into a compact switch statement
+	- changed its behavior so that it exits if !sd and it requires one
+	- upon exiting, it will now ensure that meaningful values get returned
+	  (the old code had no qualms about returning random junk from memory
+	   for integer queries, and crashing for string queries)
+	- removed many !sd checks since they are done at the beginning now
 	* Fixed #lvup having the gm level check backwards.
 	* Fixed the stormgust freeze counter going up even if the attack is
 	  blocked/cancelled.