Enable warning format-security.

It was blocked in configure.

2 files changed, 50 insertions, 89 deletions

diff --git a/configure b/configure
index 30bf09d4e..0283c46f9 100755
--- a/configure
+++ b/configure
@@ -1,5 +1,5 @@
 #! /bin/sh
-# From configure.in 94e07ca.
+# From configure.in 35e1da2.
 # Guess values for system-dependent variables and create Makefiles.
 # Generated by GNU Autoconf 2.69.
 #
@@ -5627,81 +5627,42 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
 
 
 
-		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wno-switch" >&5
-$as_echo_n "checking whether $CC supports -Wno-switch... " >&6; }
+		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wformat-security" >&5
+$as_echo_n "checking whether $CC supports -Wformat-security... " >&6; }
 		OLD_CFLAGS="$CFLAGS"
-		CFLAGS="$CFLAGS -Werror -Wno-switch"
+		CFLAGS="$CFLAGS -Werror -Wformat-security"
 		cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int foo;
 _ACEOF
 if ac_fn_c_try_compile "$LINENO"; then :
 
-				# Recent versions of gcc don't fail if -Wno-foo is not recognized
-				# (unless there are also other warnings), so we also check for -Wfoo
-				# which always fails if not supported
-				CFLAGS="$OLD_CFLAGS -Werror -Wswitch"
-				cat confdefs.h - <<_ACEOF >conftest.$ac_ext
-/* end confdefs.h.  */
-int foo;
-_ACEOF
-if ac_fn_c_try_compile "$LINENO"; then :
-
-						{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
+				{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }
-						CFLAGS="$OLD_CFLAGS -Wno-switch"
-						# Optionally, run a test
-						if test "x" != "x"; then
-							{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC can actually use -Wno-switch" >&5
-$as_echo_n "checking whether $CC can actually use -Wno-switch... " >&6; }
-							CFLAGS="$OLD_CFLAGS -Werror -Wswitch"
-							cat confdefs.h - <<_ACEOF >conftest.$ac_ext
-/* end confdefs.h.  */
-
-_ACEOF
-if ac_fn_c_try_compile "$LINENO"; then :
-
-									{ $as_echo "$as_me:${as_lineno-$LINENO}: result: not needed but enabled" >&5
-$as_echo "not needed but enabled" >&6; }
-									CFLAGS="$OLD_CFLAGS"
-
-else
-
-									CFLAGS="$OLD_CFLAGS -Werror -Wno-switch"
-									cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+				CFLAGS="$OLD_CFLAGS -Wformat-security"
+				# Optionally, run a test
+				if test "x" != "x"; then
+					{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC can actually use -Wformat-security" >&5
+$as_echo_n "checking whether $CC can actually use -Wformat-security... " >&6; }
+					CFLAGS="$OLD_CFLAGS -Werror -Wformat-security"
+					cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 
 _ACEOF
 if ac_fn_c_try_compile "$LINENO"; then :
 
-											{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
-$as_echo "yes" >&6; }
-											CFLAGS="$OLD_CFLAGS -Wno-switch"
-
-else
-
-											{ $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
+							{ $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
 $as_echo "no" >&6; }
-											CFLAGS="$OLD_CFLAGS"
-
-
-fi
-rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
-
-
-fi
-rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
-						fi
-
-else
+							CFLAGS="$OLD_CFLAGS"
 
-						{ $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
-$as_echo "no" >&6; }
-						CFLAGS="$OLD_CFLAGS"
 
+							{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
+$as_echo "yes" >&6; }
+							CFLAGS="$OLD_CFLAGS -Wformat-security"
 
 fi
 rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+				fi
 
 else
 
@@ -5715,10 +5676,10 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
 
 
 
-		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wno-missing-field-initializers" >&5
-$as_echo_n "checking whether $CC supports -Wno-missing-field-initializers... " >&6; }
+		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wno-format-nonliteral" >&5
+$as_echo_n "checking whether $CC supports -Wno-format-nonliteral... " >&6; }
 		OLD_CFLAGS="$CFLAGS"
-		CFLAGS="$CFLAGS -Werror -Wno-missing-field-initializers"
+		CFLAGS="$CFLAGS -Werror -Wno-format-nonliteral"
 		cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int foo;
@@ -5728,7 +5689,7 @@ if ac_fn_c_try_compile "$LINENO"; then :
 				# Recent versions of gcc don't fail if -Wno-foo is not recognized
 				# (unless there are also other warnings), so we also check for -Wfoo
 				# which always fails if not supported
-				CFLAGS="$OLD_CFLAGS -Werror -Wmissing-field-initializers"
+				CFLAGS="$OLD_CFLAGS -Werror -Wformat-nonliteral"
 				cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int foo;
@@ -5737,12 +5698,12 @@ if ac_fn_c_try_compile "$LINENO"; then :
 
 						{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }
-						CFLAGS="$OLD_CFLAGS -Wno-missing-field-initializers"
+						CFLAGS="$OLD_CFLAGS -Wno-format-nonliteral"
 						# Optionally, run a test
 						if test "x" != "x"; then
-							{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC can actually use -Wno-missing-field-initializers" >&5
-$as_echo_n "checking whether $CC can actually use -Wno-missing-field-initializers... " >&6; }
-							CFLAGS="$OLD_CFLAGS -Werror -Wmissing-field-initializers"
+							{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC can actually use -Wno-format-nonliteral" >&5
+$as_echo_n "checking whether $CC can actually use -Wno-format-nonliteral... " >&6; }
+							CFLAGS="$OLD_CFLAGS -Werror -Wformat-nonliteral"
 							cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 
@@ -5755,7 +5716,7 @@ $as_echo "not needed but enabled" >&6; }
 
 else
 
-									CFLAGS="$OLD_CFLAGS -Werror -Wno-missing-field-initializers"
+									CFLAGS="$OLD_CFLAGS -Werror -Wno-format-nonliteral"
 									cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 
@@ -5764,7 +5725,7 @@ if ac_fn_c_try_compile "$LINENO"; then :
 
 											{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }
-											CFLAGS="$OLD_CFLAGS -Wno-missing-field-initializers"
+											CFLAGS="$OLD_CFLAGS -Wno-format-nonliteral"
 
 else
 
@@ -5803,10 +5764,10 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
 
 
 
-		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wno-format-security" >&5
-$as_echo_n "checking whether $CC supports -Wno-format-security... " >&6; }
+		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wno-switch" >&5
+$as_echo_n "checking whether $CC supports -Wno-switch... " >&6; }
 		OLD_CFLAGS="$CFLAGS"
-		CFLAGS="$CFLAGS -Werror -Wno-format-security"
+		CFLAGS="$CFLAGS -Werror -Wno-switch"
 		cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int foo;
@@ -5816,7 +5777,7 @@ if ac_fn_c_try_compile "$LINENO"; then :
 				# Recent versions of gcc don't fail if -Wno-foo is not recognized
 				# (unless there are also other warnings), so we also check for -Wfoo
 				# which always fails if not supported
-				CFLAGS="$OLD_CFLAGS -Werror -Wformat-security"
+				CFLAGS="$OLD_CFLAGS -Werror -Wswitch"
 				cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int foo;
@@ -5825,12 +5786,12 @@ if ac_fn_c_try_compile "$LINENO"; then :
 
 						{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }
-						CFLAGS="$OLD_CFLAGS -Wno-format-security"
+						CFLAGS="$OLD_CFLAGS -Wno-switch"
 						# Optionally, run a test
 						if test "x" != "x"; then
-							{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC can actually use -Wno-format-security" >&5
-$as_echo_n "checking whether $CC can actually use -Wno-format-security... " >&6; }
-							CFLAGS="$OLD_CFLAGS -Werror -Wformat-security"
+							{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC can actually use -Wno-switch" >&5
+$as_echo_n "checking whether $CC can actually use -Wno-switch... " >&6; }
+							CFLAGS="$OLD_CFLAGS -Werror -Wswitch"
 							cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 
@@ -5843,7 +5804,7 @@ $as_echo "not needed but enabled" >&6; }
 
 else
 
-									CFLAGS="$OLD_CFLAGS -Werror -Wno-format-security"
+									CFLAGS="$OLD_CFLAGS -Werror -Wno-switch"
 									cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 
@@ -5852,7 +5813,7 @@ if ac_fn_c_try_compile "$LINENO"; then :
 
 											{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }
-											CFLAGS="$OLD_CFLAGS -Wno-format-security"
+											CFLAGS="$OLD_CFLAGS -Wno-switch"
 
 else
 
@@ -5891,10 +5852,10 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
 
 
 
-		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wno-format-nonliteral" >&5
-$as_echo_n "checking whether $CC supports -Wno-format-nonliteral... " >&6; }
+		{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wno-missing-field-initializers" >&5
+$as_echo_n "checking whether $CC supports -Wno-missing-field-initializers... " >&6; }
 		OLD_CFLAGS="$CFLAGS"
-		CFLAGS="$CFLAGS -Werror -Wno-format-nonliteral"
+		CFLAGS="$CFLAGS -Werror -Wno-missing-field-initializers"
 		cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int foo;
@@ -5904,7 +5865,7 @@ if ac_fn_c_try_compile "$LINENO"; then :
 				# Recent versions of gcc don't fail if -Wno-foo is not recognized
 				# (unless there are also other warnings), so we also check for -Wfoo
 				# which always fails if not supported
-				CFLAGS="$OLD_CFLAGS -Werror -Wformat-nonliteral"
+				CFLAGS="$OLD_CFLAGS -Werror -Wmissing-field-initializers"
 				cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 int foo;
@@ -5913,12 +5874,12 @@ if ac_fn_c_try_compile "$LINENO"; then :
 
 						{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }
-						CFLAGS="$OLD_CFLAGS -Wno-format-nonliteral"
+						CFLAGS="$OLD_CFLAGS -Wno-missing-field-initializers"
 						# Optionally, run a test
 						if test "x" != "x"; then
-							{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC can actually use -Wno-format-nonliteral" >&5
-$as_echo_n "checking whether $CC can actually use -Wno-format-nonliteral... " >&6; }
-							CFLAGS="$OLD_CFLAGS -Werror -Wformat-nonliteral"
+							{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $CC can actually use -Wno-missing-field-initializers" >&5
+$as_echo_n "checking whether $CC can actually use -Wno-missing-field-initializers... " >&6; }
+							CFLAGS="$OLD_CFLAGS -Werror -Wmissing-field-initializers"
 							cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 
@@ -5931,7 +5892,7 @@ $as_echo "not needed but enabled" >&6; }
 
 else
 
-									CFLAGS="$OLD_CFLAGS -Werror -Wno-format-nonliteral"
+									CFLAGS="$OLD_CFLAGS -Werror -Wno-missing-field-initializers"
 									cat confdefs.h - <<_ACEOF >conftest.$ac_ext
 /* end confdefs.h.  */
 
@@ -5940,7 +5901,7 @@ if ac_fn_c_try_compile "$LINENO"; then :
 
 											{ $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }
-											CFLAGS="$OLD_CFLAGS -Wno-format-nonliteral"
+											CFLAGS="$OLD_CFLAGS -Wno-missing-field-initializers"
 
 else
 
diff --git a/configure.in b/configure.in
index 685e256cb..1f2001981 100644
--- a/configure.in
+++ b/configure.in
@@ -756,10 +756,10 @@ AC_CHECK_COMPILER_WFLAG(enum-conversion)
 AC_CHECK_COMPILER_WFLAG(shorten-64-to-32)
 AC_CHECK_COMPILER_WFLAG(constant-conversion)
 AC_CHECK_COMPILER_WFLAG(bool-conversion)
+AC_CHECK_COMPILER_WFLAG(format-security)
+AC_CHECK_COMPILER_WNOFLAG(format-nonliteral)
 AC_CHECK_COMPILER_WNOFLAG(switch)
 AC_CHECK_COMPILER_WNOFLAG(missing-field-initializers)
-AC_CHECK_COMPILER_WNOFLAG(format-security)
-AC_CHECK_COMPILER_WNOFLAG(format-nonliteral)
 
 # Certain versions of gcc make -Wshadow completely useless by making it flood
 # you with unnecessary warnings <https://lkml.org/lkml/2006/11/28/239>