servergreps: fix false positives with preffered packet versions.

Add simple checks for hidden/shadow packets in hercules.

57 files changed, 71 insertions, 15 deletions

diff --git a/servergreps/hercules/00000000/herculesissues.txt b/servergreps/hercules/00000000/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/00000000/herculesissues.txt
diff --git a/servergreps/hercules/00000007/herculesissues.txt b/servergreps/hercules/00000007/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/00000007/herculesissues.txt
diff --git a/servergreps/hercules/20100105/clientbadpackets.txt b/servergreps/hercules/20100105/clientbadpackets.txt
index dd829b0..81a35db 100644
--- a/servergreps/hercules/20100105/clientbadpackets.txt
+++ b/servergreps/hercules/20100105/clientbadpackets.txt
@@ -1,5 +1,4 @@
 0113 CMSG_ITEM_PICKUP                  client: clif->pTakeItem                     server: clif->pUseSkillToPos                Change id to 00f5
-0190 CMSG_SKILL_USE_POSITION_MORE      client: clif->pUseSkillToPosMoreInfo        server: clif->pActionRequest                Change id to 007e
 0085 CMSG_PLAYER_CHANGE_DEST           hidden by clif->pChangeDir
 0094 CMSG_NAME_REQUEST                 hidden by clif->pMoveToKafra
 0089 CMSG_PLAYER_CHANGE_ACT            hidden by clif->pTickSend
diff --git a/servergreps/hercules/20100105/herculesissues.txt b/servergreps/hercules/20100105/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20100105/herculesissues.txt
diff --git a/servergreps/hercules/20100303/clientbadpackets.txt b/servergreps/hercules/20100303/clientbadpackets.txt
index dd829b0..81a35db 100644
--- a/servergreps/hercules/20100303/clientbadpackets.txt
+++ b/servergreps/hercules/20100303/clientbadpackets.txt
@@ -1,5 +1,4 @@
 0113 CMSG_ITEM_PICKUP                  client: clif->pTakeItem                     server: clif->pUseSkillToPos                Change id to 00f5
-0190 CMSG_SKILL_USE_POSITION_MORE      client: clif->pUseSkillToPosMoreInfo        server: clif->pActionRequest                Change id to 007e
 0085 CMSG_PLAYER_CHANGE_DEST           hidden by clif->pChangeDir
 0094 CMSG_NAME_REQUEST                 hidden by clif->pMoveToKafra
 0089 CMSG_PLAYER_CHANGE_ACT            hidden by clif->pTickSend
diff --git a/servergreps/hercules/20100303/herculesissues.txt b/servergreps/hercules/20100303/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20100303/herculesissues.txt
diff --git a/servergreps/hercules/20100420/clientbadpackets.txt b/servergreps/hercules/20100420/clientbadpackets.txt
index dd829b0..81a35db 100644
--- a/servergreps/hercules/20100420/clientbadpackets.txt
+++ b/servergreps/hercules/20100420/clientbadpackets.txt
@@ -1,5 +1,4 @@
 0113 CMSG_ITEM_PICKUP                  client: clif->pTakeItem                     server: clif->pUseSkillToPos                Change id to 00f5
-0190 CMSG_SKILL_USE_POSITION_MORE      client: clif->pUseSkillToPosMoreInfo        server: clif->pActionRequest                Change id to 007e
 0085 CMSG_PLAYER_CHANGE_DEST           hidden by clif->pChangeDir
 0094 CMSG_NAME_REQUEST                 hidden by clif->pMoveToKafra
 0089 CMSG_PLAYER_CHANGE_ACT            hidden by clif->pTickSend
diff --git a/servergreps/hercules/20100420/herculesissues.txt b/servergreps/hercules/20100420/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20100420/herculesissues.txt
diff --git a/servergreps/hercules/20100608/clientbadpackets.txt b/servergreps/hercules/20100608/clientbadpackets.txt
index dd829b0..81a35db 100644
--- a/servergreps/hercules/20100608/clientbadpackets.txt
+++ b/servergreps/hercules/20100608/clientbadpackets.txt
@@ -1,5 +1,4 @@
 0113 CMSG_ITEM_PICKUP                  client: clif->pTakeItem                     server: clif->pUseSkillToPos                Change id to 00f5
-0190 CMSG_SKILL_USE_POSITION_MORE      client: clif->pUseSkillToPosMoreInfo        server: clif->pActionRequest                Change id to 007e
 0085 CMSG_PLAYER_CHANGE_DEST           hidden by clif->pChangeDir
 0094 CMSG_NAME_REQUEST                 hidden by clif->pMoveToKafra
 0089 CMSG_PLAYER_CHANGE_ACT            hidden by clif->pTickSend
diff --git a/servergreps/hercules/20100608/herculesissues.txt b/servergreps/hercules/20100608/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20100608/herculesissues.txt
diff --git a/servergreps/hercules/20100803/clientbadpackets.txt b/servergreps/hercules/20100803/clientbadpackets.txt
index dd829b0..81a35db 100644
--- a/servergreps/hercules/20100803/clientbadpackets.txt
+++ b/servergreps/hercules/20100803/clientbadpackets.txt
@@ -1,5 +1,4 @@
 0113 CMSG_ITEM_PICKUP                  client: clif->pTakeItem                     server: clif->pUseSkillToPos                Change id to 00f5
-0190 CMSG_SKILL_USE_POSITION_MORE      client: clif->pUseSkillToPosMoreInfo        server: clif->pActionRequest                Change id to 007e
 0085 CMSG_PLAYER_CHANGE_DEST           hidden by clif->pChangeDir
 0094 CMSG_NAME_REQUEST                 hidden by clif->pMoveToKafra
 0089 CMSG_PLAYER_CHANGE_ACT            hidden by clif->pTickSend
diff --git a/servergreps/hercules/20100803/herculesissues.txt b/servergreps/hercules/20100803/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20100803/herculesissues.txt
diff --git a/servergreps/hercules/20101124/clientbadpackets.txt b/servergreps/hercules/20101124/clientbadpackets.txt
index 70de3fe..d8090ed 100644
--- a/servergreps/hercules/20101124/clientbadpackets.txt
+++ b/servergreps/hercules/20101124/clientbadpackets.txt
@@ -1,3 +1,2 @@
-0113 CMSG_ITEM_PICKUP                  client: clif->pTakeItem                     server: clif->pUseSkillToPos                Change id to 0362
 0089 CMSG_PLAYER_CHANGE_ACT            hidden by clif->pTickSend
 0113 CMSG_SKILL_USE_BEING              hidden by clif->pTakeItem
diff --git a/servergreps/hercules/20101124/herculesissues.txt b/servergreps/hercules/20101124/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20101124/herculesissues.txt
diff --git a/servergreps/hercules/20110718/clientbadpackets.txt b/servergreps/hercules/20110718/clientbadpackets.txt
index 70de3fe..d8090ed 100644
--- a/servergreps/hercules/20110718/clientbadpackets.txt
+++ b/servergreps/hercules/20110718/clientbadpackets.txt
@@ -1,3 +1,2 @@
-0113 CMSG_ITEM_PICKUP                  client: clif->pTakeItem                     server: clif->pUseSkillToPos                Change id to 0362
 0089 CMSG_PLAYER_CHANGE_ACT            hidden by clif->pTickSend
 0113 CMSG_SKILL_USE_BEING              hidden by clif->pTakeItem
diff --git a/servergreps/hercules/20110718/herculesissues.txt b/servergreps/hercules/20110718/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20110718/herculesissues.txt
diff --git a/servergreps/hercules/20111005/clientbadpackets.txt b/servergreps/hercules/20111005/clientbadpackets.txt
index 9d8c608..6dbf4ff 100644
--- a/servergreps/hercules/20111005/clientbadpackets.txt
+++ b/servergreps/hercules/20111005/clientbadpackets.txt
@@ -1,4 +1,3 @@
-0113 CMSG_ITEM_PICKUP                  client: clif->pTakeItem                     server: clif->pUseSkillToPos                Change id to 0815
 0815 CMSG_BUYINGSTORE_CLOSE            hidden by clif->pTakeItem
 0817 CMSG_BUYINGSTORE_OPEN             hidden by clif->pTickSend
 0089 CMSG_PLAYER_CHANGE_ACT            hidden by clif->pTickSend
diff --git a/servergreps/hercules/20111005/herculesissues.txt b/servergreps/hercules/20111005/herculesissues.txt
new file mode 100644
index 0000000..3413728
--- /dev/null
+++ b/servergreps/hercules/20111005/herculesissues.txt
@@ -0,0 +1,3 @@
+Server code error: function clif->pReqCloseBuyingStore hidden in server code
+Server code error: function clif->pSearchStoreInfoNextPage hidden in server code
+Server code error: function clif->pReqClickBuyingStore hidden in server code
diff --git a/servergreps/hercules/20111102/herculesissues.txt b/servergreps/hercules/20111102/herculesissues.txt
new file mode 100644
index 0000000..e6b9d24
--- /dev/null
+++ b/servergreps/hercules/20111102/herculesissues.txt
@@ -0,0 +1 @@
+Server code error: function clif->pReqOpenBuyingStore hidden in server code
diff --git a/servergreps/hercules/20120307/herculesissues.txt b/servergreps/hercules/20120307/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20120307/herculesissues.txt
diff --git a/servergreps/hercules/20120410/herculesissues.txt b/servergreps/hercules/20120410/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20120410/herculesissues.txt
diff --git a/servergreps/hercules/20120418/herculesissues.txt b/servergreps/hercules/20120418/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20120418/herculesissues.txt
diff --git a/servergreps/hercules/20120604/herculesissues.txt b/servergreps/hercules/20120604/herculesissues.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/20120604/herculesissues.txt
diff --git a/servergreps/hercules/20120702/herculesissues.txt b/servergreps/hercules/20120702/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20120702/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20120710/herculesissues.txt b/servergreps/hercules/20120710/herculesissues.txt
new file mode 100644
index 0000000..135155c
--- /dev/null
+++ b/servergreps/hercules/20120710/herculesissues.txt
@@ -0,0 +1,2 @@
+Server code warning: function clif->pSolveCharName hidden in server code but can be used older packets definition 00a2,0884,0368
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20120716/herculesissues.txt b/servergreps/hercules/20120716/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20120716/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130320/herculesissues.txt b/servergreps/hercules/20130320/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130320/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130515/herculesissues.txt b/servergreps/hercules/20130515/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130515/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130522/herculesissues.txt b/servergreps/hercules/20130522/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130522/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130529/herculesissues.txt b/servergreps/hercules/20130529/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130529/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130605/herculesissues.txt b/servergreps/hercules/20130605/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130605/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130612/herculesissues.txt b/servergreps/hercules/20130612/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130612/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130618/herculesissues.txt b/servergreps/hercules/20130618/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130618/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130626/herculesissues.txt b/servergreps/hercules/20130626/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130626/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130703/herculesissues.txt b/servergreps/hercules/20130703/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130703/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130724/herculesissues.txt b/servergreps/hercules/20130724/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130724/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130807/herculesissues.txt b/servergreps/hercules/20130807/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130807/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20130814/herculesissues.txt b/servergreps/hercules/20130814/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20130814/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20131218/herculesissues.txt b/servergreps/hercules/20131218/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20131218/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20131223/herculesissues.txt b/servergreps/hercules/20131223/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20131223/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20131230/herculesissues.txt b/servergreps/hercules/20131230/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20131230/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20140000/herculesissues.txt b/servergreps/hercules/20140000/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20140000/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20140402/herculesissues.txt b/servergreps/hercules/20140402/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20140402/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20141016/herculesissues.txt b/servergreps/hercules/20141016/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20141016/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20141022/herculesissues.txt b/servergreps/hercules/20141022/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20141022/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20150000/herculesissues.txt b/servergreps/hercules/20150000/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20150000/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20150226/herculesissues.txt b/servergreps/hercules/20150226/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20150226/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20150513/herculesissues.txt b/servergreps/hercules/20150513/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20150513/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20150805/herculesissues.txt b/servergreps/hercules/20150805/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20150805/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20150916/herculesissues.txt b/servergreps/hercules/20150916/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20150916/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20151001/herculesissues.txt b/servergreps/hercules/20151001/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20151001/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20151029/herculesissues.txt b/servergreps/hercules/20151029/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20151029/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20151104/herculesissues.txt b/servergreps/hercules/20151104/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20151104/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20151216/herculesissues.txt b/servergreps/hercules/20151216/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20151216/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/20160316/herculesissues.txt b/servergreps/hercules/20160316/herculesissues.txt
new file mode 100644
index 0000000..a2d6ac9
--- /dev/null
+++ b/servergreps/hercules/20160316/herculesissues.txt
@@ -0,0 +1 @@
+Server code warning: function clif->pPartyRecruitRegisterReq hidden in server code but can be used older packets definition 08e5
diff --git a/servergreps/hercules/packets.py b/servergreps/hercules/packets.py
index 7ec8752..d5944fe 100755
--- a/servergreps/hercules/packets.py
+++ b/servergreps/hercules/packets.py
@@ -349,12 +349,17 @@ def printPackets(packetDir):
                 packet2 = clientPackets[packet]
                 if packet1[2] in serverFunctionToId:
                     data = serverFunctionToId[packet1[2]]
-                    if packet1[2] != packet2[1]:
-                        rev.append("{0:4} {1:33} client: {2:35} server: {3:35} Change id to {4}".format(packet,
-                            packet1[0],
-                            packet1[2],
-                            packet2[1],
-                            data))
+                    data2 = serverFunctionToId[packet2[1]]
+                    if data2 == packet:
+                        if packet1[2] != packet2[1]:
+                            rev.append("{0:4} {1:33} client: {2:35} server: {3:35} Change id to {4}".format(packet,
+                                packet1[0],
+                                packet1[2],
+                                packet2[1],
+                                data))
+                    else:
+                        # here hidden or previous packet
+                        pass
                 else:
                     data = "unknown"
                     if packet1[2] != packet2[1]:
@@ -399,12 +404,34 @@ def printPackets(packetDir):
                                 data,
                                 packet1[0],
                                 packet1[2]))
-
             rev.sort()
             for data in rev:
                 w.write(data)
                 w.write("\n")
 
+    with open(packetDir + "/herculesissues.txt", "w") as w:
+            for name in serverFunctionToId:
+                packet = serverFunctionToId[name]
+                if name != clientPackets[packet][1]:
+                    found = False
+                    oldId = ""
+                    for packet in clientPackets:
+                        if name == clientPackets[packet][1]:
+                            found = True
+                            if oldId == "":
+                                oldId = str(packet)
+                            else:
+                                oldId = oldId + "," + str(packet)
+
+                    if found == False:
+                        w.write("Server code error: function {0} hidden in server code\n".format(
+                            name))
+                    else:
+                        w.write("Server code warning: function {0} hidden in server code but can be used older packets definition {1}\n".format(
+                            name,
+                            oldId))
+
+
 def showHelp():
     print("Usage: packets.py version");
     exit(1)
diff --git a/servergreps/hercules/qqq b/servergreps/hercules/qqq
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/servergreps/hercules/qqq