General code cleanups

* Use default member initializers
* Use range-based loops
* Don't use 'else' after 'return'
* Removed some unused includes
* Construct empty strings with std::string() instead of ""
* Clear strings with .clear() instead of assigning ""
* Check whether strings are empty with .empty() instead of comparing to ""
* Removed redundant initializations

1 files changed, 4 insertions, 4 deletions

diff --git a/src/utils/stringutils.cpp b/src/utils/stringutils.cpp
index 57138005..32fc3b0c 100644
--- a/src/utils/stringutils.cpp
+++ b/src/utils/stringutils.cpp
@@ -187,8 +187,8 @@ bool getBoolFromString(const std::string &text, bool def)
         return true;
     if (a == "false" || a == "0" || a == "off" || a == "no" || a == "n")
         return false;
-    else
-        return def;
+
+    return def;
 }
 
 std::string autocomplete(const std::vector<std::string> &candidates,
@@ -196,7 +196,7 @@ std::string autocomplete(const std::vector<std::string> &candidates,
 {
     auto i = candidates.begin();
     toLower(base);
-    std::string newName("");
+    std::string newName;
 
     while (i != candidates.end())
     {
@@ -208,7 +208,7 @@ std::string autocomplete(const std::vector<std::string> &candidates,
             std::string::size_type pos = name.find(base, 0);
             if (pos == 0)
             {
-                if (newName != "")
+                if (!newName.empty())
                 {
                     toLower(newName);
                     newName = findSameSubstring(name, newName);