diff options
author | Yohann Ferreira <yohann_dot_ferreira_at_orange_dot_efer> | 2010-07-29 20:20:51 +0200 |
---|---|---|
committer | Yohann Ferreira <yohann_dot_ferreira_at_orange_dot_efer> | 2010-07-29 20:20:51 +0200 |
commit | ae898aa1a5175b2b08f7248e4cd89bf61bc8e4be (patch) | |
tree | 041646a78229772ae7bb55222659fc4826325c43 /src/sprite.h | |
parent | 2b1c0dcf269d617de1f6c203df547166661f089e (diff) | |
download | mana-ae898aa1a5175b2b08f7248e4cd89bf61bc8e4be.tar.gz mana-ae898aa1a5175b2b08f7248e4cd89bf61bc8e4be.tar.bz2 mana-ae898aa1a5175b2b08f7248e4cd89bf61bc8e4be.tar.xz mana-ae898aa1a5175b2b08f7248e4cd89bf61bc8e4be.zip |
Changed the items loading to handle a new 'attack-action' parameter.
The old behaviour was to load the weapon-type value and do many
unnecessary checks and transformation on it:
The weapon-type was transformed using hard-coded values into
an integer enum value.
The exact same thing was done on the opposite side in the animation
files before comparing the two.
As both data were string values, I simplified all of it by using
the value taken in items.xml to call the corresponding action.
This now also permit to set up new attack animation in items.xml
and in the playerset.xml without having the need
to modify the client code.
Last but not least, the weapon-type value was used by both the skills
and the actions and avoided the possibility to set up a definite action
for a weapon-type.
Note: The weapon-type parameter will become deprecated for the server
in favor of a 'skill' parameter to reflect more it's actual use.
This patch is the first step to fix Manasource issue: #157.
Diffstat (limited to 'src/sprite.h')
-rw-r--r-- | src/sprite.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/sprite.h b/src/sprite.h index cce41f1d..38db8b41 100644 --- a/src/sprite.h +++ b/src/sprite.h @@ -43,7 +43,7 @@ class Sprite * * @returns true if the sprite changed, false otherwise */ - virtual bool play(SpriteAction action) = 0; + virtual bool play(std::string action) = 0; /** * Inform the animation of the passed time so that it can output the |