Removed some 'const' keywords from value returns

It makes no sense to mark a return value as const when it is returned by
value.  This only makes sense if the return value is passed by reference, in
order to prevent the receiver from modifying the value.

Also made some other small adjustments. A std::string does not need to be
initialized to "" explicitly and getSafeUtf8String could take its parameter by
reference.

Reviewed-by: Yohann Ferreira

1 files changed, 1 insertions, 1 deletions

diff --git a/src/resources/iteminfo.cpp b/src/resources/iteminfo.cpp
index 22be274a..3583bb27 100644
--- a/src/resources/iteminfo.cpp
+++ b/src/resources/iteminfo.cpp
@@ -33,7 +33,7 @@ const std::string &ItemInfo::getSprite(Gender gender) const
     }
     else
     {
-        static const std::string empty = "";
+        static const std::string empty;
         std::map<int, std::string>::const_iterator i =
             mAnimationFiles.find(gender);