diff options
| author | Thorbjørn Lindeijer <bjorn@lindeijer.nl> | 2024-03-24 19:17:41 +0100 |
|---|---|---|
| committer | Thorbjørn Lindeijer <bjorn@lindeijer.nl> | 2024-04-02 20:57:16 +0200 |
| commit | 59919635523d41f3a15120c83db4b7d080c155de (patch) | |
| tree | 0da989bd2342b5a53d49c26893a3a544e7432fcc /src/resources/itemdb.cpp | |
| parent | 7ea1c4574d6e845f95f2c4c3a1dd4a5d730bc6ba (diff) | |
| download | mana-59919635523d41f3a15120c83db4b7d080c155de.tar.gz mana-59919635523d41f3a15120c83db4b7d080c155de.tar.bz2 mana-59919635523d41f3a15120c83db4b7d080c155de.tar.xz mana-59919635523d41f3a15120c83db4b7d080c155de.zip | |
General code cleanups
* Removed some unused includes
* Removed unused ListBox::mFont
* Removed wrong cast to SDL_Scancode
* Removed superfluous .c_str()
* Removed superfluous explicit std::string construction
* Removed unused variable
* Use more emplace_back
* Turned FindBeingFunctor into a lambda
* Avoid needless pointer references for ambient layers and use a vector
Diffstat (limited to 'src/resources/itemdb.cpp')
| -rw-r--r-- | src/resources/itemdb.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/resources/itemdb.cpp b/src/resources/itemdb.cpp index 6ff3f58c..8ba80a51 100644 --- a/src/resources/itemdb.cpp +++ b/src/resources/itemdb.cpp @@ -236,9 +236,8 @@ void ItemDB::loadCommonRef(ItemInfo *itemInfo, xmlNodePtr node, const std::strin { if (xmlStrEqual(itemChild->name, BAD_CAST "sprite")) { - std::string attackParticle = XML::getProperty( - itemChild, "particle-effect", ""); - itemInfo->mParticle = attackParticle; + itemInfo->mParticle = XML::getProperty( + itemChild, "particle-effect", std::string()); loadSpriteRef(itemInfo, itemChild); } @@ -272,7 +271,6 @@ void ItemDB::addItem(ItemInfo *itemInfo) else logger->log("ItemDB: Duplicate name (%s) for item id %d found.", temp.c_str(), itemInfo->mId); - } } |