General code cleanups

* Use final for all message handlers, Client, LocalPlayer,
  Being::getType, Being::setPosition and Being::setMap.
  (avoids some warnings about virtual dispatch in constructors)
* Use auto in more places
* Use emplace_back instead of push_back in some places
* Use default member initializers
* Less else after return
* Removed superfluous .c_str()
* Removed type aliases that are only used once
* Removed more unused includes

1 files changed, 3 insertions, 6 deletions

diff --git a/src/resources/hairdb.h b/src/resources/hairdb.h
index 1f75a33a..7da08b8f 100644
--- a/src/resources/hairdb.h
+++ b/src/resources/hairdb.h
@@ -57,7 +57,7 @@ public:
      * @param maxId the max permited id. If not 0, the hairDb won't
      * return ids > to the parameter.
      */
-    std::vector<int> getHairStyleIds(int maxId = 0) const;
+    std::vector<int> getHairStyleIds(int maxId) const;
 
     /**
      * Returns the available hair color ids
@@ -86,11 +86,8 @@ private:
     void loadHairStylesNode(xmlNodePtr stylesNode);
 
     // Hair colors Db
-    using Colors = std::map<int, std::string>;
-    Colors mHairColors;
-
-    using HairStyles = std::set<int>;
-    HairStyles mHairStyles;
+    std::map<int, std::string> mHairColors;
+    std::set<int> mHairStyles;
 
     bool mLoaded = false;
 };