General code cleanups

* Use default member initializers
* Use range-based for loops
* Avoid needless pointer references for ShopItem::mDuplicates
* Removed type aliases that are only used once or twice
* Removed more unused includes
* Removed some unused functions
* Removed superfluous .c_str()
* Rely on default copy and assignment operators for Vector class
* Use std::unique_ptr in some places
* Removed duplicated mPlayerMoney updating in SellDialog
* Removed duplicated Game::handleInput call
* Removed unused SDLInput::mMouseInWindow
* Removed remnant of manual widget positioning in HelpWindow
* Removed superfluous initialization of static pointers

1 files changed, 2 insertions, 4 deletions

diff --git a/src/inventory.cpp b/src/inventory.cpp
index a92a4377..2de03431 100644
--- a/src/inventory.cpp
+++ b/src/inventory.cpp
@@ -159,10 +159,8 @@ void Inventory::removeInventoryListener(InventoryListener* listener)
 
 void Inventory::distributeSlotsChangedEvent()
 {
-    InventoryListenerList::const_iterator i = mInventoryListeners.begin();
-    InventoryListenerList::const_iterator i_end = mInventoryListeners.end();
-    for (; i != i_end; i++)
+    for (auto inventoryListener : mInventoryListeners)
     {
-        (*i)->slotsChanged(this);
+        inventoryListener->slotsChanged(this);
     }
 }