General code cleanups

* Use default member initializers
* Use range-based for loops
* Avoid needless pointer references for ShopItem::mDuplicates
* Removed type aliases that are only used once or twice
* Removed more unused includes
* Removed some unused functions
* Removed superfluous .c_str()
* Rely on default copy and assignment operators for Vector class
* Use std::unique_ptr in some places
* Removed duplicated mPlayerMoney updating in SellDialog
* Removed duplicated Game::handleInput call
* Removed unused SDLInput::mMouseInWindow
* Removed remnant of manual widget positioning in HelpWindow
* Removed superfluous initialization of static pointers

1 files changed, 2 insertions, 2 deletions

diff --git a/src/gui/worldselectdialog.h b/src/gui/worldselectdialog.h
index f2b74582..a1150cb8 100644
--- a/src/gui/worldselectdialog.h
+++ b/src/gui/worldselectdialog.h
@@ -30,7 +30,7 @@
 #include <guichan/keylistener.hpp>
 #include <guichan/listmodel.hpp>
 
-#include <vector>
+#include <memory>
 
 class LoginData;
 class WorldListModel;
@@ -57,7 +57,7 @@ class WorldSelectDialog : public Window, public gcn::ActionListener,
         void mouseClicked(gcn::MouseEvent &mouseEvent) override;
 
     private:
-        WorldListModel *mWorldListModel;
+        std::unique_ptr<WorldListModel> mWorldListModel;
         gcn::ListBox *mWorldList;
         gcn::Button *mChangeLoginButton;
         gcn::Button *mChooseWorld;