General code cleanups

* Use default member initializers
* Use range-based loops
* Don't use 'else' after 'return'
* Removed some unused includes
* Construct empty strings with std::string() instead of ""
* Clear strings with .clear() instead of assigning ""
* Check whether strings are empty with .empty() instead of comparing to ""
* Removed redundant initializations

1 files changed, 3 insertions, 2 deletions

diff --git a/src/gui/widgets/textfield.h b/src/gui/widgets/textfield.h
index bb39810b..3b997ba8 100644
--- a/src/gui/widgets/textfield.h
+++ b/src/gui/widgets/textfield.h
@@ -65,7 +65,7 @@ struct TextHistory
 
 class AutoCompleteLister {
 public:
-    virtual ~AutoCompleteLister() {}
+    virtual ~AutoCompleteLister() = default;
     virtual void getAutoCompleteList(std::vector<std::string>&) const {}
 };
 
@@ -80,7 +80,8 @@ class TextField : public gcn::TextField
         /**
          * Constructor, initializes the text field with the given string.
          */
-        TextField(const std::string &text = "", bool loseFocusOnTab = true);
+        TextField(const std::string &text = std::string(),
+                  bool loseFocusOnTab = true);
         ~TextField() override;
 
         /**