General code cleanups

* Use final for all message handlers, Client, LocalPlayer,
  Being::getType, Being::setPosition and Being::setMap.
  (avoids some warnings about virtual dispatch in constructors)
* Use auto in more places
* Use emplace_back instead of push_back in some places
* Use default member initializers
* Less else after return
* Removed superfluous .c_str()
* Removed type aliases that are only used once
* Removed more unused includes

1 files changed, 3 insertions, 3 deletions

diff --git a/src/gui/charselectdialog.h b/src/gui/charselectdialog.h
index d30e4e68..2deb5a7d 100644
--- a/src/gui/charselectdialog.h
+++ b/src/gui/charselectdialog.h
@@ -84,14 +84,14 @@ class CharSelectDialog : public Window, public gcn::ActionListener,
         void unlock();
         void setLocked(bool locked);
 
-        bool mLocked;
+        bool mLocked = false;
 
         gcn::Label *mAccountNameLabel;
 
         gcn::Button *mSwitchLoginButton;
         gcn::Button *mChangePasswordButton;
-        gcn::Button *mUnregisterButton;
-        gcn::Button *mChangeEmailButton;
+        gcn::Button *mUnregisterButton = nullptr;
+        gcn::Button *mChangeEmailButton = nullptr;
 
         /** The player boxes */
         std::vector<CharacterDisplay*> mCharacterEntries;