General code cleanups

* Use default member initializers
* Use range-based loops
* Don't use 'else' after 'return'
* Removed some unused includes
* Construct empty strings with std::string() instead of ""
* Clear strings with .clear() instead of assigning ""
* Check whether strings are empty with .empty() instead of comparing to ""
* Removed redundant initializations

1 files changed, 2 insertions, 4 deletions

diff --git a/src/gui/beingpopup.cpp b/src/gui/beingpopup.cpp
index 56faed39..9cb585db 100644
--- a/src/gui/beingpopup.cpp
+++ b/src/gui/beingpopup.cpp
@@ -53,9 +53,7 @@ BeingPopup::BeingPopup():
     add(mBeingParty);
 }
 
-BeingPopup::~BeingPopup()
-{
-}
+BeingPopup::~BeingPopup() = default;
 
 void BeingPopup::show(int x, int y, Being *b)
 {
@@ -84,7 +82,7 @@ void BeingPopup::show(int x, int y, Being *b)
     }
     else
     {
-        mBeingParty->setCaption("");
+        mBeingParty->setCaption(std::string());
         setContentSize(minWidth + 10, height + 10);
     }