General code cleanups

* Use default member initializers
* Use range-based loops
* Don't use 'else' after 'return'
* Removed some unused includes
* Construct empty strings with std::string() instead of ""
* Clear strings with .clear() instead of assigning ""
* Check whether strings are empty with .empty() instead of comparing to ""
* Removed redundant initializations

1 files changed, 3 insertions, 3 deletions

diff --git a/src/game.cpp b/src/game.cpp
index 90721224..ea8cbae3 100644
--- a/src/game.cpp
+++ b/src/game.cpp
@@ -298,14 +298,14 @@ static bool saveScreenshot()
         logger->log("Directory %s doesn't exist and can't be created! "
                     "Setting screenshot directory to home.",
                     screenshotDirectory.c_str());
-        screenshotDirectory = std::string(PHYSFS_getUserDir());
+        screenshotDirectory = PHYSFS_getUserDir();
     }
 
     do
     {
         screenshotCount++;
-        filenameSuffix.str("");
-        filename.str("");
+        filenameSuffix.str(std::string());
+        filename.str(std::string());
         filename << screenshotDirectory << "/";
         filenameSuffix << branding.getValue("appShort", "Mana")
                        << "_Screenshot_" << screenshotCount << ".png";