diff options
| author | Thorbjørn Lindeijer <bjorn@lindeijer.nl> | 2024-02-22 13:02:26 +0100 |
|---|---|---|
| committer | Thorbjørn Lindeijer <bjorn@lindeijer.nl> | 2024-02-22 14:32:45 +0100 |
| commit | 81e4f170d8ba4ccbcfa1e6c07bd0522dfc3b6e08 (patch) | |
| tree | e2619b16a5331e5760d94be389d0a3a01427293f /src/client.cpp | |
| parent | d047db79f7034e0e75a85a656d18f40716d197b9 (diff) | |
| download | mana-81e4f170d8ba4ccbcfa1e6c07bd0522dfc3b6e08.tar.gz mana-81e4f170d8ba4ccbcfa1e6c07bd0522dfc3b6e08.tar.bz2 mana-81e4f170d8ba4ccbcfa1e6c07bd0522dfc3b6e08.tar.xz mana-81e4f170d8ba4ccbcfa1e6c07bd0522dfc3b6e08.zip | |
General code cleanups
* Use default member initializers
* Use range-based loops
* Don't use 'else' after 'return'
* Removed some unused includes
* Construct empty strings with std::string() instead of ""
* Clear strings with .clear() instead of assigning ""
* Check whether strings are empty with .empty() instead of comparing to ""
* Removed redundant initializations
Diffstat (limited to 'src/client.cpp')
| -rw-r--r-- | src/client.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/client.cpp b/src/client.cpp index 705cfdc0..506ad692 100644 --- a/src/client.cpp +++ b/src/client.cpp @@ -880,7 +880,7 @@ int Client::exec() case STATE_REGISTER_ATTEMPT: logger->log("Username is %s", loginData.username.c_str()); Net::getLoginHandler()->registerAccount(&loginData); - loginData.password = ""; + loginData.password.clear(); break; case STATE_CHANGEPASSWORD: @@ -900,8 +900,8 @@ int Client::exec() showOkDialog(_("Password Change"), _("Password changed successfully!"), STATE_CHAR_SELECT); - loginData.password = ""; - loginData.newPassword = ""; + loginData.password.clear(); + loginData.newPassword.clear(); break; case STATE_CHANGEEMAIL: @@ -1317,7 +1317,7 @@ void Client::accountLogin(LoginData *loginData) Net::getLoginHandler()->loginAccount(loginData); // Clear the password, avoids auto login when returning to login - loginData->password = ""; + loginData->password.clear(); // TODO This is not the best place to save the config, but at least better // than the login gui window |