Rossy quest: replacing hard coded numbers with variables and some fixes in dialogue

4 files changed, 96 insertions, 64 deletions

diff --git a/world/map/npc/009-2/olana.txt b/world/map/npc/009-2/olana.txt
index e2f868d1..84643483 100644
--- a/world/map/npc/009-2/olana.txt
+++ b/world/map/npc/009-2/olana.txt
@@ -2,10 +2,22 @@
 
 009-2.gat,63,79,0	script	Olana	190,{
 
+  set @MinLevel, 60;
+
+  set @Cherry_Amount, 10;
+  set @Cherry_EXP, 1000;
+  set @Cherry_Money, 1000;
+
+  set @RedRose_Amount, 15;
+  set @RedTulip_Amount, 15;
+  set @Flower_Money, 1500;
+
+  set @Finish_EXP, 5000;
+  set @Finish_Money, 5000;
+
   if (FLAGS & FLAG_ROSSI_COMPLETED) goto L_FinalEnd;
   if (Rossy_Quest == 17 || Rossy_Quest == 18) goto L_End;
 
-
   if (Rossy_Quest >= 14 && Rossy_Quest <= 16) goto L_Julia;
   if (Rossy_Quest == 13) goto L_Best;
   if (Rossy_Quest == 12) goto L_Give;
@@ -23,13 +35,13 @@
   mes "\"Hello. We don't usually get guests back here.\"";
   next;
   mes "\"My name is Olana and my father owns this inn. I live in Tulimshar, but came to Hurnscald on vacation with my two young daughters, Rossy and Julia.\"";
-  if (baselevel < 60) close;
+  if (baselevel < @MinLevel) close;
   next;
   mes "\"I let my two lovely girls play in the woods nearby but they haven't come back yet!\"";
   next;
   mes "Olana suddenly looks very pale and starts to shiver.";
   next;
-  mes "\"I'm starting to get a bad feeling about this... If you go to the forest near the swamps, could you see if you can find my daughters? I need to know if they are safe!\"";
+  mes "\"I'm starting to get a bad feeling about this. If you go to the forest near the swamps, could you see if you can find my daughters? I need to know if they are safe!\"";
   menu
     "Sure, I can do that.", -,
     "I am sorry, I don't usually go to that area.", L_No;
@@ -63,19 +75,19 @@ L_Help:
 L_Worried:
   mes "Olana smiles at you, trying to show some happiness, but her facial expression only conveys tension and preoccupation.";
   next;
-  mes "You suddenly remember that Rossy asked for your help to collect some fruits... Maybe she could also have some ideas on how to cheer her mother up.";
+  mes "You suddenly remember that Rossy asked for your help to collect some fruits. Maybe she could also have some ideas on how to cheer her mother up.";
   close;
 
 L_See:
   if (gotcherry == 1) goto L_Task;
-  if (countitem("cherry") < 10) goto L_Worried;
-  delitem "cherry", 10;
+  if (countitem("cherry") < @Cherry_Amount) goto L_Worried;
+  delitem "cherry", @Cherry_Amount;
   menu
     "Hi, Rossy asked me to give you this. She says it is a gift from both her and Julia.", -;
   mes "[Olana]";
-  mes "\"Ohhh... How sweet... Sometimes Rossy impresses me with her kindness. Here...You are spending so much time helping us, and we give nothing back. Take this as a small reward. \"";
-  getexp 1000, 0;
-  set zeny, zeny + 1000;
+  mes "\"Ohhh... How sweet... Sometimes Rossy impresses me with her kindness. Here... You are spending so much time helping us, and we give nothing back. Take this as a small reward.\"";
+  getexp @Cherry_EXP, 0;
+  set zeny, zeny + @Cherry_Money;
   set gotcherry, 1;
   goto L_Task;
 
@@ -119,7 +131,7 @@ L_Rose:
     "Just tell me what to do.", -,
     "No, I'm busy, maybe later.", L_No;
   mes "[Olana]";
-  mes "\"Can you bring me 15 Red Roses? I would like to give them to Rossy. I am sure she will love them!\"";
+  mes "\"Can you bring me " + @RedRose_Amount + " Red Roses? I would like to give them to Rossy. I am sure she will love them!\"";
   menu
     "Ok, I will be back with the roses.", L_RG,
     "I'm allergic to roses, can't even touch them. Sorry.", L_No;
@@ -127,11 +139,11 @@ L_Rose:
 L_RG:
   if (Rossy_Quest == 8) set Rossy_Quest, 9;
   mes "[Olana]";
-  mes "\"Please, bring me 15 Red Roses as soon as you can.\"";
+  mes "\"Please, bring me " + @RedRose_Amount + " Red Roses as soon as you can.\"";
   close;
 
 L_RC:
-  if(countitem("redrose") < 15) goto L_RG;
+  if(countitem("redrose") < @RedRose_Amount) goto L_RG;
   mes "[Olana]";
   set Rossy_Quest, 10;
   mes "\"Great job! Please hand them to my brilliant daughter, Rossy.\"";
@@ -151,7 +163,7 @@ L_Allergic:
   set Rossy_Quest, 12;
   mes "[Olana]";
   mes "\"Oh, how stupid I am! Here, take some of my money and buy Red Tulips instead, the same amount. Keep the flowers.\"";
-  set zeny, zeny + 1500;
+  set zeny, zeny + @Flower_Money;
   next;
   mes "\"Please, tell Rossy I am really sorry. My mind was on Julia when I asked you to bring the red roses, they are her favorite.\"";
   menu
@@ -162,7 +174,7 @@ L_Allergic:
 
 L_Give:
   mes "[Olana]";
-  mes "\""+ strcharinfo(0) +", please, get 15 Red Tulips and hand them to Rossy. Don't forget to tell her that I'm really sorry.\"";
+  mes "\""+ strcharinfo(0) +", please, get " + @RedTulip_Amount + " Red Tulips and hand them to Rossy. Don't forget to tell her that I'm really sorry.\"";
   close;
 
 L_Best:
@@ -187,8 +199,8 @@ L_Found:
   if (Rossy_Quest == 17) set Rossy_Quest, 18;
   if (Rossy_Quest == 18) set Rossy_Quest, 19;
   mes "\"Thank you "+ strcharinfo(0) +", thank you! Here is a reward for you.\"";
-  getexp 5000, 0;
-  set zeny, zeny + 5000;
+  getexp @Finish_EXP, 0;
+  set zeny, zeny + @Finish_Money;
   if (Rossy_Quest == 19) goto L_Clear;
   close;
 
diff --git a/world/map/npc/024-1/david.txt b/world/map/npc/024-1/david.txt
index a7dfc094..00794e03 100644
--- a/world/map/npc/024-1/david.txt
+++ b/world/map/npc/024-1/david.txt
@@ -1,19 +1,21 @@
-024-1.gat,70,70,0	script	David	120,{ 
+024-1.gat,70,70,0	script	David	120,{
+
+  set @Potion_EXP, 2000;
 
   if (Rossy_Quest == 17) goto L_FinalEnd;
   if (Rossy_Quest == 14) goto L_Julia;
   if (Rossy_Quest >= 8) goto L_Done;
-  
+
   mes "[David]";
   mes "\"Learning magic is hard...\"";
   if (Rossy_Quest == 7) goto L_Help;
   close;
-  
+
 L_Help:
   menu
     "Do you know Rossy?", L_Set,
     "I can tell, it is hard.", L_No;
-    
+
 L_Set:
   mes "[David]";
   mes "\"Yes, I do. I am her teacher. Actually, that reminds me about her final exam... she didn't hand in her potion yet. Time is running out.\"";
@@ -21,12 +23,12 @@ L_Set:
     "A potion? Oh, uhm... Strange kind of exam. Bye.", L_No,
     "Right, I have her potion in my pocket. She asked me to bring it to you. Here it is.", -;
   mes "[David]";
-  mes "\"Let me see...\"";
+  mes "\"Let me see.\"";
   set Rossy_Quest, 8;
   mes "\"This potion is... perfect! Tell Rossy that she succesfully made her potion, it is flawless!\"";
-  getexp 2000, 0;
+  getexp @Potion_EXP, 0;
   close;
-  
+
 L_Done:
   mes "[David]";
   mes "\"I am really happy that my best student succesfully passed her exam!\"";
diff --git a/world/map/npc/025-1/rossy.txt b/world/map/npc/025-1/rossy.txt
index a9f425bb..86cc1bff 100644
--- a/world/map/npc/025-1/rossy.txt
+++ b/world/map/npc/025-1/rossy.txt
@@ -2,6 +2,23 @@
 
 025-1.gat,80,88,0	script	Rossy	114,{
 
+  set @Cherry_Amount, 10;
+  set @Cherry_EXP, 2000;
+
+  set @CactusDrink_Amount, 24;
+  set @MaggotSlime_Amount, 32;
+  set @GambodgeHerb_Amount, 50;
+  set @AlizarinHerb_Amount, 43;
+  set @BugLeg_Amount, 30;
+  set @Potion_EXP, 3000;
+
+  set @RedRose_Amount, 15;
+  set @RedTulip_Amount, 15;
+  set @Flower_EXP, 2500;
+
+  set @Finish_EXP, 5000;
+  set @Finish_Money, 5000;
+
   if (FLAGS & FLAG_ROSSI_COMPLETED) goto L_FinalEnd;
   if (Rossy_Quest == 17 || Rossy_Quest == 18) goto L_End;
 
@@ -23,19 +40,19 @@
     "Hey, hey... Why are you crying? Are you hurt?", -,
     "Sorry kid, I don't have time to play with children.", L_No;
   mes "[Young Girl]";
-  mes "\"No. I am crying because I lost all my fruits. My sister and I were collecting some near Dimond's Cove, but then I stumbled on a giant snail and it attacked us!";
+  mes "\"No. I'm crying because I lost all my fruits. My sister and I were collecting some near Dimond's Cove, but then I stumbled on a giant snail and it attacked us!";
   next;
-  mes "But we were lucky, because the snail is really slow and we ran away from it. Julia ran to the left and I ran to the right. The snail got pretty confused, because we are identical twins... But the problem is that I dropped the basket full of fruits on the ground and that evil snail ate them all! And now I can't find Julia to help me collect more fruits.\"";
+  mes "But we were lucky, because the snail is really slow and we ran away from it. Julia ran to the left and I ran to the right. The snail got pretty confused, because we are identical twins. The problem is that I dropped the basket full of fruits on the ground and that evil snail ate them all! And now I can't find Julia to help me collect more fruits.\"";
   next;
   menu
     "Did you say Julia? I talked to you mother. She is very worried about you.", -;
   mes "[Rossy]";
-  mes "\"Really? But she let us play in the woods... There is no reason to be worried. Unless...\"";
+  mes "\"Really? But she let us play in the woods. There is no reason to be worried. Unless...\"";
   next;
-  mes "Rossy suddenly gets a strange look on her face, mumbling something about Julia...";
+  mes "Rossy suddenly gets a strange look on her face, mumbling something about Julia.";
   next;
   mes "[Rossy]";
-  mes "\"Could you do me a favor? Please, tell my mother we are alright... There is.. uh... there is no reason to worry about us.\"";
+  mes "\"Could you do me a favor? Please, tell my mother we are alright. There is.. uh... there is no reason to worry about us.\"";
   next;
   menu
     "Ok, if you say so.", -,
@@ -55,21 +72,21 @@ L_Mother:
 
 L_Get_Cherry:
   mes "[Young Girl]";
-  mes "\"No, you don't have 10 cherries. I know how to count. I hope you get them soon.\"";
+  mes "\"No, you don't have " + @Cherry_Amount + " cherries. I know how to count. I hope you get them soon.\"";
   close;
 
 L_Check:
   mes "[Rossy]";
-  mes "\"Hey, that is nice of you to come back. I was thinking about giving a basket full of cherries to my mother, to make her happy, you know... But we'd need at least ten cherries, and it would take ages for me to get so many by myself!\"";
+  mes "\"Hey, that is nice of you to come back. I was thinking about giving a basket full of cherries to my mother, to make her happy, you know. But we'd need at least " + @Cherry_Amount + " cherries, and it would take ages for me to get so many by myself!\"";
   next;
   menu
     "That is no problem for me. Just wait and I will come back with the cherries.", L_No,
     "Hey, I have some cherries in my backpack!", -,
     "You should get them yourself.", L_No;
-  if(countitem("Cherry") < 10) goto L_Get_Cherry;
+  if(countitem("Cherry") < @Cherry_Amount) goto L_Get_Cherry;
   mes "[Rossy]";
   set Rossy_Quest, 4;
-  getexp 2000, 0;
+  getexp @Cherry_EXP, 0;
   mes "\"I can't believe it, you got them all! Please give them to my mother. Tell her it is a gift from me and Julia and there is no reason to worry about us.\"";
   next;
   mes "Rossy mumbles to herself.";
@@ -82,7 +99,7 @@ L_Check:
 
 L_Cherry_Done:
   mes "[Rossy]";
-  mes "\"Please, try to distract my mother... I don't want her to be worried about us. While you do this, I will try to find Julia.\"";
+  mes "\"Please, try to distract my mother. I don't want her to be worried about us. While you do this, I will try to find Julia.\"";
   close;
 
 L_Let:
@@ -91,10 +108,9 @@ L_Let:
   next;
   menu
     "Your mother asked me to hand you this letter. She told me it was from your teacher.", L_Let2,
-    "Not at all... I need to go now, see you next time.", L_No;
+    "Not at all. I need to go now, see you next time.", L_No;
 
 L_Let2:
-  mes "[Rossy]";
   mes "The little girl grabs the piece of paper and reads it quickly. Her face turns pale.";
   menu
     "What does it say?", -;
@@ -102,35 +118,35 @@ L_Let2:
   mes "\"Oh no, I completely forgot! My magic school exam! I need to make a potion and give it to my teacher today! But I haven't found Julia yet and I don't even have any of the ingredients required. Could you get them for me, please?\"";
   next;
   set Rossy_Quest, 6;
-  mes "\"I need 24 Cactus Drinks, 32 Maggot Slimes, 50 Gamboge Herbs, 43 Alizarin Herbs and 30 Bug Legs.\"";
+  mes "\"I need " + @CactusDrink_Amount + " Cactus Drinks, " + @MaggotSlime_Amount + " Maggot Slimes, " + @GambodgeHerb_Amount + " Gamboge Herbs, " + @AlizarinHerb_Amount + " Alizarin Herbs and " + @BugLeg_Amount + " Bug Legs.\"";
   next;
   mes "\"Please come back to see me when you have the ingredients. I know the recipe by heart.\"";
   close;
 
 L_NE:
   mes "[Rossy]";
-  mes "\"Please bring me 24 Cactus Drinks, 32 Maggot Slimes, 50 Gamboge Herbs, 43 Alizarin Herbs and 30 Bug Legs.\"";
+  mes "\"Please bring me " + @CactusDrink_Amount + " Cactus Drinks, " + @MaggotSlime_Amount + " Maggot Slimes, " + @GambodgeHerb_Amount + " Gamboge Herbs, " + @AlizarinHerb_Amount + " Alizarin Herbs and " + @BugLeg_Amount + " Bug Legs.\"";
   next;
   mes "\"Please hurry!\"";
   close;
 
 L_Check2:
-  if(countitem("CactusDrink") < 24) goto L_NE;
-  if(countitem("MaggotSlime") < 32) goto L_NE;
-  if(countitem("GambogeHerb") < 50) goto L_NE;
-  if(countitem("AlizarinHerb") < 43) goto L_NE;
-  if(countitem("BugLeg") < 30) goto L_NE;
-  delitem "CactusDrink", 24;
-  delitem "MaggotSlime", 32;
-  delitem "GambogeHerb", 50;
-  delitem "AlizarinHerb", 43;
-  delitem "BugLeg", 30;
-  mes "Rossy gets all the ingredients and places them on the ground. She starts to mix some herbs with the cactus drinks and appears to cast some spells... She seems to know what she is doing.";
-  next;
-  mes "[Rossy]";
-  mes "\"Oh, thank you "+ strcharinfo(0) +" ! It is done. If you don't mind, please give this potion to my teacher.\"";
+  if(countitem("CactusDrink") < @CactusDrink_Amount) goto L_NE;
+  if(countitem("MaggotSlime") < @MaggotSlime_Amount) goto L_NE;
+  if(countitem("GambogeHerb") < @GambodgeHerb_Amount) goto L_NE;
+  if(countitem("AlizarinHerb") < @AlizarinHerb_Amount) goto L_NE;
+  if(countitem("BugLeg") < @BugLeg_Amount) goto L_NE;
+  delitem "CactusDrink", @CactusDrink_Amount;
+  delitem "MaggotSlime", @MaggotSlime_Amount;
+  delitem "GambogeHerb", @GambodgeHerb_Amount;
+  delitem "AlizarinHerb", @AlizarinHerb_Amount;
+  delitem "BugLeg", @BugLeg_Amount;
+  mes "Rossy takes all the ingredients and places them on the ground. She starts to mix some herbs with the cactus drinks and appears to cast some spells. She seems to know what she is doing.";
+  next;
+  mes "[Rossy]";
+  mes "\"Oh, thank you "+ strcharinfo(0) +"! It is done. If you don't mind, please give this potion to my teacher.\"";
   set Rossy_Quest, 7;
-  getexp 3000, 0;
+  getexp @Potion_EXP, 0;
   message strcharinfo(0), "Rossy hands you the potion, holding the bottle very carefully.";
   next;
   mes "\"My teacher's name is David. He is a very young magician and lives near the magic school in the north of Tulimshar.\"";
@@ -146,7 +162,7 @@ L_BT:
   close;
 
 L_Donet:
-  if (Rossy_Quest == 10 && countitem("redrose") >= 15) goto L_RG;
+  if (Rossy_Quest == 10 && countitem("redrose") >= @RedRose_Amount) goto L_RG;
   menu
     "David took your potion and he tested it in front of me. It worked perfectly!", -;
   mes "[Rossy]";
@@ -154,8 +170,8 @@ L_Donet:
   close;
 
 L_RG:
-  if (countitem("redrose") < 15) goto L_No;
-  delitem "redrose", 15;
+  if (countitem("redrose") < @RedRose_Amount) goto L_No;
+  delitem "redrose", @RedRose_Amount;
   menu
     "Your mother was so happy that she asked me to bring you these flowers.", -;
   mes "[Rossy]";
@@ -171,7 +187,7 @@ L_RG:
 
 L_Allergic:
   mes "Rossy sneezes a lot.";
-  if (Rossy_Quest == 12 && countitem("redtulip") >= 15) goto L_Sorry;
+  if (Rossy_Quest == 12 && countitem("redtulip") >= @RedTulip_Amount) goto L_Sorry;
   close;
 
 L_Sorry:
@@ -180,13 +196,13 @@ L_Sorry:
 
 L_See:
   mes "[Rossy]";
-  if (countitem("redtulip") < 15) goto L_No;
-  delitem "redtulip", 15;
+  if (countitem("redtulip") < @RedTulip_Amount) goto L_No;
+  delitem "redtulip", @RedTulip_Amount;
   set Rossy_Quest, 13;
   mes "\"That's better! Go and tell my mother that she is the nicest mother in the world.\"";
   next;
-  mes "\"Now I should really find my sister... Come back later.\"";
-  getexp 2500, 0;
+  mes "\"Now I should really find my sister. Come back later.\"";
+  getexp @Flower_EXP, 0;
   close;
 
 L_Best:
@@ -195,7 +211,7 @@ L_Best:
   next;
   menu
     "Did you find your sister? I am starting to get worried too.", -;
-  mes "\"I think I have an idea where she might be... Come back in a few minutes, I will tell you if she is ok.\"";
+  mes "\"I think I have an idea where she might be. Come back in a few minutes, I will tell you if she is ok.\"";
   set Rossy_Quest, 14;
   close;
 
@@ -218,8 +234,8 @@ L_Found:
   mes "\"Oh "+ strcharinfo(0) +", thank you very much! Take this, you deserve it!\"";
   next;
   mes "Rossy hands you a huge bag full of coins.";
-  getexp 5000, 0;
-  set zeny, zeny + 5000;
+  getexp @Finish_EXP, 0;
+  set zeny, zeny + @Finish_Money;
   if (Rossy_Quest == 19) goto L_Clear;
   close;
 
diff --git a/world/map/npc/025-4/julia.txt b/world/map/npc/025-4/julia.txt
index ef52faa1..ecb7703a 100644
--- a/world/map/npc/025-4/julia.txt
+++ b/world/map/npc/025-4/julia.txt
@@ -2,6 +2,8 @@
 
 025-4.gat,89,21,0	script	Julia	114,{
 
+  set @Reward_EXP, 5000;
+
   if (Rossy_Quest > 16 || FLAGS & FLAG_ROSSI_COMPLETED) goto L_End;
   if (Rossy_Quest == 16) goto L_Done;
   if (Rossy_Quest <= 15) goto L_Hmmm;
@@ -16,7 +18,7 @@ L_Done:
   getinventorylist;
   if (@inventorylist_count == 100) goto L_TooMany;
   getitem "BlackBoots", 1;
-  getexp 5000, 0;
+  getexp @Reward_EXP, 0;
   set Rossy_Quest, 17;
   mes "\"I'm out of here now, lets get out of this horrible cave.\"";
   close;