summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2025-02-21Made ActorSprite aggregate instead of subclass CompoundSpriteThorbjørn Lindeijer5-72/+49
Also, CompoundSprite itself no longer derives from Sprite. This simplifies the class hierarchies and avoids the compiler warning about Being::setDirection shadowing Sprite::setDirection.
2025-02-21Replaced ImageSprite in Emote by plain ImageThorbjørn Lindeijer5-32/+29
Emotes just need an image to be represented in the UI, so we don't need to use ImageSprite.
2025-02-21Moved stun and status effect handling from ActorSprite to BeingThorbjørn Lindeijer8-186/+160
Since this stuff is only relevant for Being instances and not for FloorItem instances. Also removed the virtual getWidth/getHeight from Actor, since they were not actually used.
2025-02-21Fixed too fast animations for MiniStatusWindow iconsThorbjørn Lindeijer3-6/+6
AnimatedSprite works with delta time since 7de0b165f196cb0c1f983b6d2a. Adjusted some parameter names for clarity. Closes https://git.themanaworld.org/mana/mana/-/issues/94
2025-02-20Simplified filling of the BufferedRWops bufferThorbjørn Lindeijer1-23/+5
In fact filling the buffer only happens when the buffer was exhausted or empty, so we always want to fill it entirely and don't need to bother with moving remaining contents. This is what happens when you let AI write your code.
2025-02-20Fixed stutter when new music starts playingThorbjørn Lindeijer5-1/+253
This is a workaround for a performance issue when SDL_mixer is using stb_vorbis. Since stb_vorbis will request the file one byte at a time, the overhead of using SDL_RWops to call PHYSFS_readBytes is too high. Solved by introducing a buffered SDL_RWops wrapper with a fixed 2048 byte buffer. This is a more optimal solution than loading the entire OGG file in memory. Now starting a new song takes less than 1ms, when the OGG file isn't compressed (almost down to 0.2ms when SDL_mixer uses libvorbisfile). See https://github.com/libsdl-org/SDL_mixer/issues/670 Closes https://git.themanaworld.org/mana/mana/-/issues/93
2025-02-17Further ResourceManager and PhysFS cleanupsThorbjørn Lindeijer15-308/+117
* Wrapped remaining PhysFS API calls and set PHYSFS_DEPRECATED to suppress deprecation warnings for PHYSFS_getUserDir, since no alternative is available for now. * Removed support for decompressing .gz files, since it has been unused for years and doesn't seem useful when updates are anyway served in an archive. * Use SDL_LoadFile and SDL_LoadFile_RW convenience functions (raises minimum SDL version to 2.0.10). * Removed ResourceManager::copyFile, since it was unused and will likely stay unused. * Removed ResourceManager::loadTextFile. Instead, split up the string in BrowserBox::addRows without making additional copies.
2025-02-17Wrapped PhysFS usage in a convenience APIThorbjørn Lindeijer10-138/+331
* Most direct PhysFS calls now contained within a single header file. * File class that automatically closes. * Files class allows iterating files with range-based for. * Use std::optional to force error handling where applicable.
2025-02-15Fixed handling of connection failureThorbjørn Lindeijer1-21/+12
After failure to connect it would immediately try to connect to the chosen server, only to fail again. Now it goes back to the server choice dialog instead. Closes https://git.themanaworld.org/mana/mana/-/issues/86
2025-02-14Fixed handling of update URLs which mention a portThorbjørn Lindeijer6-91/+65
This appears to have been a regression in f405849b49614254f42eb3ee6147434458978623, which for some reason erased the port (and any trailing parts) from not just the update directory but also from the update URL. Unfortunately we can't access Mana-Mantis #381 at the moment, but presumably the port was removed due to the colon being a problematic character. Instead, now the colon (and other special characters) are replaced by _ when determining the update directory. Closes https://git.themanaworld.org/mana/mana/-/issues/80
2025-02-14Fixed issue in ParticleContainer destructorThorbjørn Lindeijer3-8/+9
It was trying to call a virtual method for cleanup with the intention of doing cleanup in its subclasses, but that doesn't work in a destructor. Could simplify ActorSprite destructor as a result.
2025-02-13TMWA: Reduce magic numbers when converting directionThorbjørn Lindeijer2-29/+28
2025-02-13Support changing being base typeThorbjørn Lindeijer10-110/+158
The GM command @class (alias @charclass) can be used by GMs to change their character class (also referred to as job, race, base or species). Changes of the class are now supported, even supporting switching between appearing as player, monster or NPC. Part of https://git.themanaworld.org/mana/mana/-/issues/92
2025-02-13Implemented support for item replacementsThorbjørn Lindeijer8-39/+266
Specifying an unknown sprite or direction is reported as error and will not cause any replacements. Specific item replacements are supported also when not specifying the sprite. Replacements do not affect particle effects. Part of https://git.themanaworld.org/mana/mana/-/issues/92
2025-01-25snap: Updated to core24Thorbjørn Lindeijer2-0/+4
2025-01-21Replaced include guards with #pragma onceThorbjørn Lindeijer275-1093/+280
Thanks to https://github.com/cgmb/guardonce and a follow-up replace to remove duplicated newlines at end of file: find src -type f -name '*.h' -exec \ sed --in-place -e :a -e '/^\n*$/{$d;N;};/\n$/ba' {} \; Source: https://unix.stackexchange.com/questions/81685/how-to-remove-multiple-newlines-at-eof Fixes compile on macOS, which appears to have been due to the EVENT_H include guard.
2025-01-21Update names as soon as the "Show gender" option is changedThorbjørn Lindeijer4-10/+31
No need to wait for Apply for this option. Using `ConfigOptionChanged` event rather than direct call into `ActorSpriteManager::updatePlayerNames`.
2025-01-21Fixed ConfigOptionChanged eventsThorbjørn Lindeijer10-20/+71
With the statically typed config we no longer get an event for each changed config value. Where relevant, this is now done through `setConfigValue`. The `Event` now uses a `std::any`, which for `ConfigOptionChanged` events is set to the changed `Config` member. This allows for a type-safe check on which config value was changed.
2025-01-20Made client config statically typedThorbjørn Lindeijer79-1184/+1184
This makes accessing the config values much faster, since it no longer needs to do a lookup nor string conversion, which means we could remove some needless copying of the values. Overall it makes it easier to find out where settings are used and it puts the defaults along with the declaration. Options with default values are no longer saved to the config file. This does not include unrecognized options, which are kept around to provide some compatibility with older clients. While most basic options have kept the same name, more complicated settings like window geometry, shortcuts, outfits, etc. now have their own XML elements. Older clients will ignore these and erase them when saving the configuration.
2025-01-20Cleaned up path handling a bitThorbjørn Lindeijer3-47/+37
2025-01-20Wrapped xmlNodePtr access with a Node classThorbjørn Lindeijer46-705/+668
Slightly more ergonomic and this eliminates direct libxml2 usage from many places.
2025-01-18Introduced small convenience wrapper to write XMLThorbjørn Lindeijer6-42/+140
Might not seem worth it right now, but it will be if we write out more XML structures.
2024-12-20Read whole packet SMSG_MAP_QUIT_RESPONSE.Andrei Karas1-1/+1
2024-10-29Fixed storing of player relationsThorbjørn Lindeijer2-27/+14
There were two issues here. First, the loading of the relations was triggering a storing of the settings before they were loaded. In effect, all the related settings were reset on every startup. And since storing of the relations wasn't enabled by default, they were always cleared. Second problem was in `PlayerConfSerialiser::readConfigItem`, which was never setting any relation because of an inverted condition introduced in 9a702e64449ba54fab28706c5b9c5ff9f2a41f8a.
2024-10-29Turned the PlayerRelation struct into an enum classThorbjørn Lindeijer10-106/+82
Less code to achieve the same thing (strong type and namespaced values). The permissions related values have been moved to a PlayerPermissions struct, which is also a bit less confusing.
2024-10-29Optimise PlayerRelationsManager::clearThorbjørn Lindeijer6-51/+34
Previous implementation was O(n^2), doing lots of work (saving file and updating UI) for each removed player.
2024-10-29Avoid some needless pointer indirectionThorbjørn Lindeijer3-82/+49
* Don't use `PlayerRelation*` in `mRelations`, but just store the value. * Pass `std::vector<PlayerIgnoreStrategy *>` by reference instead of pointer. * Return player list in `PlayerRelationsManager::getPlayers` by value instead of pointer. Overall these changes simplify the code, making it less prone to errors.
2024-10-26Fixed FPS limit being enabled by defaultThorbjørn Lindeijer8-38/+21
There were some inconsistencies between the values set up in `Client::initConfiguration` and those in `getConfigDefaults`. These duplicates have now been removed. For some of these settings the code getting the values had to be adjusted to use getBoolValue, to actually rely on the provided default instead of one provided as a parameter.
2024-10-23Changed SERVER_NOTICE macro to inline functionThorbjørn Lindeijer21-159/+152
Seems to be no point in using a macro here.
2024-10-23Various small fixes to translatable stringsThorbjørn Lindeijer12-25/+25
Mostly adjustments based on feedback from the Finnish translator.
2024-10-18Added small grabbable margin to Shortcuts windowThorbjørn Lindeijer5-81/+32
The Shortcuts window could no longer be moved since adding support for resizing windows at the top edge. Now there is again a bit of space where the window can be grabbed. Included some related cleanups.
2024-10-18Avoid accessing static members through instancesThorbjørn Lindeijer5-40/+40
Fixed with clang-tidy `readability-static-accessed-through-instance` check.
2024-10-18Some code cleanups in ResourceManagerThorbjørn Lindeijer1-10/+4
* Use 'time' instead of 'gettimeofday', since we only use the timestamp anyway. * Use the iterator returned by std::map::erase.
2024-10-18General code cleanupsThorbjørn Lindeijer9-38/+19
2024-10-18Take only const pointers to images in GraphicsThorbjørn Lindeijer6-43/+43
Helps making sure we're not modifying the images in the rendering code. Re-applies 4eea727b7649726670d8963d11ab4fd429624b3e (and reverts 363f71157a8107190b3bd2ba656faf0a0e63ab36).
2024-10-15Fixed crash when taking screenshot with scaled graphicsThorbjørn Lindeijer2-15/+28
Because the allocated surface was based on the unscaled size, writing the actual pixels was overwriting random memory.
2024-10-12Added support for hit/miss sounds on equipment for all playersThorbjørn Lindeijer5-30/+32
Previously only the local player's weapon "strike" sound would play, regardless of hit or miss. Now the sound is played in response to the SMSG_BEING_ACTION message, so it can be played for all players. Also added alias "miss", which is used by TMW in some places. Finally, when no weapon is equipped, it falls back to the sounds defined on the racesprite item (fixes punch sound on TMW). Closes #68
2024-10-08Small cleanup in OutfitWindow::loadThorbjørn Lindeijer2-19/+7
Based on MV commit db452921bafb2dd322b52c1e5d03e5e713849dd0.
2024-10-08Simplified "drawnWhenBehind" logicThorbjørn Lindeijer8-37/+8
* Removed `Actor::getNumberOfLayers`, since we really only cared about whether they should be visible when behind other stuff. * Removed `CompoundSprite::drawnWhenBehind`, since this property was only relevant for actors.
2024-10-08Restore the screen shake effectThorbjørn Lindeijer2-30/+32
Now the experience mightes better with what it was before the logic update change (59a7d5c58f8b3af21b3e19d4e78f5653bf011bfb). The per-frame effect is reduced and less constant, based on a sine wave. The effect is no longer applied directly to the mPixelViewX/Y values, but is rather only taken into account when rendering the view.
2024-10-08Use Timer for duration of blinking nameThorbjørn Lindeijer3-23/+18
This fixes the duration on 1500 ms, whereas before it was dependent on the framerate, blinking for 200 frames.
2024-10-08Smoother keyboard movementThorbjørn Lindeijer4-26/+39
This change addresses the slight stutter and broken animation playback when walking with the keyboard. Once the end of the path has been reached but a movement key is still held, the LocalPlayer now immediately calculates a new path rather than waiting on the next logic update.
2024-10-08Smoother being movementThorbjørn Lindeijer7-67/+71
There was a slight stutter in being movement, since each time a being reached the next position along its path, it would only continue to the following position with the next logic tick. Now the logic has been adjusted to keep moving until all the time for the current frame was used up, or the path was exhausted. A slight stutter remains for keyboard movement, as well as broken walk animation playback, since it will only set a new path once the current one is finished (see e554d9b2be1ec2fcb15065ae70151302adeef602). Also simplified some logic in Viewport::draw and removed some obsolete code in LocalPlayer::startWalking.
2024-10-08Do a single logic update each frameThorbjørn Lindeijer26-113/+92
The logic update now uses Time::deltaTimeMs() where needed to make it framerate-independent. This means there will no longer be multiple logic calls per frame (as was usually the case with logic ticking at 100 fps whereas the game would generally run at 60 fps). At the same time, the game can be more precise at higher framerates and should now run smoother at 144 Hz, for example. Previously the game would sometimes skip logic ticks at that rate. This change affects: * Updating of animations * Being movement speed * More moving of manual time variables to Timer Notoriously, the particle system still does 100 ticks/second.
2024-10-08Added convenient and efficient Timer classThorbjørn Lindeijer26-293/+388
The Timer is efficient because it does not depend on incrementing a counter to keep track of time, nor does it call SDL_GetTicks every time its state is checked (this happens once per frame instead). Along with global functions Time::absoluteTimeMs() and Time::deltaTimeMs(), this replaces previous globals tick_time, cur_time and get_elapsed_time(). For now, there is still a fixed 100 times per second logic call rate, but the new Time::deltaTimeMs() function should allow getting rid of this.
2024-10-04Removed useless LocalPlayer::mUpdateNameThorbjørn Lindeijer6-39/+3
Maybe it once had a use, but a change in the "Show own name" setting is already handled by LocalPlayer::event.
2024-10-02Fixed potential crash in character selectionThorbjørn Lindeijer1-0/+2
When items with particle effects are equipped.
2024-10-02Removed getter/setter cruft from BeingInfoThorbjørn Lindeijer6-143/+86
Made the class and the code in general more readable by removing all the needless getters and setters. Also used "enum class" for SoundEvent.
2024-09-30Reduce number of rand() calls in Particle::updateAndrei Karas1-3/+4
(cherry picked from M+ commit cc6b5ebf94ad24180a4db69aa87cae07e3c876d2)
2024-09-30Added support for particle effects on equipmentThorbjørn Lindeijer6-37/+104
The effect is also there when the equipment is dropped, because it uses the same field as the floor item. Removed unused ItemInfo::particle. Based roughly on M+ commit 44e5d8bcb7fea443ca9ed3844454b11ac6e4dbed. Closes #85
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2025-04-04 19:18:59 +0000