General code cleanups

* Use default member initializers
* Use range-based for loops
* Avoid needless pointer references for ShopItem::mDuplicates
* Removed type aliases that are only used once or twice
* Removed more unused includes
* Removed some unused functions
* Removed superfluous .c_str()
* Rely on default copy and assignment operators for Vector class
* Use std::unique_ptr in some places
* Removed duplicated mPlayerMoney updating in SellDialog
* Removed duplicated Game::handleInput call
* Removed unused SDLInput::mMouseInWindow
* Removed remnant of manual widget positioning in HelpWindow
* Removed superfluous initialization of static pointers

1 files changed, 2 insertions, 4 deletions

diff --git a/src/textmanager.cpp b/src/textmanager.cpp
index 35a20781..fff95f05 100644
--- a/src/textmanager.cpp
+++ b/src/textmanager.cpp
@@ -57,13 +57,11 @@ void TextManager::removeText(const Text *text)
     }
 }
 
-TextManager::~TextManager()
-{
-}
+TextManager::~TextManager() = default;
 
 void TextManager::draw(gcn::Graphics *graphics, int xOff, int yOff)
 {
-    for (auto &text : mTextList)
+    for (auto text : mTextList)
     {
         text->draw(graphics, xOff, yOff);
     }