Arbitrary code cleanups

Just some stuff that piles up while "looking" at the code, which
eventually gets annoying to ignore while staging real changes.

* Replaced a few NULL occurrences with 0
* Rely on default parameter for std::vector::resize.
* Replaced a few "" with std::string()
* Prefer .empty() to == ""
* Removed a few comparisons with NULL
* Don't check pointers before deleting them
* Removed a bunch of redundant semicolons
* Made some global variables static (local to their compilation unit)
* Prefer prefix ++/-- operators to postfix versions when possible
* Corrected location of a comment

1 files changed, 11 insertions, 13 deletions

diff --git a/src/playerinfo.cpp b/src/playerinfo.cpp
index feb39413..6fd4a71a 100644
--- a/src/playerinfo.cpp
+++ b/src/playerinfo.cpp
@@ -33,25 +33,23 @@ namespace PlayerInfo {
 
 class PlayerLogic;
 
-PlayerLogic *mListener = 0;
+static PlayerLogic *mListener = 0;
 
-PlayerInfoBackend mData;
+static PlayerInfoBackend mData;
 
-Inventory *mInventory = 0;
-Equipment *mEquipment = 0;
+static Inventory *mInventory = 0;
+static Equipment *mEquipment = 0;
 
-bool mStorageCount = 0;
+static bool mStorageCount = 0;
 
-bool mNPCCount = 0;
-bool mNPCPostCount = 0;
+static bool mNPCCount = 0;
+static bool mNPCPostCount = 0;
 
-BuySellState mBuySellState = BUYSELL_NONE;
-bool mTrading = false;
+static BuySellState mBuySellState = BUYSELL_NONE;
+static bool mTrading = false;
 
-std::map<int, Special> mSpecials;
-char mSpecialRechargeUpdateNeeded = 0;
-
-int mLevelProgress = 0;
+static std::map<int, Special> mSpecials;
+static char mSpecialRechargeUpdateNeeded = 0;
 
 // --- Triggers ---------------------------------------------------------------