General code cleanups

* Use default member initializers
* Use range-based loops
* Don't use 'else' after 'return'
* Removed some unused includes
* Construct empty strings with std::string() instead of ""
* Clear strings with .clear() instead of assigning ""
* Check whether strings are empty with .empty() instead of comparing to ""
* Removed redundant initializations

1 files changed, 3 insertions, 3 deletions

diff --git a/src/gui/tradewindow.cpp b/src/gui/tradewindow.cpp
index cf237d5a..7094da26 100644
--- a/src/gui/tradewindow.cpp
+++ b/src/gui/tradewindow.cpp
@@ -165,7 +165,7 @@ void TradeWindow::reset()
     mOkMe = false;
     setMoney(0);
     mMoneyField->setEnabled(true);
-    mMoneyField->setText("");
+    mMoneyField->setText(std::string());
     mAddButton->setEnabled(true);
     mMoneyChangeButton->setEnabled(true);
     setStatus(PREPARING);
@@ -219,7 +219,7 @@ void TradeWindow::setStatus(Status s)
             break;
         case PROPOSING:
             mOkButton->setCaption(CAPTION_CONFIRMED);
-            mOkButton->setActionEventId("");
+            mOkButton->setActionEventId(std::string());
             break;
         case ACCEPTING:
             mOkButton->setCaption(CAPTION_ACCEPT);
@@ -227,7 +227,7 @@ void TradeWindow::setStatus(Status s)
             break;
         case ACCEPTED:
             mOkButton->setCaption(CAPTION_ACCEPTED);
-            mOkButton->setActionEventId("");
+            mOkButton->setActionEventId(std::string());
             break;
         default:
             break;