General code cleanups

* Use default member initializers
* Use range-based for loops
* Avoid needless pointer references for ShopItem::mDuplicates
* Removed type aliases that are only used once or twice
* Removed more unused includes
* Removed some unused functions
* Removed superfluous .c_str()
* Rely on default copy and assignment operators for Vector class
* Use std::unique_ptr in some places
* Removed duplicated mPlayerMoney updating in SellDialog
* Removed duplicated Game::handleInput call
* Removed unused SDLInput::mMouseInWindow
* Removed remnant of manual widget positioning in HelpWindow
* Removed superfluous initialization of static pointers

1 files changed, 8 insertions, 11 deletions

diff --git a/src/gui/socialwindow.h b/src/gui/socialwindow.h
index 7ffcec78..8575f3b2 100644
--- a/src/gui/socialwindow.h
+++ b/src/gui/socialwindow.h
@@ -64,7 +64,7 @@ public:
      */
     void action(const gcn::ActionEvent &event) override;
 
-    void showGuildInvite(const std::string &guildName, const int guildId,
+    void showGuildInvite(const std::string &guildName, int guildId,
                          const std::string &inviterName);
 
     void showGuildCreate();
@@ -79,19 +79,16 @@ protected:
 
     void updateButtons();
 
-    int mGuildInvited;
-    ConfirmDialog *mGuildAcceptDialog;
-    TextDialog *mGuildCreateDialog;
+    int mGuildInvited = 0;
+    ConfirmDialog *mGuildAcceptDialog = nullptr;
+    TextDialog *mGuildCreateDialog = nullptr;
 
     std::string mPartyInviter;
-    ConfirmDialog *mPartyAcceptDialog;
-    TextDialog *mPartyCreateDialog;
+    ConfirmDialog *mPartyAcceptDialog = nullptr;
+    TextDialog *mPartyCreateDialog = nullptr;
 
-    using GuildMap = std::map<Guild *, SocialTab *>;
-    GuildMap mGuilds;
-
-    using PartyMap = std::map<Party *, SocialTab *>;
-    PartyMap mParties;
+    std::map<Guild *, SocialTab *> mGuilds;
+    std::map<Party *, SocialTab *> mParties;
 
     CreatePopup *mCreatePopup;