General code cleanups

* Use default member initializers
* Use range-based for loops
* Avoid needless pointer references for ShopItem::mDuplicates
* Removed type aliases that are only used once or twice
* Removed more unused includes
* Removed some unused functions
* Removed superfluous .c_str()
* Rely on default copy and assignment operators for Vector class
* Use std::unique_ptr in some places
* Removed duplicated mPlayerMoney updating in SellDialog
* Removed duplicated Game::handleInput call
* Removed unused SDLInput::mMouseInWindow
* Removed remnant of manual widget positioning in HelpWindow
* Removed superfluous initialization of static pointers

1 files changed, 2 insertions, 4 deletions

diff --git a/src/gui/skilldialog.cpp b/src/gui/skilldialog.cpp
index c43183a2..7639f1d6 100644
--- a/src/gui/skilldialog.cpp
+++ b/src/gui/skilldialog.cpp
@@ -99,8 +99,6 @@ struct SkillInfo
     void draw(Graphics *graphics, int y, int width);
 };
 
-using SkillList = std::vector<SkillInfo *>;
-
 class SkillModel : public gcn::ListModel
 {
 public:
@@ -119,8 +117,8 @@ public:
     { mSkills.push_back(info); }
 
 private:
-    SkillList mSkills;
-    SkillList mVisibleSkills;
+    std::vector<SkillInfo *> mSkills;
+    std::vector<SkillInfo *> mVisibleSkills;
 };
 
 class SkillListBox : public ListBox