General code cleanups

* Use default member initializers
* Use range-based for loops
* Avoid needless pointer references for ShopItem::mDuplicates
* Removed type aliases that are only used once or twice
* Removed more unused includes
* Removed some unused functions
* Removed superfluous .c_str()
* Rely on default copy and assignment operators for Vector class
* Use std::unique_ptr in some places
* Removed duplicated mPlayerMoney updating in SellDialog
* Removed duplicated Game::handleInput call
* Removed unused SDLInput::mMouseInWindow
* Removed remnant of manual widget positioning in HelpWindow
* Removed superfluous initialization of static pointers

1 files changed, 1 insertions, 11 deletions

diff --git a/src/gui/sdlinput.cpp b/src/gui/sdlinput.cpp
index bcc53ccf..8396418c 100644
--- a/src/gui/sdlinput.cpp
+++ b/src/gui/sdlinput.cpp
@@ -60,9 +60,7 @@
 
 #include <guichan/exception.hpp>
 
-SDLInput::SDLInput()
-{
-}
+SDLInput::SDLInput() = default;
 
 bool SDLInput::isKeyQueueEmpty()
 {
@@ -220,8 +218,6 @@ void SDLInput::pushInput(SDL_Event event)
           if ((event.active.state & SDL_APPMOUSEFOCUS)
               && !event.active.gain)
           {
-              mMouseInWindow = false;
-
               if (!mMouseDown)
               {
                   mouseInput.setX(-1);
@@ -231,12 +227,6 @@ void SDLInput::pushInput(SDL_Event event)
                   mMouseInputQueue.push(mouseInput);
               }
           }
-
-          if ((event.active.state & SDL_APPMOUSEFOCUS)
-              && event.active.gain)
-          {
-              mMouseInWindow = true;
-          }
           break;
 #endif
     } // end switch