General code cleanups

* Use default member initializers
* Use range-based for loops
* Avoid needless pointer references for ShopItem::mDuplicates
* Removed type aliases that are only used once or twice
* Removed more unused includes
* Removed some unused functions
* Removed superfluous .c_str()
* Rely on default copy and assignment operators for Vector class
* Use std::unique_ptr in some places
* Removed duplicated mPlayerMoney updating in SellDialog
* Removed duplicated Game::handleInput call
* Removed unused SDLInput::mMouseInWindow
* Removed remnant of manual widget positioning in HelpWindow
* Removed superfluous initialization of static pointers

1 files changed, 4 insertions, 5 deletions

diff --git a/src/gui/palette.h b/src/gui/palette.h
index 1ea7c467..41378a43 100644
--- a/src/gui/palette.h
+++ b/src/gui/palette.h
@@ -72,9 +72,9 @@ class Palette
          */
         const gcn::Color &getColor(int type, int alpha = 255)
         {
-            gcn::Color *col = &mColors[type].color;
-            col->a = alpha;
-            return *col;
+            gcn::Color &col = mColors[type].color;
+            col.a = alpha;
+            return col;
         }
 
         /**
@@ -163,9 +163,8 @@ class Palette
                         committedColor.b;
             }
         };
-        using Colors = std::vector<ColorElem>;
         /** Vector containing the colors. */
-        Colors mColors;
+        std::vector<ColorElem> mColors;
         std::vector<ColorElem*> mGradVector;
 };