General code cleanups

* Use default member initializers
* Use range-based for loops
* Avoid needless pointer references for ShopItem::mDuplicates
* Removed type aliases that are only used once or twice
* Removed more unused includes
* Removed some unused functions
* Removed superfluous .c_str()
* Rely on default copy and assignment operators for Vector class
* Use std::unique_ptr in some places
* Removed duplicated mPlayerMoney updating in SellDialog
* Removed duplicated Game::handleInput call
* Removed unused SDLInput::mMouseInWindow
* Removed remnant of manual widget positioning in HelpWindow
* Removed superfluous initialization of static pointers

1 files changed, 1 insertions, 3 deletions

diff --git a/src/gui/npcdialog.cpp b/src/gui/npcdialog.cpp
index 4efa29eb..8150a01a 100644
--- a/src/gui/npcdialog.cpp
+++ b/src/gui/npcdialog.cpp
@@ -51,8 +51,6 @@
 #define CAPTION_CLOSE _("Close")
 #define CAPTION_SUBMIT _("Submit")
 
-using NpcDialogs = std::map<int, NpcDialog *>;
-
 class NpcEventListener : public EventListener
 {
 public:
@@ -63,7 +61,7 @@ public:
     void removeDialog(int id);
 
 private:
-    NpcDialogs mNpcDialogs;
+    std::map<int, NpcDialog *> mNpcDialogs;
 };
 
 static NpcEventListener *npcListener = nullptr;