diff options
| author | Thorbjørn Lindeijer <bjorn@lindeijer.nl> | 2024-03-24 19:17:41 +0100 |
|---|---|---|
| committer | Thorbjørn Lindeijer <bjorn@lindeijer.nl> | 2024-04-02 20:57:16 +0200 |
| commit | 59919635523d41f3a15120c83db4b7d080c155de (patch) | |
| tree | 0da989bd2342b5a53d49c26893a3a544e7432fcc /src/effectmanager.cpp | |
| parent | 7ea1c4574d6e845f95f2c4c3a1dd4a5d730bc6ba (diff) | |
| download | mana-59919635523d41f3a15120c83db4b7d080c155de.tar.gz mana-59919635523d41f3a15120c83db4b7d080c155de.tar.bz2 mana-59919635523d41f3a15120c83db4b7d080c155de.tar.xz mana-59919635523d41f3a15120c83db4b7d080c155de.zip | |
General code cleanups
* Removed some unused includes
* Removed unused ListBox::mFont
* Removed wrong cast to SDL_Scancode
* Removed superfluous .c_str()
* Removed superfluous explicit std::string construction
* Removed unused variable
* Use more emplace_back
* Turned FindBeingFunctor into a lambda
* Avoid needless pointer references for ambient layers and use a vector
Diffstat (limited to 'src/effectmanager.cpp')
| -rw-r--r-- | src/effectmanager.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/effectmanager.cpp b/src/effectmanager.cpp index 5de0b872..3f9cf348 100644 --- a/src/effectmanager.cpp +++ b/src/effectmanager.cpp @@ -51,11 +51,10 @@ EffectManager::EffectManager() { if (xmlStrEqual(node->name, BAD_CAST "effect")) { - EffectDescription ed; + EffectDescription &ed = mEffects.emplace_back(); ed.id = XML::getProperty(node, "id", -1); ed.GFX = XML::getProperty(node, "particle", ""); ed.SFX = XML::getProperty(node, "audio", ""); - mEffects.push_back(ed); } } } |