Centralized String to bool conversion into the client.

The former XML::getBoolProperty() had a potential memleak
and was unsafe when dealing with unknown values.

Reviewed-by: CodyMartin.

Resolves: Mana-Mantis #213.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/configuration.cpp b/src/configuration.cpp
index 6ccef401..50d76bfb 100644
--- a/src/configuration.cpp
+++ b/src/configuration.cpp
@@ -221,7 +221,7 @@ bool Configuration::getBoolValue(const std::string &key) const
     }
     else
     {
-        defaultValue = getBoolFromString(iter->second);
+        return getBoolFromString(iter->second, defaultValue);
     }
 
     return defaultValue;