Age | Commit message (Collapse) | Author | Files | Lines |
|
This makes accessing the config values much faster, since it no longer
needs to do a lookup nor string conversion, which means we could remove
some needless copying of the values.
Overall it makes it easier to find out where settings are used and it
puts the defaults along with the declaration.
Options with default values are no longer saved to the config file. This
does not include unrecognized options, which are kept around to provide
some compatibility with older clients.
While most basic options have kept the same name, more complicated
settings like window geometry, shortcuts, outfits, etc. now have their
own XML elements. Older clients will ignore these and erase them when
saving the configuration.
|
|
Previous code was assuming there would be no gaps in the emote IDs.
Also cleaned up some confusion where the "emote ID" being passed around
in the code was often offset by 1. Now it is only offset in
communication with tmwAthena and when saving the shortcuts.
|
|
Reviewed-by: Erik Schilling
|
|
Reviewed-by: Ablu
|
|
|
|
style cleanups.
TODO: Either abstract out all of the shared information between these
two classes to a parent class, or combine the two if it can be done
without doing it clumsily.
Signed-off-by: Tametomo <irarice@gmail.com>
|
|
Error was:
emoteshortcut.cpp:29:1: error: 'EmoteShortcut::EmoteShortcut' names the
constructor, not the type
|
|
The string utility methods are now grouped together in the stringutils.h
header. Also, a toLower method was added for convenience.
|
|
Decision is to go with exact authors when some file is basically done by
one person, and in most other cases assign TMW or Aethyra team copyright
when multiple people from those teams have been involved.
Also, the first summary line should now contain the subset of
functionality that the file is part of, not the name of the whole
project.
|
|
code so that only one term is used everywhere (to simplify
maintainability), as well as corrected several variable names and
comments where there was copy/pasted code, but it wasn't corrected. Also
moved emote shortcuts back to where they were originally, to reduce
player confusion when the next build comes around.
Signed-off-by: Ira Rice <irarice@gmail.com>
|