From 26aa958d27385eb026d839098974b355957d9b61 Mon Sep 17 00:00:00 2001 From: wushin Date: Mon, 27 Apr 2015 15:10:45 -0500 Subject: Update Travis for gcc 5 --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index d857970..bebade1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -102,6 +102,8 @@ matrix: env: REAL_CC=gcc-4.8 REAL_CXX=g++-4.8 PPA=ppa:ubuntu-toolchain-r/test PACKAGE=g++-4.8 DEBUGPACKAGE=libstdc++6-4.8-dbg - compiler: gcc env: REAL_CC=gcc-4.9 REAL_CXX=g++-4.9 PPA=ppa:ubuntu-toolchain-r/test PACKAGE=g++-4.9 DEBUGPACKAGE=libstdc++6-4.9-dbg + - compiler: gcc + env: REAL_CC=gcc-5 REAL_CXX=g++-5 PPA=ppa:ubuntu-toolchain-r/test PACKAGE=g++-5 DEBUGPACKAGE=libstdc++6-4.9-dbg - compiler: gcc env: REAL_CC=gcc-4.7 REAL_CXX=g++-4.7 PPA=ppa:ubuntu-toolchain-r/test PACKAGE=g++-4.7 DEBUGPACKAGE=libstdc++6-4.8-dbg EXTRA_CONFIGURE_ARGS=--disable-warnings -- cgit v1.2.3-70-g09d2 From ccf575556a5d167f128a7ff8e817af7f9f3630ed Mon Sep 17 00:00:00 2001 From: wushin Date: Mon, 27 Apr 2015 17:16:03 -0500 Subject: Fix T Sub in a return-statement --- src/ints/wrap.hpp | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/ints/wrap.hpp b/src/ints/wrap.hpp index 707c787..25b03c1 100644 --- a/src/ints/wrap.hpp +++ b/src/ints/wrap.hpp @@ -63,6 +63,14 @@ namespace ints return l._value < r._value; } + template + struct Sub : T + { + constexpr + Sub(typename T::wrapped_type v2) + : T(v2) + {} + }; template constexpr typename T::wrapped_type unwrap(typename std::enable_if::type w) @@ -73,14 +81,7 @@ namespace ints constexpr T wrap(typename T::wrapped_type v) { - struct Sub : T - { - constexpr - Sub(typename T::wrapped_type v2) - : T(v2) - {} - }; - return Sub(v); + return Sub(v); } template -- cgit v1.2.3-70-g09d2 From a5d6e25bdbccd24f750852dcc0b3cd7b83e339d6 Mon Sep 17 00:00:00 2001 From: wushin Date: Sun, 24 May 2015 12:31:19 -0500 Subject: Unused var array --- src/map/script-fun.cpp | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/map/script-fun.cpp b/src/map/script-fun.cpp index 3949627..8b797c2 100644 --- a/src/map/script-fun.cpp +++ b/src/map/script-fun.cpp @@ -66,21 +66,6 @@ namespace tmwa { namespace map { -static -Array pos_str //= -{{ - "Head"_s, - "Body"_s, - "Left hand"_s, - "Right hand"_s, - "Robe"_s, - "Shoes"_s, - "Accessory 1"_s, - "Accessory 2"_s, - "Head 2"_s, - "Head 3"_s, - "Not Equipped"_s, -}}; #define AARG(n) (st->stack->stack_datav[st->start + 2 + (n)]) #define HARG(n) (st->end > st->start + 2 + (n)) -- cgit v1.2.3-70-g09d2 From b8519f9aa5ecd6cad984d53b27269ae9dec37b47 Mon Sep 17 00:00:00 2001 From: wushin Date: Sun, 24 May 2015 12:29:07 -0500 Subject: Unintialized Byte --- src/wire/packets.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/wire/packets.cpp b/src/wire/packets.cpp index be06283..22a996a 100644 --- a/src/wire/packets.cpp +++ b/src/wire/packets.cpp @@ -76,6 +76,7 @@ void packet_dump(Session *s) if ((i & 15) == 0) FPRINTF(stderr, "%04X "_fmt, i); Byte rfifob_ib; + rfifob_ib.value = 0; packet_fetch(s, i, &rfifob_ib, 1); uint8_t rfifob_i = rfifob_ib.value; FPRINTF(stderr, "%02x "_fmt, rfifob_i); -- cgit v1.2.3-70-g09d2 From 097e924102d7f9de5fed7c7bc537e378b72a6340 Mon Sep 17 00:00:00 2001 From: wushin Date: Sun, 24 May 2015 19:13:09 -0500 Subject: Fix fabi gcc travis --- .travis.yml | 6 +++--- Makefile.in | 6 +++--- configure | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index bebade1..accc0ba 100644 --- a/.travis.yml +++ b/.travis.yml @@ -57,8 +57,8 @@ script: - mkdir build - cd build - git init - - echo ../configure --build=x86_64-linux-gnu --dev CPPFLAGS=-DQUIET `! [[ $CXX =~ clang* ]] || echo --disable-abi6` $EXTRA_CONFIGURE_ARGS - - ../configure --build=x86_64-linux-gnu --dev CPPFLAGS=-DQUIET `! [[ $CXX =~ clang* ]] || echo --disable-abi6` $EXTRA_CONFIGURE_ARGS + - echo ../configure --build=x86_64-linux-gnu --dev CPPFLAGS=-DQUIET `! [[ $CXX =~ clang* ]] || echo --disable-abi` $EXTRA_CONFIGURE_ARGS + - ../configure --build=x86_64-linux-gnu --dev CPPFLAGS=-DQUIET `! [[ $CXX =~ clang* ]] || echo --disable-abi` $EXTRA_CONFIGURE_ARGS - make -R -k -j2 - make -R -k -j2 test TESTER='valgrind --error-exitcode=1 --track-fds=yes' @@ -103,7 +103,7 @@ matrix: - compiler: gcc env: REAL_CC=gcc-4.9 REAL_CXX=g++-4.9 PPA=ppa:ubuntu-toolchain-r/test PACKAGE=g++-4.9 DEBUGPACKAGE=libstdc++6-4.9-dbg - compiler: gcc - env: REAL_CC=gcc-5 REAL_CXX=g++-5 PPA=ppa:ubuntu-toolchain-r/test PACKAGE=g++-5 DEBUGPACKAGE=libstdc++6-4.9-dbg + env: REAL_CC=gcc-5 REAL_CXX=g++-5 PPA=ppa:ubuntu-toolchain-r/test PACKAGE=g++-5 DEBUGPACKAGE=libstdc++6-5-dbg - compiler: gcc env: REAL_CC=gcc-4.7 REAL_CXX=g++-4.7 PPA=ppa:ubuntu-toolchain-r/test PACKAGE=g++-4.7 DEBUGPACKAGE=libstdc++6-4.8-dbg EXTRA_CONFIGURE_ARGS=--disable-warnings diff --git a/Makefile.in b/Makefile.in index 006594a..779ca04 100644 --- a/Makefile.in +++ b/Makefile.in @@ -47,7 +47,7 @@ GTEST_DIR = @GTEST_DIR@ GDB = @GDB@ ENABLE_WARNINGS = @ENABLE_WARNINGS@ -ENABLE_ABI6 = @ENABLE_ABI6@ +ENABLE_ABI = @ENABLE_ABI@ ENABLE_CYGWIN_HACKS = @ENABLE_CYGWIN_HACKS@ ENABLE_DEBUG = @ENABLE_DEBUG@ ENABLE_RPATH = @ENABLE_RPATH@ @@ -276,8 +276,8 @@ WARNINGS := -include ${SRC_DIR}/src/warnings.hpp endif # related to gdb bug 15801 -ifeq (${ENABLE_ABI6},yes) -CXXFLAGS += -fabi-version=6 +ifeq (${ENABLE_ABI},yes) +CXXFLAGS += -fabi-version=8 endif # This needs to edit CXX instead of CXXFLAGS in order to make diff --git a/configure b/configure index dc67d49..2693f32 100755 --- a/configure +++ b/configure @@ -50,7 +50,7 @@ class Configuration(Cxx, Install, ConfigHash, Templates): home = os.path.expanduser('~') self.add_alias('--user', ['--prefix=%s' % home, '--enable-rpath=relative'], help='alias for --prefix=$HOME --enable-rpath=relative', hidden=False) - self.add_alias('--dev', ['--user', '--enable-warnings', '--enable-abi6'], + self.add_alias('--dev', ['--user', '--enable-warnings', '--enable-abi'], help=None, hidden=False) def paths(self): @@ -66,8 +66,8 @@ class Configuration(Cxx, Install, ConfigHash, Templates): self.add_bool_feature('warnings', init='no', check=lambda build, ENABLE_WARNINGS: None, help='Enable warnings (for development)') - self.add_bool_feature('abi6', init='no', - check=lambda build, ENABLE_ABI6: None, + self.add_bool_feature('abi', init='no', + check=lambda build, ENABLE_ABI: None, help='Force a nonbuggy gcc ABI (for development)') self.add_bool_feature('cygwin-hacks', init='no', check=lambda build, ENABLE_CYGWIN_HACKS: None, -- cgit v1.2.3-70-g09d2