From a9732d3ad6115ad7d590e819631dfbd764d13d3e Mon Sep 17 00:00:00 2001 From: Andrei Karas Date: Sun, 7 Apr 2013 21:01:35 +0300 Subject: remove useless checks. --- src/net/ea/partyhandler.cpp | 2 +- src/net/eathena/beinghandler.cpp | 7 ++----- src/net/eathena/charserverhandler.cpp | 2 +- src/net/tmwa/beinghandler.cpp | 7 ++----- src/net/tmwa/charserverhandler.cpp | 2 +- 5 files changed, 7 insertions(+), 13 deletions(-) (limited to 'src/net') diff --git a/src/net/ea/partyhandler.cpp b/src/net/ea/partyhandler.cpp index 6172fce34..92cf48a2d 100644 --- a/src/net/ea/partyhandler.cpp +++ b/src/net/ea/partyhandler.cpp @@ -194,7 +194,7 @@ void PartyHandler::processPartyInvited(Net::MessageIn &msg) { if ((being = actorSpriteManager->findBeing(id))) { - if (being && being->getType() == Being::PLAYER) + if (being->getType() == Being::PLAYER) nick = being->getName(); } } diff --git a/src/net/eathena/beinghandler.cpp b/src/net/eathena/beinghandler.cpp index f62d4d9db..6fb7ee087 100644 --- a/src/net/eathena/beinghandler.cpp +++ b/src/net/eathena/beinghandler.cpp @@ -377,11 +377,8 @@ void BeingHandler::processBeingChangeLook(Net::MessageIn &msg, default: logger->log("QQQ3 CHANGE_LOOKS: unsupported type: " "%d, id: %d", type, id); - if (dstBeing) - { - logger->log("ID: " + toString(dstBeing->getId())); - logger->log("name: " + toString(dstBeing->getName())); - } + logger->log("ID: " + toString(dstBeing->getId())); + logger->log("name: " + toString(dstBeing->getName())); break; } } diff --git a/src/net/eathena/charserverhandler.cpp b/src/net/eathena/charserverhandler.cpp index 2fee39a03..ca4275ebe 100644 --- a/src/net/eathena/charserverhandler.cpp +++ b/src/net/eathena/charserverhandler.cpp @@ -286,7 +286,7 @@ void CharServerHandler::processCharLogin(Net::MessageIn &msg) Net::Character *const character = new Net::Character; readPlayerData(msg, character, false); mCharacters.push_back(character); - if (character && character->dummy) + if (character->dummy) { logger->log("CharServer: Player: %s (%d)", character->dummy->getName().c_str(), character->slot); diff --git a/src/net/tmwa/beinghandler.cpp b/src/net/tmwa/beinghandler.cpp index a7300f601..28f7fc999 100644 --- a/src/net/tmwa/beinghandler.cpp +++ b/src/net/tmwa/beinghandler.cpp @@ -377,11 +377,8 @@ void BeingHandler::processBeingChangeLook(Net::MessageIn &msg, default: logger->log("QQQ3 CHANGE_LOOKS: unsupported type: " "%d, id: %d", type, id); - if (dstBeing) - { - logger->log("ID: " + toString(dstBeing->getId())); - logger->log("name: " + toString(dstBeing->getName())); - } + logger->log("ID: " + toString(dstBeing->getId())); + logger->log("name: " + toString(dstBeing->getName())); break; } } diff --git a/src/net/tmwa/charserverhandler.cpp b/src/net/tmwa/charserverhandler.cpp index 0b449bff8..d2f727af9 100644 --- a/src/net/tmwa/charserverhandler.cpp +++ b/src/net/tmwa/charserverhandler.cpp @@ -330,7 +330,7 @@ void CharServerHandler::processCharLogin(Net::MessageIn &msg) Net::Character *const character = new Net::Character; readPlayerData(msg, character, version); mCharacters.push_back(character); - if (character && character->dummy) + if (character->dummy) { logger->log("CharServer: Player: %s (%d)", character->dummy->getName().c_str(), character->slot); -- cgit v1.2.3-70-g09d2