From 0a9dd8b9971ac39f451bb0543c93b4308de29c36 Mon Sep 17 00:00:00 2001
From: Fedja Beader <fedja@protonmail.ch>
Date: Sat, 1 Mar 2025 00:29:51 +0000
Subject: Report missing/unknown attr fields in clientdata stats.xml

This makes sure that ml/clientdata!180 never happens again via message
in Debug tab.

The legacy numeric ID method could be deprecated. Maybe after release.
The client uses full attribute names since 2016.

****
mana/plus!137
---
 src/resources/db/statdb.cpp | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/resources/db/statdb.cpp b/src/resources/db/statdb.cpp
index 36c26f1e3..adedb1102 100644
--- a/src/resources/db/statdb.cpp
+++ b/src/resources/db/statdb.cpp
@@ -121,11 +121,15 @@ static void loadStats(XmlNodeConstPtr rootNode,
                     reportAlways("Wrong attr or id for %s stat with name %s",
                                  (isBasic ? "basic" : "extended"),
                                  name.c_str())
-                    continue;
                 }
-
-                stats.push_back(BasicStat(static_cast<AttributesT>(id),
-                                          tag, name));
+                else
+                {
+                    reportAlways("StatDb: stat name '%s' has empty attr field"
+                                 ", using legacy method (id).",
+                                 name.c_str());
+                    stats.push_back(BasicStat(static_cast<AttributesT>(id),
+                                              tag, name));
+                }
             }
             else
             {
-- 
cgit v1.2.3-70-g09d2